fix(release): accept tool-only completion signal#102600
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
gateway
Contributor
|
Codex review: needs real behavior proof before merge. Reviewed July 9, 2026, 5:39 AM ET / 09:39 UTC. Summary PR surface: Tests +45. Total +45 across 1 file. Reproducibility: yes. The linked focused release run shows the OpenAI gateway-profile lane failing on Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the malformed completion tolerance scoped to optional tool-only turns, but require independent tool-effect proof before accepting the run, such as checking transcript/tool events or asking a follow-up that does not embed the expected nonce values. Do we have a high-confidence way to reproduce the issue? Yes. The linked focused release run shows the OpenAI gateway-profile lane failing on Is this the best way to solve the issue? No. The patch is a plausible harness mitigation, but the best fix must make the follow-up proof independent of the expected nonce values or inspect the tool transcript/effect before accepting the malformed completion envelope. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6433b8272350. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +45. Total +45 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
rating: 🦪 silver shellfish
Contributor
Author
|
Land-ready at exact head What changed:
Proof:
Known proof gaps: none for the changed surface. |
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 9, 2026
vincentkoc
pushed a commit
that referenced
this pull request
Jul 9, 2026
* test(release): accept tool-only completion signal * test(release): retry transient tool-read failures (cherry picked from commit 60bef7b)
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 10, 2026
* test(release): accept tool-only completion signal * test(release): retry transient tool-read failures
RomneyDa
pushed a commit
that referenced
this pull request
Jul 15, 2026
* test(release): accept tool-only completion signal * test(release): retry transient tool-read failures (cherry picked from commit 60bef7b)
RomneyDa
added a commit
that referenced
this pull request
Jul 15, 2026
* test(release): allow tool-only live turn without transcript (cherry picked from commit 6801d34) * test(live): validate final tool probe reply (cherry picked from commit 3442a8e) * test(live): wait for terminal transcript projection (cherry picked from commit 1f49d94) * fix(release): accept tool-only completion signal (#102600) * test(release): accept tool-only completion signal * test(release): retry transient tool-read failures (cherry picked from commit 60bef7b) * test(live): correlate tool-read retries (#103204) Partial backport of the v6.11-compatible transcript correlation and completed-without-reply retry contract only. (cherry picked from commit 8511585) * docs(changelog): refresh 2026.6.33 record --------- Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Peter Steinberger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where the OpenAI gateway-profile release lane failed after a successful intentionally tool-only turn because
agent.waitreturned the known malformed{ status: "error", error: "completed" }envelope.Why This Change Was Made
The live harness now accepts that envelope only when assistant text is explicitly optional. Required-text turns and every other error remain strict, and the following turn must still prove that the tool state is usable.
User Impact
No runtime behavior changes. Release validation no longer reports a false failure for successful tool-only OpenAI turns.
Evidence
oxfmt --checkpassed for the changed file