fix(macos): remove stale .sidebar-shell__header rule from injected dashboard CSS#102526
Merged
Conversation
openclaw-barnacle
Bot
added
app: macos
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The macOS dashboard window injects native-chrome CSS into the web UI (
installNativeChromeScript). One of the injected rules targets.sidebar-shell__header, but that class no longer exists anywhere inui/src— the sidebar template renders onlysidebar-shell,sidebar-shell__body, andsidebar-shell__footer(ui/src/components/app-sidebar.ts:1660). The rule is dead weight shipped into every dashboard page load.Why This Change Was Made
Stale injected CSS makes the native-chrome contract look larger than it is and misleads future readers into thinking the web UI still has a sidebar header element the Mac app styles. Pure dead-code deletion.
User Impact
None visible. The load-bearing
.sidebar-shellpadding-top rule (clears the macOS traffic-light strip) is untouched.Evidence
grep -rn "sidebar-shell__header" ui/src→ no matches; only occurrence in the repo was the injected CSS string inapps/macos/Sources/OpenClaw/DashboardWindowController.swift.ui/src/components/app-sidebar.ts:1660renderssidebar-shell/__body/__footeronly.git diff --checkclean.