Skip to content

fix: collapse sidebar after returning from drawer layout#102463

Merged
steipete merged 2 commits into
mainfrom
codex/fix-sidebar-collapse
Jul 9, 2026
Merged

fix: collapse sidebar after returning from drawer layout#102463
steipete merged 2 commits into
mainfrom
codex/fix-sidebar-collapse

Conversation

@steipete

@steipete steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Fixes an issue where users who opened the navigation drawer at a narrow viewport and then returned to the desktop layout would see the sidebar collapse button do nothing on its first click.

Why This Change Was Made

The desktop navigation toggle now reconciles any drawer state that survived a breakpoint change before persisting the desktop collapse preference. The existing desktop-only toggle behavior remains unchanged.

User Impact

The Control UI sidebar collapses on the first click after moving from the tablet drawer layout back to desktop.

Evidence

  • Reproduced in the existing Chrome profile: open the drawer at 900 px, widen to 1440 px, then click Collapse sidebar; the sidebar remained expanded before this fix.
  • Regression test failed before the fix because .shell retained shell--nav-drawer-open and never gained shell--nav-collapsed.
  • Blacksmith Testbox tbx_01kx2r3eyyb8zk2cxeeydvk3vm: node scripts/run-vitest.mjs run --config test/vitest/vitest.ui-e2e.config.ts --configLoader runner ui/src/e2e/sidebar-customization.e2e.test.ts — 2 tests passed. The scenario captures 06-desktop-collapse-after-drawer.png after the corrected transition.
  • Same Testbox: corepack pnpm check:changed — passed core/core-test typechecks, changed-file lint, and repository policy guards.
  • Fresh autoreview --mode local: no accepted or actionable findings; patch correctness 0.95.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 9, 2026
@clawsweeper

clawsweeper Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: collapse sidebar after returning from drawer layout This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit 5f91f6c into main Jul 9, 2026
74 checks passed
@steipete
steipete deleted the codex/fix-sidebar-collapse branch July 9, 2026 06:42
@steipete

steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 9, 2026
…2463)

* fix(ui): collapse sidebar after drawer resize

* chore: defer sidebar release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant