fix(ui): close session sort menu on second click#102448
Conversation
openclaw-barnacle
Bot
added
app: web-ui
|
Codex review: stale review; fresh review needed. Summary Next step |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f609a4d78d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Fixes | ||
|
|
||
| - **Control UI session sorting:** close the sidebar Group by / Sort by menu when its trigger is clicked again. |
There was a problem hiding this comment.
For this normal UI fix, root AGENTS.md's Docs / Changelog policy says CHANGELOG.md is release-only and release generation derives entries from merged PRs/direct commits. Keeping this manual Unreleased row makes the generated release notes liable to duplicate or drift from canonical commit/PR metadata; move the release-note context to the PR/squash message instead.
Useful? React with 👍 / 👎.
|
Merged via squash.
|
* fix(ui): toggle session sort menu * chore: defer session menu release note
1 participant
What Problem This Solves
Fixes an issue where users clicking the sidebar session Group by / Sort by trigger a second time would see the menu remain open.
Why This Change Was Made
The trigger now owns explicit toggle behavior while the document pointer handler treats that active trigger as part of the menu interaction. Option selection, Escape, and outside-click dismissal keep their existing behavior.
User Impact
Users can click the session filter button once to show the menu and again to dismiss it.
AI-assisted implementation; reviewed and understood by the maintainer.
Evidence
aria-expandedremainedtrueafter the second trigger click.corepack pnpm test:ui:e2e -- ui/src/e2e/session-management.e2e.test.ts— 4/4 passed on Blacksmith Testboxtbx_01kx2q4mrw00wpnyy40cmy9ccbafter the final rebase.corepack pnpm check:changed— passed on the same Testbox.corepack pnpm build— passed on the same Testbox..agents/skills/autoreview/scripts/autoreview --mode local --stream-engine-output— clean; no accepted/actionable findings.