fix(secrets): prevent capture and sentinel credential retention#102420
Merged
Conversation
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step |
Contributor
Author
|
Land-ready at Evidence:
Known proof gaps: none. |
Contributor
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 9, 2026
…claw#102420) * fix(secrets): harden sentinel capture lifecycle * chore: leave release notes to release automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Follow-up to #102009 / #102008. The first SecretRef egress implementation kept every resolved plaintext credential in unbounded process-lifetime sentinel maps, while debug proxy capture could persist registered credentials when they appeared outside sensitive headers (URLs, payloads, errors, metadata, and content types).
Closes #102388.
Why This Change Was Made
User Impact
SecretRef-backed provider credentials still resolve only at the final egress boundary, but long-running processes no longer accumulate plaintext sentinel history. Debug capture no longer writes registered credentials when they occur in captured URLs, bodies, errors, metadata, or content-type fields.
Evidence
tbx_01kx2ekbaa1za8trkptk1skd4q: 235 focused tests passed across proxy capture, logging redaction, sentinels, and provider egress.check:changedpassed core/core-tests typechecks, lint, import-cycle checks, and architecture guards.