fix: send owner-qualified install telemetry#102377
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 8, 2026, 11:11 PM ET / 03:11 UTC. Summary PR surface: Source -36, Tests -6. Total -42 across 4 files. Reproducibility: yes. Source inspection of current main shows install telemetry is built from the legacy lockfile snapshot and omits ownerHandle, while the PR's E2E path exercises an owner-qualified install and inspects the posted body. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Merge after openclaw/clawhub#3024 is deployed and a redacted real install proves owner-qualified telemetry is accepted without affecting the local install flow. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection of current main shows install telemetry is built from the legacy lockfile snapshot and omits ownerHandle, while the PR's E2E path exercises an owner-qualified install and inspects the posted body. Is this the best way to solve the issue? Yes for code direction. Sending one canonical install event from the existing parsed owner-qualified install path is narrower than reporting the whole lockfile, but the merge should wait for backend schema deployment and real behavior proof. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f77c2aafa095. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -36, Tests -6. Total -42 across 4 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
ownerHandlealongside the skill slug and resolved version or GitHub commitCompanion backend/schema fix: openclaw/clawhub#3024
Related production failure: Sentry issue 7601180865.
Validation
node scripts/run-vitest.mjs src/skills/lifecycle/clawhub.test.ts src/cli/skills-cli.clawhub-install.e2e.test.tsnode scripts/run-oxlint.mjs src/infra/clawhub.ts src/skills/lifecycle/clawhub.ts src/skills/lifecycle/clawhub.test.ts src/cli/skills-cli.clawhub-install.e2e.test.ts./node_modules/.bin/oxfmt --check --threads=1 src/infra/clawhub.ts src/skills/lifecycle/clawhub.ts src/skills/lifecycle/clawhub.test.ts src/cli/skills-cli.clawhub-install.e2e.test.ts