Skip to content

refactor(zalo): localize internal declarations#102065

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v89
Jul 8, 2026
Merged

refactor(zalo): localize internal declarations#102065
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v89

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The Zalo plugin still exported ten declaration-only implementation types that have no consumers outside their defining modules. That unnecessarily widens the plugin's internal TypeScript surface.

Why This Change Was Made

Repository-wide exact-name search and the refreshed codebase-memory graph found no external consumers. Zalo's explicit public barrels do not expose these declarations, so they can remain module-local without changing exported functions, monitor entrypoints, structural signatures, or runtime behavior.

User Impact

None. This is a dead-export cleanup; Zalo behavior and intentional public entrypoints are unchanged.

Evidence

  • Refreshed codebase-memory graph: 281,396 nodes / 1,134,242 edges
  • Changed gates passed on Testbox tbx_01kx0686z4zbjfvgft12rb9egc
  • Complete Zalo suite: 25 files and 115 tests passed
  • Full pnpm build: passed, including declaration generation and plugin SDK export checks
  • Pre-commit autoreview: clean, confidence 0.90
  • Committed branch autoreview: clean, confidence 0.87
  • Post-edit dead-export scan: no remaining candidates for the ten declarations
  • git diff --check: passed

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: zalo Channel integration: zalo size: XS maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 2fbc0a0526ff61f28be9a9ac59f802cbaaefd449:

  • refreshed codebase-memory graph: 281,396 nodes / 1,134,242 edges
  • Testbox tbx_01kx0686z4zbjfvgft12rb9egc / Actions run https://github.com/openclaw/openclaw/actions/runs/28922131087
  • changed gates passed
  • complete Zalo suite: 25 files and 115 tests passed
  • full pnpm build passed, including declaration generation and plugin SDK export checks
  • pre-commit autoreview: no findings, confidence 0.90
  • committed branch autoreview: no findings, confidence 0.87
  • post-edit dead-export scan found no remaining candidates for the ten declarations
  • git diff --check passed
  • repo-native review artifacts and scripts/pr prepare-run 102065 passed

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 06:30
@vincentkoc
vincentkoc merged commit fc4626c into main Jul 8, 2026
108 of 111 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v89 branch July 8, 2026 06:31
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: zalo Channel integration: zalo maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant