Skip to content

refactor(voice-call): localize internal declarations#102059

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v88
Jul 8, 2026
Merged

refactor(voice-call): localize internal declarations#102059
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v88

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The voice-call plugin still exported twelve declaration-only implementation types that have no consumers outside their defining modules. That unnecessarily widens the plugin's internal TypeScript surface.

Why This Change Was Made

Repository-wide exact-name search and the refreshed codebase-memory graph found no external consumers. The plugin's explicit API barrels do not expose these declarations, so they can remain module-local without changing exported functions, classes, structural signatures, or runtime behavior.

User Impact

None. This is a dead-export cleanup; voice-call behavior and intentional public entrypoints are unchanged.

Evidence

  • Rebasing onto exact origin/main 19f7b72a74731438f15aafbfc7c84593f6151dfc completed cleanly after overlapping voice-call changes landed
  • Refreshed codebase-memory graph: 281,412 nodes / 1,138,333 edges
  • Changed gates passed on Testbox tbx_01kx05mxj3z4p5p6g52w23rg78
  • Complete voice-call suite: 50 files and 522 tests passed
  • Full pnpm build: passed, including declaration generation and plugin SDK export checks
  • Fresh post-rebase branch autoreview: clean, confidence 0.86
  • Post-rebase dead-export scan: no remaining candidates for the twelve declarations
  • git diff --check: passed

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: voice-call Channel integration: voice-call size: XS maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 8ca638296df9d986b9c19a8b03ebf97912d2ad7c:

  • rebased onto exact current base 19f7b72a74731438f15aafbfc7c84593f6151dfc, including overlapping voice-call changes
  • refreshed codebase-memory graph: 281,412 nodes / 1,138,333 edges
  • Testbox tbx_01kx05mxj3z4p5p6g52w23rg78 / Actions run https://github.com/openclaw/openclaw/actions/runs/28921663989
  • changed gates passed
  • complete voice-call suite: 50 files and 522 tests passed
  • full pnpm build passed, including declaration generation and plugin SDK export checks
  • fresh post-rebase branch autoreview: no findings, confidence 0.86
  • post-rebase dead-export scan found no remaining candidates for the twelve declarations
  • git diff --check passed
  • repo-native review artifacts and scripts/pr prepare-run 102059 passed

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 06:19
@vincentkoc
vincentkoc merged commit c46e76c into main Jul 8, 2026
116 of 118 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v88 branch July 8, 2026 06:20
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: voice-call Channel integration: voice-call maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant