Skip to content

fix(codex): transfer typed generated images#102054

Open
sjf-oa wants to merge 6 commits into
mainfrom
sjf/cla-20-image-generation
Open

fix(codex): transfer typed generated images#102054
sjf-oa wants to merge 6 commits into
mainfrom
sjf/cla-20-image-generation

Conversation

@sjf-oa

@sjf-oa sjf-oa commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Persist image bytes from the typed Codex imageGeneration item into managed media before delivery. This prevents remote app-server savedPath values from being treated as local files and removes the dependency on the optional raw-response event.

Refresh the app directory once before paginating the refreshed snapshot.

Make the Codex-native image contract explicit so an image-generation turn completes after one successful generation and automatic attachment can run.

Validation

  • Focused media, inventory, and instruction-order regressions passed before the final rebase.
  • Formatting and git diff --check passed on the final rebased runtime head.
  • Prompt snapshots were regenerated, and the exact snapshot checker passes on the final PR head.
  • Runtime commit 50dabb082ed581081125243464d45476e78c6a63 was rebuilt as ghcr.io/sjf/openclaw:cla-20-50dabb082e-amd64 with index digest sha256:42ad614096a7dbf2beb0c47a421facfa63958a902ae421db78deccce840b4776.
  • The exact rebuilt image delivered one Codex-native PNG end to end through sjfclaw at 5:28 PM PDT on July 8, 2026: 1,464,916 bytes, 1254x1254, SHA-256 e8c8fc50695c0c88bc5308040c17abf98e44660ebd3f99f2e13df2f7b73221f8, with no media warning.
  • The separate OpenClaw image_generate path was forced with openai/gpt-image-2 and delivered exactly one new PNG through sjfclaw at 6:06 PM PDT on July 8, 2026: 1,261,777 bytes, 1024x1024, SHA-256 7a4405d958e9846747b9195bba82d3ac5a0d39f2b34cd1f87cbc89e9ad8d0ba4, with no media warning or duplicate.
  • Full local collection on the final rebase is blocked by the package firewall rejecting a new base-branch dependency; the complete standard CI matrix passed. An optional agentic Telegram proof did not start because its repository API-key secret was absent.

@clawsweeper

clawsweeper Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 11:26 PM ET / 03:26 UTC.

Summary
The PR persists typed Codex imageGeneration.result bytes into gateway-managed media, bounds forced app-inventory refresh to the first page, and updates native-image delivery prompt tests and snapshots.

PR surface: Source +46, Tests +86. Total +132 across 9 files.

Reproducibility: yes. source-reproducible: current main trusts typed savedPath, while upstream Codex makes typed result required and saved_path optional. This read-only review did not rerun the live flow.

Review metrics: 1 noteworthy metric.

  • Prompt Instruction Surface: 1 instruction added. The PR changes Codex developer instructions, so prompt snapshots and user-visible delivery proof matter before merge.

Stored data model
Persistent data-model change detected: persistent cache schema: extensions/codex/src/app-server/app-inventory-cache.test.ts, serialized state: extensions/codex/src/app-server/event-projector.test.ts. Confirm migration or upgrade compatibility proof before merge.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Mantis proof suggestion
A Telegram Desktop proof would materially show the generated-image attachment path without asking Mantis to mutate the PR. A maintainer can ask Mantis to capture proof by posting this exact PR comment:

@openclaw-mantis telegram desktop proof: verify that a Codex-native image-generation turn delivers exactly one image attachment with no media warning.

Risk before merge

  • [P1] The changed projector path controls whether source channels receive zero, one, or duplicate generated-image attachments, so message-delivery regressions remain the main merge risk despite focused tests and live-output proof.
  • [P1] The branch is mergeable but behind current main, so landing should use a refresh or merge-queue exact-head check rather than relying only on the stale head state.

Maintainer options:

  1. Land After Exact-Head Checks (recommended)
    Maintainers can accept the remaining attachment-delivery risk after a refresh or merge queue proves the current head against main.
  2. Request Telegram Attachment Proof
    Maintainers can require a short Telegram Desktop proof that one generated image is delivered with no warning or duplicate before merge.

Next step before merge

  • No ClawSweeper repair remains; the protected maintainer label and channel-delivery risk need maintainer landing review after exact-head checks.

Maintainer decision needed

  • Question: Is the current live-output proof and focused regression coverage enough to accept the generated-image message-delivery risk after exact-head checks, or should maintainers require Telegram Desktop proof before landing?
  • Rationale: The patch is the right code-path fix, but it changes automatic media delivery for source channels and the PR carries a protected maintainer label, so a human should accept the remaining channel-delivery risk.
  • Likely owner: steipete — steipete has earlier native-image delivery history and is one of the live requested reviewers for this PR.
  • Options:
    • Land After Exact-Head Checks (recommended): Accept the bounded message-delivery risk once the branch is refreshed or merge-queue checks prove the exact head.
    • Require Telegram Proof: Ask for a short Telegram Desktop run showing exactly one Codex-native image attachment and no media warning before merge.

Security
Cleared: The diff stays within Codex plugin runtime/tests and prompt snapshots, with no workflow, dependency, lockfile, package, secret, or third-party code-execution surface added.

Review details

Best possible solution:

Land the projector-bound typed-result transfer after maintainer review and exact-head checks; optional Telegram Desktop proof can further reduce channel-visible attachment uncertainty.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible: current main trusts typed savedPath, while upstream Codex makes typed result required and saved_path optional. This read-only review did not rerun the live flow.

Is this the best way to solve the issue?

Yes. Persisting typed result bytes at the Codex app-server projector boundary is narrower and more durable than relying on app-server-local paths or optional raw-response events.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 1252a3da59a8.

Label changes

Label justifications:

  • P2: This is a normal Codex generated-image delivery fix with focused scope and limited blast radius.
  • merge-risk: 🚨 message-delivery: The diff changes the projector path that turns Codex-generated images into source-channel reply media, so regressions could suppress or duplicate attachments.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body provides after-fix live output for rebuilt runtime image delivery through a real source setup, including image sizes, dimensions, hashes, timestamps, and no media warning.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides after-fix live output for rebuilt runtime image delivery through a real source setup, including image sizes, dimensions, hashes, timestamps, and no media warning.
  • mantis: telegram-visible-proof: Mantis should capture Telegram visible proof. The changed behavior is visible as a Telegram image attachment and can be demonstrated in a short Telegram Desktop recording.
Evidence reviewed

PR surface:

Source +46, Tests +86. Total +132 across 9 files.

View PR surface stats
Area Files Added Removed Net
Source 3 71 25 +46
Tests 6 121 35 +86
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 9 192 60 +132

What I checked:

Likely related people:

  • sjf-oa: Authored the merged remote app-server generated-image managed-media repair that this PR builds on. (role: recent generated-image delivery contributor; confidence: high; commits: d9298a74be69; files: extensions/codex/src/app-server/event-projector.ts, extensions/codex/src/app-server/event-projector.test.ts)
  • joshavant: Authored the merged raw Codex image-generation media projection that established managed media handling for raw image results. (role: prior raw generated-image projection contributor; confidence: high; commits: f870beac85ec; files: extensions/codex/src/app-server/event-projector.ts, extensions/codex/src/app-server/event-projector.test.ts, extensions/codex/src/app-server/run-attempt.turn-watches.test.ts)
  • steipete: Authored earlier native image output delivery and adjacent Codex app-server runtime work. (role: earlier native-image delivery contributor; confidence: high; commits: 5821a4033cd2, 554d772c1a83; files: extensions/codex/src/app-server/event-projector.ts, extensions/codex/src/app-server/thread-lifecycle.ts, extensions/codex/src/app-server/run-attempt.test.ts)
  • vincentkoc: Current-main blame on the localized projector and adjacent Codex app-server files points to a recent file-localization refactor, which is a routing signal rather than original feature ownership. (role: recent area contributor; confidence: medium; commits: fc4626c1221d; files: extensions/codex/src/app-server/event-projector.ts, extensions/codex/src/app-server/app-inventory-cache.ts, extensions/codex/src/app-server/thread-lifecycle.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (15 earlier review cycles; latest 8 shown)
  • reviewed 2026-07-08T23:57:32.731Z sha 660e72e :: needs maintainer review before merge. :: none
  • reviewed 2026-07-09T00:30:00.864Z sha 50dabb0 :: needs real behavior proof before merge. :: [P2] Regenerate the Codex prompt snapshots
  • reviewed 2026-07-09T00:48:26.550Z sha 0dada97 :: needs maintainer review before merge. :: none
  • reviewed 2026-07-09T01:14:33.526Z sha 0dada97 :: needs maintainer review before merge. :: none
  • reviewed 2026-07-09T01:25:14.294Z sha 0dada97 :: needs maintainer review before merge. :: none
  • reviewed 2026-07-09T01:33:05.887Z sha 0dada97 :: needs changes before merge. :: [P2] Update the run-attempt media expectation
  • reviewed 2026-07-09T03:05:48.542Z sha d23ed81 :: needs maintainer review before merge. :: none
  • reviewed 2026-07-09T03:18:46.168Z sha d23ed81 :: needs maintainer review before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. proof: sufficient ClawSweeper judged the real behavior proof convincing. merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. labels Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: telegram Channel integration: telegram gateway Gateway runtime agents Agent runtime and tooling size: XL and removed size: S labels Jul 8, 2026
@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. mantis: telegram-visible-proof Mantis should capture Telegram visible proof. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Jul 8, 2026
@sjf-oa
sjf-oa force-pushed the sjf/cla-20-image-generation branch from 660e72e to b86040c Compare July 9, 2026 00:00
@openclaw-barnacle openclaw-barnacle Bot added size: S and removed docs Improvements or additions to documentation channel: telegram Channel integration: telegram gateway Gateway runtime agents Agent runtime and tooling size: XL labels Jul 9, 2026
@clawsweeper clawsweeper Bot added the merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. label Jul 9, 2026
@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. mantis: telegram-visible-proof Mantis should capture Telegram visible proof. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Jul 9, 2026
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. and removed rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jul 9, 2026
@sjf-oa

sjf-oa commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jul 9, 2026
@zhangguiping-xydt zhangguiping-xydt mentioned this pull request Jul 9, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinslin kevinslin Awaiting requested review from kevinslin
@steipete steipete Awaiting requested review from steipete
@pash-openai pash-openai Awaiting requested review from pash-openai

Assignees

No one assigned

Labels

extensions: codex maintainer Maintainer-authored PR mantis: telegram-visible-proof Mantis should capture Telegram visible proof. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. size: M status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjf-oa @sjf