refactor(signal): localize internal declarations#102042
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
channel: signal
Member
Author
|
Land-ready proof for
Known proof gaps: none for this declaration-only internal visibility cleanup. |
vincentkoc
marked this pull request as ready for review
July 8, 2026 05:28
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Signal still exported seven declaration-only implementation types that have no consumers outside their defining modules. That unnecessarily widens the plugin's internal TypeScript surface.
Why This Change Was Made
Repository-wide search and the refreshed codebase-memory graph found no external consumers. Signal's public API and runtime barrels export the owning functions and intentional contract types, not these helper declarations, so they can remain module-local without changing runtime behavior or callable shapes.
User Impact
None. This is a dead-export cleanup; Signal runtime behavior and public entrypoints are unchanged.
Evidence
tbx_01kx02pxt11qyq0wh0bfhbh8gbpnpm test:serial extensions/signal: 31 files, 481 tests passedpnpm build: passed, including declaration generation and plugin SDK export checksgit diff --check: passed