Skip to content

refactor(line): localize internal declarations#102037

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v83
Jul 8, 2026
Merged

refactor(line): localize internal declarations#102037
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v83

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Seven LINE implementation details were exported from internal modules even though no repository consumer imports them. This overstates the plugin's supported TypeScript surface.

Why This Change Was Made

Make the declarations file-local while preserving all same-module use:

  • action label limit
  • auto-reply delivery result
  • webhook handler context and replay cache
  • durable reply options
  • monitor options and result

Repository search and the refreshed code graph found only same-file consumers. Supported runtime/API barrels continue to export the actual plugin functions.

User Impact

No runtime behavior changes. The refactor narrows internal module surfaces and improves dead-code/export analysis accuracy.

Evidence

  • Rebased onto current origin/main at 35d5ea069ae90d9377df69dbdb5c636c05f58ecd
  • Testbox tbx_01kx01batv41yaharpb5atem13: changed extension and extension-test gates passed
  • pnpm test:serial extensions/line: 26 files, 306 tests passed
  • pnpm build: passed, including declaration emission and plugin SDK export validation
  • Fresh pre-commit local autoreview: clean, confidence 0.93
  • Fresh post-rebase branch autoreview: clean, confidence 0.89

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: line Channel integration: line size: XS maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready verification:

  • Rebased onto current origin/main at 35d5ea069ae90d9377df69dbdb5c636c05f58ecd.
  • Repository search and refreshed graph inbound checks found only same-file consumers for all seven declarations; supported runtime/API barrels expose the functions, not these internal types/constants.
  • Fresh Testbox tbx_01kx01batv41yaharpb5atem13: changed extension and extension-test gates passed.
  • pnpm test:serial extensions/line: 26 test files, 306 tests passed.
  • pnpm build: passed, including declaration emission, plugin SDK export validation, and Control UI.
  • Fresh local and post-rebase branch autoreviews reported no actionable findings.
  • scripts/pr review-validate-artifacts 102037 and scripts/pr prepare-run 102037 passed.

Known gaps: none for this export-visibility-only refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 05:05
@vincentkoc
vincentkoc merged commit 6319275 into main Jul 8, 2026
109 of 114 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v83 branch July 8, 2026 05:05
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: line Channel integration: line maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant