fix(lobster): treat schema-default flowExpectedRevision=0 as absent for ordinary run/resume by tzy-17 · Pull Request #102023 · openclaw/openclaw

tzy-17 · 2026-07-08T04:37:54Z

What Problem This Solves

Fixes #102011: When the OpenClaw tool schema injects flowExpectedRevision=0 as a default value, the Lobster plugin's parseRunFlowParams and parseResumeFlowParams treated this as an intentional TaskFlow signal, causing ordinary run and resume calls to fail with:

run action does not accept flowId or flowExpectedRevision
flowExpectedRevision required when using managed TaskFlow resume mode

Why This Change Was Made

Only a positive flowExpectedRevision (> 0) signals intentional TaskFlow mode. Schema default 0 means the caller did not supply this field — it should be treated as absent. The fix applies to both parseRunFlowParams and parseResumeFlowParams:

run: Only reject when flowExpectedRevision > 0
resume: Only enter TaskFlow mode when flowExpectedRevision > 0; the validation error is also updated to require a positive value

Evidence

pnpm test extensions/lobster/src/lobster-tool.test.ts — 19 tests pass (incl. 2 new)

🤖 Generated with Claude Code

clawsweeper · 2026-07-08T04:45:23Z

Thanks for the contribution. I reviewed the branch, and this PR is not a good landing base for OpenClaw.

Close: the underlying Lobster and cron bugs are real, but this branch is not a useful landing candidate because it bundles two unrelated fixes, has current-head validation failures, and its Lobster regression tests do not prove the reported runner path.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #102011
Summary: This PR is a low-quality candidate fix for the canonical Lobster schema-default TaskFlow misrouting issue, but it also includes an adjacent-distinct cron fix for a separate message-delivery issue.

Members:

canonical: @openclaw/lobster tool run/resume misroutes schema default flowExpectedRevision into TaskFlow mode #102011 - The PR body uses closing language for the Lobster schema-default ordinary run/resume misrouting report.
fixed_by_candidate: fix(lobster): don't route schema-default flowExpectedRevision into TaskFlow (#102011) #102022 - This open sibling PR targets the same Lobster parser issue with a focused two-file patch, though it still has its own review follow-up.
fixed_by_candidate: fix(lobster): keep ordinary run/resume on default flow fields #102036 - This open sibling PR also targets the same Lobster parser issue and remains an alternate candidate.
adjacent_distinct: [Feature] Skip catchup rerun for cron jobs with lastRunStatus=ok within current schedule window #101988 - The cron commit in this PR targets a separate restart catch-up duplicate-message report, not the Lobster parser root cause.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

So I’m closing this PR rather than keeping an unmergeable branch open. A new narrow PR that carries only the useful part is welcome.

Review details

Best possible solution:

Close this dirty branch, keep the Lobster fix in one focused parser PR, and keep cron restart catch-up repair tied to the separate cron issue or a cron-only PR.

Do we have a high-confidence way to reproduce the issue?

Yes, source-level: current main shows the Lobster parser can route injected flow defaults into managed mode, and the cron report has a clear stale due-slot path. I did not run a live Gateway or installed Lobster scenario during this read-only review.

Is this the best way to solve the issue?

No. The branch is not the best way to solve the issue because it bundles unrelated fixes and its tests/CI do not prove the Lobster behavior; the maintainable path is separate focused fixes with focused proof.

Security review:

Security review cleared: The diff only changes TypeScript parser/scheduler logic and colocated tests; no dependency, lockfile, CI, secret, permission, package, or supply-chain surface changed.

AGENTS.md: found and applied where relevant.

What I checked:

Repository policy read: Root review policy was read fully and applied; it requires whole-surface PR review, plugin-boundary checks, proof scrutiny, and treating config/default/parser behavior as compatibility-sensitive. (AGENTS.md:36, 63192752325b)
Scoped extension policy read: The extension boundary policy was read and applied for the Lobster plugin surface. (extensions/AGENTS.md:1, 63192752325b)
Branch bundles independent issues: The live PR diff contains one cron restart catch-up commit tied to [Feature] Skip catchup rerun for cron jobs with lastRunStatus=ok within current schedule window #101988 and one Lobster parser commit tied to @openclaw/lobster tool run/resume misroutes schema default flowExpectedRevision into TaskFlow mode #102011, while the PR body describes only the Lobster fix. (a8c113c9c648)
Current-head type failure: CI reports src/cron/service.restart-catchup.test.ts(752,7): error TS2353 because the added test passes a nested deps object to createCronServiceState, whose current CronServiceDeps type is flat. (src/cron/service.restart-catchup.test.ts:752, a8c113c9c648)
Current-head lint failure: CI reports the added Lobster test declares run but never uses it, confirming the branch is not clean even before behavioral review. (extensions/lobster/src/lobster-tool.test.ts:373, a8c113c9c648)
Weak Lobster regression assertions: The added Lobster tests only assert that some error is thrown; the run case also uses absolute cwd, so it can pass without proving that schema-default flow fields reach the ordinary runner path. (extensions/lobster/src/lobster-tool.test.ts:372, a8c113c9c648)

Likely related people:

mbelinky: Managed Lobster TaskFlow mode and follow-up hardening changed the parser branch involved in the Lobster part of this PR. (role: introduced behavior and recent area contributor; confidence: high; commits: 30dc24fbd8be, b167df78aa17; files: extensions/lobster/src/lobster-tool.ts, extensions/lobster/src/lobster-tool.test.ts, extensions/lobster/src/lobster-taskflow.ts)
Takhoffman: Authored adjacent cron restart catch-up replay semantics in the same scheduler and restart catch-up test surface. (role: feature-history contributor; confidence: high; commits: 79d00ae39860, d659a8ebb028; files: src/cron/service/timer.ts, src/cron/service.restart-catchup.test.ts, src/cron/service/jobs.ts)
steipete: Recent history shows Lobster managed-flow formatting/handling refactors and adjacent approval resume work near the affected parser surface. (role: adjacent contributor and merger; confidence: medium; commits: 95df6d933282, 3700f3a22cd1, 75fc8b704027; files: extensions/lobster/src/lobster-tool.ts, extensions/lobster/src/lobster-taskflow.ts, extensions/lobster/src/lobster-runner.ts)
Omar Shahine: Current-line blame for the Lobster parser points to a recent file recreation/refactor commit, though the managed TaskFlow behavior predates it. (role: recent area contributor; confidence: low; commits: 91a0ebbce63f; files: extensions/lobster/src/lobster-tool.ts, extensions/lobster/src/lobster-tool.test.ts)

Codex review notes: model internal, reasoning high; reviewed against 63192752325b.

…h status=ok When the Gateway restarts, overdue cron jobs with lastRunStatus=ok and lastRunAtMs >= nextRunAtMs were still considered runnable, causing duplicate notifications to users. Add a check in isRunnableJob: if the job already ran successfully at or after its scheduled time, skip catchup. Fixes openclaw#101988 Co-Authored-By: Claude <[email protected]>

…or ordinary run/resume When the OpenClaw tool schema injects flowExpectedRevision=0 as a default value, ordinary run/resume calls were misrouted into managed TaskFlow mode, causing "does not accept flowId or flowExpectedRevision" errors for valid non-TaskFlow calls. Only treat flowExpectedRevision > 0 as intentional TaskFlow signal; schema default 0 means the caller did not supply this field. Fixes openclaw#102011 Co-Authored-By: Claude <[email protected]>

clawsweeper · 2026-07-08T05:19:44Z

ClawSweeper applied the proposed close for this PR.

Action: closed this PR.
Close reason: low-signal unmergeable PR.
Evidence: durable ClawSweeper review.

openclaw-barnacle Bot added extensions: lobster Extension: lobster size: S labels Jul 8, 2026

clawsweeper Bot mentioned this pull request Jul 8, 2026

fix(lobster): don't route schema-default flowExpectedRevision into TaskFlow (#102011) #102022

Closed

tzy-17 and others added 2 commits July 8, 2026 13:04

tzy-17 force-pushed the fix/102011-lobster-schema-defaults branch from c8cff3b to a8c113c Compare July 8, 2026 05:04

clawsweeper Bot mentioned this pull request Jul 8, 2026

fix(lobster): keep ordinary run/resume on default flow fields #102036

Merged

clawsweeper Bot closed this Jul 8, 2026

tzy-17 deleted the fix/102011-lobster-schema-defaults branch July 8, 2026 05:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(lobster): treat schema-default flowExpectedRevision=0 as absent for ordinary run/resume#102023

fix(lobster): treat schema-default flowExpectedRevision=0 as absent for ordinary run/resume#102023
tzy-17 wants to merge 2 commits into
openclaw:mainfrom
tzy-17:fix/102011-lobster-schema-defaults

tzy-17 commented Jul 8, 2026

Uh oh!

clawsweeper Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

tzy-17 commented Jul 8, 2026

What Problem This Solves

Why This Change Was Made

Evidence

Uh oh!

clawsweeper Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Jul 8, 2026 •

edited

Loading