Skip to content

refactor(plugins): localize internal declarations#102021

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v81
Jul 8, 2026
Merged

refactor(plugins): localize internal declarations#102021
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v81

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Six implementation-only declarations were exported from the Diffs and File Transfer plugins even though no repository consumer imports them. That unnecessarily enlarges the modules' apparent API surface.

Why This Change Was Made

Make the declarations file-local while preserving their existing same-module use:

  • Diffs base language hints and language-pack runtime path
  • File Transfer schemas for file_fetch, dir_list, dir_fetch, and file_write

Repository search and the refreshed code graph found no external consumers.

User Impact

No runtime behavior changes. This narrows internal TypeScript module surfaces and makes future dead-code analysis more accurate.

Evidence

  • Based on current origin/main at 22376d80e1639148d1e0e5ddcadd2c91ba1e5b9e
  • OPENCLAW_TESTBOX=1 pnpm check:changed equivalent on Testbox tbx_01kwzzh8612qsg16sqnb99mzxx
  • pnpm test:serial extensions/diffs extensions/file-transfer: 28 files, 302 tests passed
  • pnpm build: passed, including Diffs asset builds and plugin SDK export validation
  • Fresh local autoreview: clean, confidence 0.88
  • Fresh post-rebase branch autoreview: clean, confidence 0.86

@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready verification:

  • Rebased onto current origin/main at 22376d80e1639148d1e0e5ddcadd2c91ba1e5b9e.
  • Repository search plus refreshed code-graph inbound checks found no external consumers of the six declarations.
  • Testbox tbx_01kwzzh8612qsg16sqnb99mzxx: changed extension and extension-test gates passed.
  • pnpm test:serial extensions/diffs extensions/file-transfer: 28 test files, 302 tests passed.
  • pnpm build: passed, including both Diffs viewer asset builds, plugin SDK export validation, and Control UI.
  • Fresh local and post-rebase branch autoreviews reported no actionable findings.
  • scripts/pr review-validate-artifacts 102021 and scripts/pr prepare-run 102021 passed.

Known gaps: none for this export-visibility-only refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 04:32
@vincentkoc
vincentkoc merged commit bdc1ce8 into main Jul 8, 2026
122 of 126 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v81 branch July 8, 2026 04:33
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant