refactor(qa-lab): localize utility types#101990
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
extensions: qa-lab
size: XS
maintainer
Member
Author
|
Land-ready proof:
Known proof gap: one unrelated current-main QA Lab CLI taxonomy expectation remains red; it is not touched by this type-only refactor. |
vincentkoc
marked this pull request as ready for review
July 8, 2026 03:20
Member
Author
|
Merged via squash.
|
This was referenced Jul 8, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
QA Lab exported four implementation-only type aliases from its child-output and shared-error modules even though they have no repository consumers and are not part of the supported API barrel.
Why This Change Was Made
Keep those utility types private to their owning modules while preserving the exported runtime helpers, error classes, and behavior.
User Impact
None. This is an internal TypeScript API-surface cleanup with no runtime change.
Evidence
pnpm check:changedpassed on Blacksmith Testboxtbx_01kwzvadn6tbw54ze3tyzgyft0.cli.runtime.test.tsCrabline taxonomy expectation failure reproduces on pristine currentorigin/main.pnpm buildpassed on the same Testbox with the patch applied.