Skip to content

refactor(matrix): localize internal types#101954

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v71
Jul 8, 2026
Merged

refactor(matrix): localize internal types#101954
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v71

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Matrix implementation modules exported 20 type aliases that have no consumers outside their defining files and are not part of the plugin's public API, test API, runtime, or contract barrels.

Why This Change Was Made

File-private types should not expand the apparent package surface. Localizing them improves dead-code and API analysis while preserving every runtime definition and call path.

User Impact

No behavior change. Matrix runtime behavior and published API barrels remain unchanged.

Evidence

  • Fresh full codebase-memory MCP graph: 281,353 nodes and 1,134,093 edges.
  • MCP search_graph plus repository-wide import scanning found only defining-module references for the localized types.
  • Audited api.ts, test-api.ts, runtime, setup, contract, doctor, helper, and session-binding barrels; none expose these names.
  • Testbox tbx_01kwzpapz5fn7654z8jrgj3j5f: pnpm check:changed passed.
  • pnpm test:serial extensions/matrix passed: 123 files, 1,428 tests.
  • pnpm build passed, including plugin SDK export guards and the Control UI build.
  • Local autoreview: clean, confidence 0.86.
  • Branch autoreview: clean, confidence 0.89.
  • Diff: 16 files, 20 localized types, net three production lines removed.

@vincentkoc vincentkoc self-assigned this Jul 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: matrix Channel integration: matrix size: XS maintainer Maintainer-authored PR labels Jul 8, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Fresh full codebase-memory MCP graph: 281,353 nodes / 1,134,093 edges; search_graph resolved the audited Matrix definitions.
  • Repository-wide import scan and all Matrix public/test/runtime/contract barrel checks found no consumers or exposure for the 20 localized types.
  • Testbox tbx_01kwzpapz5fn7654z8jrgj3j5f: pnpm check:changed passed.
  • pnpm test:serial extensions/matrix passed: 123 files, 1,428 tests.
  • pnpm build passed, including plugin SDK export guards and the Control UI build.
  • Fresh autoreview passed before commit at 0.86 and on the committed branch at 0.89.
  • Repo review artifacts validate with recommendation READY FOR /prepare-pr; scripts/pr prepare-run 101954 passed.

Known gaps: none for this type-export-only refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 01:54
@vincentkoc
vincentkoc merged commit 4115e83 into main Jul 8, 2026
106 of 108 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v71 branch July 8, 2026 01:54
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 8, 2026
This was referenced Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: matrix Channel integration: matrix maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant