Skip to content

refactor(memory-wiki): localize internal helper types#101931

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v66
Jul 8, 2026
Merged

refactor(memory-wiki): localize internal helper types#101931
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260708-v66

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Memory Wiki still exported eleven constants and helper types that are only referenced inside their defining modules. Those exports enlarge the plugin's apparent internal API and make dead-code discovery noisier.

Why This Change Was Made

Localize the declarations while preserving the exports that are actually consumed across module boundaries. This is a declaration-surface cleanup only; runtime behavior and generated values are unchanged.

User Impact

No user-visible behavior change. The private Memory Wiki plugin exposes a smaller, more accurate module surface.

Evidence

  • Fresh full worktree from origin/main at 1aee742d230e5e50f6f580e19655fa22b21eefee
  • codebase-memory graph refreshed after the latest rebase: 21,043 files, 281,317 nodes, 1,139,618 edges
  • repository-wide reference scan confirms all eleven declarations are used only in their defining modules
  • Testbox tbx_01kwzjjpysmwp90t1wcbzf9256: pnpm check:changed
  • Testbox tbx_01kwzjjpysmwp90t1wcbzf9256: Memory Wiki suite, 33 files / 241 tests passed
  • Testbox tbx_01kwzjjpysmwp90t1wcbzf9256: full pnpm build
  • fresh local autoreview: clean, confidence 0.92
  • fresh branch autoreview: clean, confidence 0.91
  • git diff --check

@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • base: origin/main at 1aee742d230e5e50f6f580e19655fa22b21eefee
  • graph: refreshed, 21,043 files / 281,317 nodes / 1,139,618 edges
  • Testbox: tbx_01kwzjjpysmwp90t1wcbzf9256
  • pnpm check:changed: passed
  • Memory Wiki tests: 33 files / 241 tests passed
  • full pnpm build: passed
  • local autoreview: clean, confidence 0.92
  • branch autoreview: clean, confidence 0.91
  • known proof gaps: none

@vincentkoc
vincentkoc marked this pull request as ready for review July 8, 2026 00:46
@vincentkoc
vincentkoc merged commit 81d0f3f into main Jul 8, 2026
110 of 114 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260708-v66 branch July 8, 2026 00:46
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant