Skip to content

refactor(deadcode): localize browser plugin declarations#101898

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v58
Jul 7, 2026
Merged

refactor(deadcode): localize browser plugin declarations#101898
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v58

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The private browser plugin implementation still exported 15 declarations that have no consumers outside their defining modules. Those exports expanded the apparent internal API without providing a supported package surface.

Why This Change Was Made

Localize the unused declarations at their ownership sites across eight browser implementation modules. The browser plugin's package barrels and runtime API continue to expose the same supported surface.

This is an export-only cleanup: 15 declarations changed from exported to module-local, with 15 insertions and 15 deletions.

User Impact

None expected. Runtime behavior, public browser plugin APIs, and package exports are unchanged.

Evidence

  • Base: 9dbb1ed3d24655a144be1fe58a652f13ebe9f311
  • Head: e260600c10667a9c302dd959b0db0ba69813a4b7
  • Codebase graph after the change: 21,043 files, 281,319 nodes, 1,138,868 edges, zero extraction errors.
  • Repository-wide AST and text searches found no consumers for the 15 removed exports.
  • OPENCLAW_TESTBOX=1 pnpm check:changed: passed for extensions and extensionTests, including extension typechecks, changed-file lint, guards, and import-cycle checks.
  • Targeted browser Testbox lane: 11 files passed, 358 tests passed.
  • Full browser shard on this branch: 5 files and 13 tests failed, with 128 files and 1,522 tests passing and 1 skipped.
  • The identical full browser shard on a clean detached checkout of the current base failed in the same 5 files and 13 tests, including stale SSRF expectations and Response.arrayBuffer mock gaps. These failures are current-main drift and unrelated to this export-only diff.
  • Fresh local autoreview: clean, 0.91 confidence.
  • Fresh committed-branch autoreview: clean, 0.90 confidence.
  • git diff --check: passed.

AI Assistance

AI-assisted code search, editing, review, and validation were used. No agent transcript is attached.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor(deadcode): localize browser plugin declarations This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready verification:

  • Reviewed head: e260600c10667a9c302dd959b0db0ba69813a4b7
  • Base: 9dbb1ed3d24655a144be1fe58a652f13ebe9f311
  • Diff: 15 private browser declarations localized across 8 files; +15/-15; no supported barrel or runtime API changes.
  • Codebase graph: 21,043 files, 281,319 nodes, 1,138,868 edges, zero extraction errors.
  • Testbox tbx_01kwzbk55np98a7b93808r1bwp: OPENCLAW_TESTBOX=1 pnpm check:changed passed for extensions and extensionTests, including typechecks, changed-file lint, guards, and import-cycle checks.
  • Targeted browser Testbox lane: 11 files passed, 358 tests passed.
  • Fresh autoreview: local clean at 0.91 confidence; committed branch clean at 0.90 confidence.
  • scripts/pr review-guard 101898: passed.
  • scripts/pr review-validate-artifacts 101898: passed with zero findings and READY FOR /prepare-pr.
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101898: passed hosted exact/recent-rebase gates.
  • git diff --check: passed.

Known proof gap: the full browser shard has 13 failures in 5 files on both this PR head and a clean detached checkout of the exact current-main base. The same stale SSRF expectations and missing Response.arrayBuffer mocks reproduce identically; 128 files and 1,522 tests pass, with 1 skipped. The touched-surface lane is green, and this export-only diff does not affect those failures.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 22:46
@vincentkoc
vincentkoc merged commit 4969c44 into main Jul 7, 2026
110 of 112 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260707-v58 branch July 7, 2026 22:47
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant