Skip to content

refactor(deadcode): localize control ui declarations#101894

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v57
Jul 7, 2026
Merged

refactor(deadcode): localize control ui declarations#101894
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v57

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The Control UI exposes 31 declarations that have no consumers outside their defining modules. Those unnecessary exports enlarge internal module APIs and make dead-code ownership less precise.

Why This Change Was Made

Localize the 31 same-file-only declarations across 14 Control UI modules. The change removes only export modifiers; names, values, types, and runtime behavior are unchanged.

User Impact

No user-visible or visual behavior changes. Maintainers get narrower Control UI module boundaries with fewer accidental APIs.

Evidence

  • Exact baseline: ba7af36306733978104e28b780b08305b8452fbf.
  • Exact head: 36070eddd2ee4749747c0987491020de0a700da7.
  • Repository-wide AST and exact-symbol scans found all 31 declarations only in their defining files; the post-edit scan reports 31 localized and zero remaining.
  • Refreshed code graph: 21,043 files, 281,314 nodes, 1,138,313 edges, zero extraction errors.
  • pnpm deadcode:unused-files passed on Testbox tbx_01kwzamevnwjqc6kvt0qkt8jdz; all 27 intentional allowlist entries matched.
  • pnpm check:changed passed on the same Testbox.
  • Changed Control UI tests passed: 142 files, 2,320 tests.
  • Fresh local autoreview: no findings, confidence 0.87.
  • Fresh branch autoreview: no findings, confidence 0.90.
  • git diff --check passed.

AI assistance: yes. No agent transcript attached.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor(deadcode): localize control ui declarations This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready for head 36070eddd2ee4749747c0987491020de0a700da7.

  • Repository-wide AST and exact-symbol scans confirmed all 31 declarations were same-file-only across the 14 touched Control UI modules; the post-edit scan reports zero remaining candidates.
  • Refreshed code graph: 21,043 files, 281,314 nodes, 1,138,313 edges, zero extraction errors.
  • pnpm deadcode:unused-files passed on Testbox tbx_01kwzamevnwjqc6kvt0qkt8jdz; all 27 intentional entries matched.
  • pnpm check:changed passed on the same Testbox.
  • Changed Control UI suite passed: 142 files, 2,320 tests.
  • Fresh branch autoreview passed with no findings, confidence 0.90.
  • scripts/pr review-guard, artifact validation, and scripts/pr prepare-run passed against this exact head.

Known proof gaps: none.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 22:33
@vincentkoc
vincentkoc merged commit 9dbb1ed into main Jul 7, 2026
74 of 77 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260707-v57 branch July 7, 2026 22:34
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant