Skip to content

refactor(deadcode): localize test and tooling helpers#101875

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v53
Jul 7, 2026
Merged

refactor(deadcode): localize test and tooling helpers#101875
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v53

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Removes 47 stale named exports from test, tooling, and UI test-helper modules. These helpers are implementation details with local callers, but their exported surface implied unsupported reuse and increased dead-code/search noise.

Why This Change Was Made

The codebase-memory graph was rebuilt from current main, then every candidate was verified to have local callers, no external JavaScript/TypeScript references, no wildcard re-export path, and no package entry-point exposure. Shared Parallels helpers were excluded because their modules are intentionally re-exported through scripts/e2e/parallels/common.ts.

User Impact

No runtime or visual behavior changes. Maintainers get a smaller, more accurate internal API surface across test harnesses, tooling scripts, Vitest configuration, and the Control UI chat-model test helper.

Evidence

  • Fresh full codebase-memory index: 21,039 files, 281,271 nodes, 1,133,750 edges, zero extraction errors.
  • Exact committed-state reference audit: 47 functions across 39 files retain local callers and have zero external code references.
  • Diff: 47 insertions, 54 deletions, net -7 lines.
  • Testbox tbx_01kwz3xgsc463fq3z2k52kgk1a: pnpm check:changed passed.
  • Focused Testbox suite: 17 files, 723 tests passed across unit-fast, tooling, UI, and e2e shards.
  • Fresh local and branch autoreview: no findings, 0.90 confidence each.

AI-assisted: yes. The change and proof were reviewed before submission.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui scripts Repository scripts size: S maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 910c649eecd4b3836156b78c63477d33f3f9c1f5:

  • Rebuilt the full codebase-memory graph from current main: 21,039 files, 281,271 nodes, 1,133,750 edges, zero extraction errors.
  • Verified all 47 localized functions across 39 files retain local callers and have zero external JavaScript/TypeScript references, wildcard re-export paths, or package entry-point exposure.
  • Excluded shared Parallels helpers because their modules remain intentionally re-exported through scripts/e2e/parallels/common.ts.
  • Testbox tbx_01kwz3xgsc463fq3z2k52kgk1a: pnpm check:changed passed.
  • Exact committed-state focused suite: 17 files and 723 tests passed across unit-fast, tooling, UI, and e2e shards.
  • Fresh local and branch autoreview: no findings, 0.90 confidence each.
  • scripts/pr review-validate-artifacts 101875: passed with READY FOR /prepare-pr and zero findings.
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101875: passed; prepared SHA matches the PR head.

Known proof gaps: none for this export-visibility-only refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 20:45
@vincentkoc
vincentkoc requested a review from a team as a code owner July 7, 2026 20:45
@vincentkoc
vincentkoc merged commit d563101 into main Jul 7, 2026
91 of 94 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260707-v53 branch July 7, 2026 20:45
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR scripts Repository scripts size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant