Skip to content

fix(ui): sync native approvals i18n baseline#101771

Merged
steipete merged 1 commit into
mainfrom
codex/fix-control-ui-i18n-baseline
Jul 8, 2026
Merged

fix(ui): sync native approvals i18n baseline#101771
steipete merged 1 commit into
mainfrom
codex/fix-control-ui-i18n-baseline

Conversation

@steipete

@steipete steipete commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Restores the Control UI i18n gate after #101669 added four intentional raw strings to the native exec-approvals view without synchronizing the tracked raw-copy baseline.

Why This Change Was Made

view-exec-approvals.ts already uses the raw-copy baseline for this legacy, untranslated surface. This change runs the repository-owned baseline sync and records only the four new strings; it does not alter runtime behavior or broaden localization scope.

User Impact

No runtime behavior change. CI and release-gate artifact builds can validate the Control UI again.

Evidence

  • node --import tsx scripts/control-ui-i18n.ts check — passed for all 20 locales with zero fallbacks.
  • git diff --check — passed.
  • Reproduced failure: release-gate build-artifacts job 85659750801 reported exactly these four missing baseline entries.

Agent transcript omitted; no transcript publication was approved for this tiny mechanical sync.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 7, 2026, 12:04 PM ET / 16:04 UTC.

Summary
Adds the four native exec-approvals view strings to the Control UI raw-copy i18n baseline.

PR surface: Source +28. Total +28 across 1 file.

Reproducibility: yes. Source inspection shows current main has four literal native approvals UI strings while the raw-copy baseline omits them, and the check code fails when generated findings differ from the baseline.

Review metrics: 1 noteworthy metric.

  • Raw-copy baseline delta: 4 entries added. These generated metadata entries are the exact i18n gate state needed for the four intentional native-policy strings on current main.

Root-cause cluster
Relationship: canonical
Canonical: #101771
Summary: This PR is the narrow follow-up for raw-copy baseline drift caused by the merged native approvals UI strings; no separate open canonical baseline item was found.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • Refresh exact-head CI after rebasing or updating against current main.

Risk before merge

  • [P1] The branch is behind current main, so exact-head CI should refresh before landing even though the current diff still matches main's missing baseline entries.

Maintainer options:

  1. Decide the mitigation before merge
    Land the generated baseline sync after exact-head CI/review, keeping native approvals UI raw copy tracked without broadening localization scope.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • No repair lane: the PR already contains the narrow generated-output fix, leaving normal maintainer review and CI refresh as the remaining path.

Security
Cleared: Only generated i18n baseline JSON changes; no dependency, execution, credential, or runtime security surface changed.

Review details

Best possible solution:

Land the generated baseline sync after exact-head CI/review, keeping native approvals UI raw copy tracked without broadening localization scope.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main has four literal native approvals UI strings while the raw-copy baseline omits them, and the check code fails when generated findings differ from the baseline.

Is this the best way to solve the issue?

Yes. For this legacy untranslated surface, adding the generated raw-copy entries is the narrowest maintainable fix; moving these labels into full localization would be broader than the reported gate repair.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 70de9ff20b3c.

Label changes

Label changes:

  • add P2: This is a bounded Control UI i18n gate repair that can affect release validation but does not change runtime behavior.
  • add proof: sufficient: Contributor real behavior proof is sufficient. The PR body reports the after-fix i18n check passing and ties the before-state failure to the release-gate job that found these four missing entries.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): The PR body reports the after-fix i18n check passing and ties the before-state failure to the release-gate job that found these four missing entries.

Label justifications:

  • P2: This is a bounded Control UI i18n gate repair that can affect release validation but does not change runtime behavior.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): The PR body reports the after-fix i18n check passing and ties the before-state failure to the release-gate job that found these four missing entries.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR body reports the after-fix i18n check passing and ties the before-state failure to the release-gate job that found these four missing entries.
Evidence reviewed

PR surface:

Source +28. Total +28 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 1 28 0 +28
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 1 28 0 +28

What I checked:

  • Scoped i18n policy allows this targeted generated-output fix: The UI guide says .i18n metadata should not be hand-edited unless a targeted generated-output fix is explicitly requested, and this PR is exactly a generated raw-copy baseline sync. (ui/AGENTS.md:8, 70de9ff20b3c)
  • Current main contains the native approvals raw strings: The native exec approvals renderer includes Host-native policy, Read-only here. Edit from the companion app or CLI., Native, and Default action as literal UI text. (ui/src/pages/nodes/view-exec-approvals.ts:251, 70de9ff20b3c)
  • Current baseline is missing the new native strings: The current baseline jumps from Case-insensitive glob patterns. to Defaults, from Host to Load exec approvals..., and from Pattern to Remove, so the four new native strings are not tracked on main. (ui/src/i18n/.i18n/raw-copy-baseline.json:3921, 70de9ff20b3c)
  • The i18n check fails on baseline drift: syncControlUiRawCopyBaseline compares generated findings to the raw-copy baseline and throws control-ui raw-copy baseline drift detected in check mode when the files differ. (scripts/control-ui-i18n.ts:906, 70de9ff20b3c)
  • PR diff adds exactly the four missing entries: The PR patch adds Default action, Host-native policy, Native, and Read-only here. Edit from the companion app or CLI. as html-text baseline entries for the native approvals view. (ui/src/i18n/.i18n/raw-copy-baseline.json:3921, baef858fd97d)
  • Merged related PR introduced the raw strings: Git blame ties the native approvals UI strings to the merged native Windows exec approvals work, so this PR is a direct baseline follow-up rather than unrelated generated churn. (ui/src/pages/nodes/view-exec-approvals.ts:251, a7faec8ca1d0)

Likely related people:

  • steipete: Peter Steinberger introduced the raw-copy i18n script and baseline in the current shallow history and also authored the merged native approvals UI strings that this PR tracks. (role: introduced behavior and recent area contributor; confidence: high; commits: 16348ddec3ad, a7faec8ca1d0; files: scripts/control-ui-i18n.ts, ui/src/i18n/.i18n/raw-copy-baseline.json, ui/src/pages/nodes/view-exec-approvals.ts)
  • vincentkoc: Vincent Koc is co-author on the merged native Windows exec approvals work that added the UI surface whose raw strings now need baseline tracking. (role: adjacent owner; confidence: medium; commits: a7faec8ca1d0; files: ui/src/pages/nodes/view-exec-approvals.ts, ui/src/lib/nodes/index.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 7, 2026
@steipete
steipete merged commit 8cbcc41 into main Jul 8, 2026
244 of 253 checks passed
@steipete
steipete deleted the codex/fix-control-ui-i18n-baseline branch July 8, 2026 05:48
@steipete

steipete commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant