fix(ui): sync native approvals i18n baseline#101771
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 7, 2026, 12:04 PM ET / 16:04 UTC. Summary PR surface: Source +28. Total +28 across 1 file. Reproducibility: yes. Source inspection shows current main has four literal native approvals UI strings while the raw-copy baseline omits them, and the check code fails when generated findings differ from the baseline. Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the generated baseline sync after exact-head CI/review, keeping native approvals UI raw copy tracked without broadening localization scope. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main has four literal native approvals UI strings while the raw-copy baseline omits them, and the check code fails when generated findings differ from the baseline. Is this the best way to solve the issue? Yes. For this legacy untranslated surface, adding the generated raw-copy entries is the narrowest maintainable fix; moving these labels into full localization would be broader than the reported gate repair. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 70de9ff20b3c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +28. Total +28 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
What Problem This Solves
Restores the Control UI i18n gate after #101669 added four intentional raw strings to the native exec-approvals view without synchronizing the tracked raw-copy baseline.
Why This Change Was Made
view-exec-approvals.tsalready uses the raw-copy baseline for this legacy, untranslated surface. This change runs the repository-owned baseline sync and records only the four new strings; it does not alter runtime behavior or broaden localization scope.User Impact
No runtime behavior change. CI and release-gate artifact builds can validate the Control UI again.
Evidence
node --import tsx scripts/control-ui-i18n.ts check— passed for all 20 locales with zero fallbacks.git diff --check— passed.Agent transcript omitted; no transcript publication was approved for this tiny mechanical sync.