refactor: localize internal implementation types#101731
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
channel: discord
Member
Author
|
Land-ready proof for
Known proof gaps: none. |
vincentkoc
marked this pull request as ready for review
July 7, 2026 14:40
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Internal implementation types were still exported from 38 core and bundled-plugin modules even though no other tracked module imported them. Those exports inflate the apparent API surface and keep dead-code reports noisy.
Why This Change Was Made
Localize 44 file-private type aliases while preserving the five exported compile-time assertion aliases that TypeScript needs to avoid
noUnusedLocalsfailures. No runtime logic or public plugin SDK surface changes.User Impact
No behavior change. The codebase exposes a smaller internal type surface and the unused-export report has fewer false-positive candidates.
Evidence
OPENCLAW_TESTBOX=1 pnpm check:changedon Blacksmith Testboxtbx_01kwydzg4pg2pajcvkbvv9tzc5pnpm test:serialacross 12 explicit core/plugin test files: 481 tests passed in 10 Vitest shardsnode scripts/check-duplicates.mjs: zero clones across production, extension, and test lanespnpm deadcode:report:ci:ts-unused: 3,598 -> 3,589 modules with unused exports; all 44 selected symbols removed from their originating module entriesgit diff --check