fix: preserve emoji at remaining bounded-text edges by steipete · Pull Request #101711 · openclaw/openclaw

steipete · 2026-07-07T14:13:06Z

What Problem This Solves

Fixes an issue where emoji and other supplementary Unicode characters could become malformed when text landed exactly on remaining length limits in Parallel search requests, compaction summaries, telemetry logs, system presence, workboard context and badges, or Control UI command metadata.

Why This Change Was Made

Routes each real text boundary through the shared UTF-16-safe slicing helpers at its owning core, UI, or plugin layer. This clean replacement also protects the compaction suffix-tail boundary missed by the source proposals, while omitting duplicate fixes already on main and unrelated formatting churn.

User Impact

Bounded text keeps valid Unicode at these edges: a complete character is retained or omitted, never split into a dangling surrogate. Existing length caps, markers, and fallback behavior remain unchanged.

Evidence

Blacksmith Testbox tbx_01kwyae3xcaszr9ckk2z1bg0ew: 407 focused behavior tests plus the 2-test Control UI browser-import contract passed.
Full check:changed passed, including guards, four typecheck lanes, and core/UI/package/extension lint.
Live keyless Parallel Search MCP request with Unicode input returned one result, a search id, and the expected normalized query.
Focused regression coverage asserts exact outputs at prefix, suffix-tail, marker, telemetry, presence-key, worker-context, badge, and remote-command boundaries.
git diff --check passed.
Fresh exact-branch Codex autoreview: clean at 0.98 confidence; no accepted/actionable findings.

Co-authored-by: ben.li <[email protected]> Co-authored-by: 0668001336 <[email protected]> Co-authored-by: Alix-007 <[email protected]>

clawsweeper · 2026-07-07T14:16:34Z

Codex review: needs maintainer review before merge. Reviewed July 7, 2026, 10:46 AM ET / 14:46 UTC.

Summary
The branch replaces raw UTF-16 slicing at remaining bounded-text edges with shared surrogate-safe helpers and adds regression tests for the affected plugin, agent, infra, and Control UI paths.

PR surface: Source +12, Tests +134. Total +146 across 15 files.

Reproducibility: yes. source-reproducible. Current main uses raw String.slice at the affected bounded text caps, so a non-BMP character crossing the cap can leave a lone surrogate; the PR adds focused boundary tests for the changed paths.

Review metrics: none identified.

Stored data model
Persistent data-model change detected: vector/embedding metadata: extensions/workboard/src/store.test.ts, vector/embedding metadata: ui/src/pages/workboard/view.test.ts. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: canonical
Canonical: #101711
Summary: This PR is the consolidated bounded-text UTF-16 fix for the related same-day Parallel, workboard/UI/OTel, and compaction proposals.

Members:

partial_overlap: fix(parallel): keep normalized search fields UTF-16 safe #101679 - It covers the Parallel normalizer subset that this PR also changes, but remains a narrower open PR needing proof.
partial_overlap: fix: use truncateUtf16Safe to avoid splitting UTF-16 surrogate pairs #101684 - It covers several workboard, OTel, presence, and UI slice sites that this PR consolidates with tests and current-main cleanup.
superseded: fix(agents): keep compaction safeguard summary truncation UTF-16 safe #101692 - It was closed after discussion as superseded by this PR because it missed the compaction suffix-tail UTF-16 edge.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge

No repair lane is needed because no actionable patch defect was found; this maintainer-labeled PR should stay open for normal maintainer review and landing gates.

Security
Cleared: The diff only imports existing text helpers and adds regression tests; it does not change dependencies, workflows, secrets, permissions, or package/install surfaces.

Review details

Best possible solution:

Land the consolidated UTF-16 bounded-text fix after maintainer review and exact-head gates, preserving the existing limits and avoiding any new config or API surface.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible. Current main uses raw String.slice at the affected bounded text caps, so a non-BMP character crossing the cap can leave a lone surrogate; the PR adds focused boundary tests for the changed paths.

Is this the best way to solve the issue?

Yes. Reusing truncateUtf16Safe and sliceUtf16Safe at each owning boundary is the narrow maintainable fix; adding a new helper, config option, or transport-specific workaround would duplicate an existing shared contract.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against fdc7892a6e5a.

Label changes

Label changes:

add proof: sufficient: Contributor real behavior proof is sufficient. The PR body reports focused Blacksmith Testbox validation plus a live keyless Parallel Search MCP request with Unicode input after the fix, which is sufficient real behavior proof for this maintainer-labeled bugfix.
add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.

Label justifications:

P2: This is a normal-priority text correctness fix with limited blast radius across bounded display, request, telemetry, and context strings.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body reports focused Blacksmith Testbox validation plus a live keyless Parallel Search MCP request with Unicode input after the fix, which is sufficient real behavior proof for this maintainer-labeled bugfix.

Evidence reviewed

PR surface:

Source +12, Tests +134. Total +146 across 15 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	7	27	15	+12
Tests	8	143	9	+134
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	15	170	24	+146

What I checked:

Repository policy read: Root AGENTS.md and scoped guides for extensions, src/agents, and ui were read fully; extension policy allows plugin production imports through openclaw/plugin-sdk/*, and UI/agent guidance drove the broader caller/test review. (AGENTS.md:1, fdc7892a6e5a)
Current-main problem still exists: Current main still uses raw String.slice at representative bounded-text paths such as Parallel objective truncation, so a supplementary character crossing the cap can leave a dangling surrogate before this PR. (extensions/parallel/src/parallel-search-normalize.ts:61, fdc7892a6e5a)
PR head uses the shared helper at owner boundaries: At PR head, Parallel objective, client model, and search query caps use truncateUtf16Safe while keeping the existing field limits and request shape. (extensions/parallel/src/parallel-search-normalize.ts:60, d79d01eb2178)
Compaction tail edge covered: The PR changes both prefix truncation and the oversized preserved-suffix tail branch, using sliceUtf16Safe for the negative-start suffix path that the narrower related compaction PR missed. (src/agents/agent-hooks/compaction-safeguard.ts:589, d79d01eb2178)
Helper contract supports the change: sliceUtf16Safe adjusts both slice edges away from surrogate halves, and truncateUtf16Safe delegates to it after flooring and bounding the limit. (packages/normalization-core/src/utf16-slice.ts:16, fdc7892a6e5a)
Focused regression coverage: The PR adds exact-boundary tests for Parallel fields, compaction prefix/tail/failure text, worker context, presence keys, command metadata, diagnostics OTel logs, and workboard badges. (src/agents/agent-hooks/compaction-safeguard.test.ts:395, d79d01eb2178)

Likely related people:

steipete: Blame on the current raw-slice blocks points to Peter Steinberger's recent main snapshot, and this PR consolidates related contributor proposals under his branch. (role: recent consolidation owner and current implementation contributor; confidence: high; commits: cba20f9aec7b, fc230db29512, d79d01eb2178; files: extensions/parallel/src/parallel-search-normalize.ts, src/agents/agent-hooks/compaction-safeguard.ts, extensions/workboard/src/store.ts)
Pandadadadazxf: Git history shows commit 9d15f5d added the compaction safeguard summary size behavior that the preserved-suffix truncation path descends from. (role: introduced earlier compaction budget behavior; confidence: medium; commits: 9d15f5dd746a; files: src/agents/pi-extensions/compaction-safeguard.ts, src/agents/pi-extensions/compaction-safeguard.test.ts)
nxmxbbd: Recent merged history touched the same compaction-safeguard module for tool-failure summary behavior, making this person relevant for compaction-path review context. (role: recent adjacent compaction contributor; confidence: medium; commits: 079397b2c385; files: src/agents/agent-hooks/compaction-safeguard.ts, src/agents/agent-hooks/compaction-safeguard.test.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Review history (1 earlier review cycle)

reviewed 2026-07-07T14:20:50.006Z sha 20a2c38 :: found issues before merge. :: [P3] Remove the release-owned changelog entry

steipete · 2026-07-07T14:47:47Z

Land-ready proof for exact head d79d01eb2178ebcf3278d4a12cdfcc770642a23b:

GitHub CI run 28874551796: success, including build, guards, four typecheck/check lanes, lint, package/extension boundaries, all Node shards, and Telegram/matrix smoke.
Blacksmith Testbox tbx_01kwyae3xcaszr9ckk2z1bg0ew: 407 focused behavior tests passed across Parallel, diagnostics, workboard, agents, infra, and Control UI.
Blacksmith Testbox: the 2-test Control UI browser-import contract passed after its import allowlist was updated for the new browser-safe helper.
Blacksmith Testbox: full check:changed passed, including guards, four typecheck lanes, and core/UI/package/extension lint.
Live keyless Parallel Search MCP request with Unicode input returned one result, a search id, and the expected normalized query.
Fresh exact-head Codex autoreview: clean at 0.98 confidence; no accepted/actionable findings.
git diff --check: pass.

Known proof gap: the paid Parallel REST endpoint was not invoked. Its transport is unchanged, both Parallel runtimes share the tested normalization path, and the free MCP path was exercised live.

Native review artifacts validate with zero findings and READY FOR /prepare-pr.

steipete · 2026-07-07T14:48:27Z

Merged via squash.

Prepared head SHA: d79d01eb2178ebcf3278d4a12cdfcc770642a23b
Landed commit: 87fe266c5e4d790e8f15278ecc417d3a4d418b91

* fix: keep remaining text bounds UTF-16 safe Co-authored-by: ben.li <[email protected]> Co-authored-by: 0668001336 <[email protected]> Co-authored-by: Alix-007 <[email protected]> * docs: credit bounded Unicode fixes * test: update UTF-16 browser import boundary * chore: leave Unicode note to release changelog --------- Co-authored-by: ben.li <[email protected]> Co-authored-by: 0668001336 <[email protected]> Co-authored-by: Alix-007 <[email protected]>

fix: keep remaining text bounds UTF-16 safe

fc230db

Co-authored-by: ben.li <[email protected]> Co-authored-by: 0668001336 <[email protected]> Co-authored-by: Alix-007 <[email protected]>

openclaw-barnacle Bot added app: web-ui App: web-ui extensions: diagnostics-otel Extension: diagnostics-otel agents Agent runtime and tooling plugin: workboard extensions: parallel labels Jul 7, 2026

docs: credit bounded Unicode fixes

20a2c38

openclaw-barnacle Bot added size: S maintainer Maintainer-authored PR labels Jul 7, 2026

test: update UTF-16 browser import boundary

0ff5b2d

clawsweeper Bot mentioned this pull request Jul 7, 2026

fix(agents): keep compaction safeguard summary truncation UTF-16 safe #101692

Closed

chore: leave Unicode note to release changelog

d79d01e

steipete merged commit 87fe266 into main Jul 7, 2026
113 of 115 checks passed

steipete deleted the codex/utf16-final-boundaries branch July 7, 2026 14:48

This was referenced Jul 7, 2026

fix(parallel): keep normalized search fields UTF-16 safe #101679

Closed

fix: use truncateUtf16Safe to avoid splitting UTF-16 surrogate pairs #101684

Closed

wings1029 mentioned this pull request Jul 7, 2026

fix: keep emoji intact at remaining text truncation boundaries #101754

Merged

github-actions Bot mentioned this pull request Jul 7, 2026

📡 Upstream Digest — 2026-07-07 17:52 UTC curtismercier/openclaw-mods#1231

Open

This was referenced Jul 9, 2026

fix(ui): keep clampText/truncateText surrogate-safe at emoji boundaries #102225

Merged

fix(parallel-mcp): use truncateUtf16Safe for error message truncation #102615

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: preserve emoji at remaining bounded-text edges#101711

fix: preserve emoji at remaining bounded-text edges#101711
steipete merged 4 commits into
mainfrom
codex/utf16-final-boundaries

steipete commented Jul 7, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

steipete commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

steipete commented Jul 7, 2026 •

edited

Loading

clawsweeper Bot commented Jul 7, 2026 •

edited

Loading