refactor: remove obsolete chat display mocks#101682
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
app: web-ui
shakkernerd
force-pushed
the
refactor/chat-display-test-mocks
branch
from
July 7, 2026 13:12
503483f to
4fa3ee4
Compare
This was referenced Jul 7, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
Related: openclaw#101647 ## What Problem This Solves Removes stale Control UI test mocks that modeled helper exports no longer exposed by the chat display module. ## Why This Change Was Made The chat message tests no longer reach the display module, so their mock was removed. The chat view tests retain only the fallback asset mock and exercise the canonical avatar helpers directly. ## User Impact No user-visible behavior change. Tests now reflect the current module ownership without duplicating avatar logic. ## Evidence - Focused Testbox run: 2 files, 209 tests passed. - Testbox: `tbx_01kwyatxdvb64ncvbn9ertg6fa` - Actions run: https://github.com/openclaw/openclaw/actions/runs/28868305075 - `git diff --check`: passed. - Codex autoreview: no actionable findings.
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
Related: openclaw#101647 ## What Problem This Solves Removes stale Control UI test mocks that modeled helper exports no longer exposed by the chat display module. ## Why This Change Was Made The chat message tests no longer reach the display module, so their mock was removed. The chat view tests retain only the fallback asset mock and exercise the canonical avatar helpers directly. ## User Impact No user-visible behavior change. Tests now reflect the current module ownership without duplicating avatar logic. ## Evidence - Focused Testbox run: 2 files, 209 tests passed. - Testbox: `tbx_01kwyatxdvb64ncvbn9ertg6fa` - Actions run: https://github.com/openclaw/openclaw/actions/runs/28868305075 - `git diff --check`: passed. - Codex autoreview: no actionable findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #101647
What Problem This Solves
Removes stale Control UI test mocks that modeled helper exports no longer exposed by the chat display module.
Why This Change Was Made
The chat message tests no longer reach the display module, so their mock was removed. The chat view tests retain only the fallback asset mock and exercise the canonical avatar helpers directly.
User Impact
No user-visible behavior change. Tests now reflect the current module ownership without duplicating avatar logic.
Evidence
tbx_01kwyatxdvb64ncvbn9ertg6fagit diff --check: passed.