Skip to content

refactor(android): remove superseded app surfaces#101680

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-mobile-apps-20260707-v45
Jul 7, 2026
Merged

refactor(android): remove superseded app surfaces#101680
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-mobile-apps-20260707-v45

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The canonical Android shell introduced by bbcac0019b1 left four superseded app surfaces, two unused typography tokens, and their resource/inventory entries behind. They had no remaining callers but continued to inflate the mobile code and translation surface.

Why This Change Was Made

  • delete the unreachable legacy chat, connection, voice, and gateway-event surfaces
  • remove the two typography tokens used only by those deleted screens
  • prune the 28 now-unused Android string keys from every locale
  • regenerate the native app i18n inventory

The current shell continues to route chat through ui.chat.ChatScreen, voice through VoiceScreen, and gateway setup through the canonical onboarding/settings surfaces.

User Impact

No behavior change. This removes 2,587 net lines of unreachable Android code and stale localization inventory.

Evidence

  • node --import tsx scripts/native-app-i18n.ts check
  • node --import tsx scripts/android-app-i18n.ts check
  • Testbox tbx_01kwyags5nc0013n70ge972tdv: both Android flavor unit tests, both debug lint variants, app and benchmark ktlint (102 tasks, green)
  • Testbox tbx_01kwyags5nc0013n70ge972tdv: pnpm check:changed (apps lane, green)
  • three clean autoreviews (0.89, 0.82, 0.86 confidence)
  • codebase-memory graph refreshed: 279,032 nodes / 1,136,003 edges; removed symbols return zero results

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: XL maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for db21b07fb6994136046f2901fafc7ae182a65a27:

  • node --import tsx scripts/native-app-i18n.ts check - pass (entries=2809, no drift)
  • node --import tsx scripts/android-app-i18n.ts check - pass (keys=7, all 21 translated locales aligned)
  • Testbox tbx_01kwyags5nc0013n70ge972tdv:
    • ./gradlew --no-daemon --build-cache :app:testPlayDebugUnitTest :app:testThirdPartyDebugUnitTest :app:lintPlayDebug :app:lintThirdPartyDebug :app:ktlintCheck :benchmark:ktlintCheck
    • pass, 102 tasks, 3m31s
  • Testbox tbx_01kwyags5nc0013n70ge972tdv:
    • OPENCLAW_CHECK_CHANGED_REMOTE_CHILD=1 OPENCLAW_CHANGED_LANES_RAW_SYNC=1 corepack pnpm check:changed
    • pass, apps lane
  • Hosted exact-head prepare gates: pass
  • Three clean autoreviews: 0.89, 0.82, 0.86 confidence
  • Codebase-memory graph refreshed: 279,032 nodes / 1,136,003 edges; removed symbols return zero results

Known proof gap: SwiftLint was not applicable to this Android-only diff and was skipped on the Linux Testbox. No Android proof gaps remain.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 13:07
@vincentkoc
vincentkoc merged commit cd86107 into main Jul 7, 2026
76 of 82 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-mobile-apps-20260707-v45 branch July 7, 2026 13:07
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant