Skip to content

refactor(ui): trim unused control UI helpers#101632

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v42
Jul 7, 2026
Merged

refactor(ui): trim unused control UI helpers#101632
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-all-surfaces-20260707-v42

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The Control UI retained unused exports and tests around its native bridge and local user identity settings, while session drag MIME ownership was duplicated across modules.

Why This Change Was Made

  • remove unused native bridge and identity exports
  • keep the WebView2 ready handshake behind a private typed helper
  • preserve loading of existing stored user identities without retaining an uncalled writer
  • use the shared session drag MIME constant in the sessions view

User Impact

No intended behavior change. The UI has fewer public/internal surfaces and one canonical drag MIME definition.

Evidence

  • OPENCLAW_TESTBOX=1: pnpm check:changed -- <6 touched UI files> passed on Testbox tbx_01kwy5r4ekxxg6t953fg7y3p2w
  • OPENCLAW_TESTBOX=1: 4 targeted UI suites, 73 tests passed
  • deadcode:ts-unused: 3,637 -> 3,624 report lines; no remaining findings for touched files
  • codebase-memory MCP graph refreshed: 281,048 nodes / 1,139,480 edges
  • mandatory local and branch autoreview: clean, no actionable findings

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • scoped pnpm check:changed passed on Testbox tbx_01kwy5r4ekxxg6t953fg7y3p2w
  • 4 targeted Control UI suites passed: 73/73 tests
  • deadcode:ts-unused report reduced from 3,637 to 3,624 lines, with no remaining findings in touched files
  • codebase-memory MCP graph refreshed to 281,048 nodes / 1,139,480 edges
  • local and branch mandatory autoreviews both returned no actionable findings
  • scripts/pr review-guard, review artifact validation, and scripts/pr prepare-run passed for head 4e10bf082dc8c5b6fc11e3258e27ea797f1054a3

Known gaps: none for this behavior-preserving UI cleanup.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 11:55
@vincentkoc
vincentkoc merged commit 2ba622c into main Jul 7, 2026
70 of 74 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-all-surfaces-20260707-v42 branch July 7, 2026 11:55
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant