fix(codex): use truncateUtf16Safe for attempt notification text truncation#101534
Merged
steipete merged 3 commits intoJul 7, 2026
Conversation
…ation .slice(0, 237) on notification text can split surrogate pairs from CJK characters or emoji in agent output, producing U+FFFD in Codex desktop notifications. Co-Authored-By: Claude <[email protected]>
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step Review history (1 earlier review cycle)
|
clawsweeper
Bot
added
rating: 🧂 unranked krab
clawsweeper
Bot
removed
rating: 🧂 unranked krab
Contributor
|
Land-ready at exact reviewed head
Direct dependency-contract inspection used Codex No docs or changelog change is required for this internal diagnostic-boundary correction. |
Contributor
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
…ation (openclaw#101534) * fix(codex): use truncateUtf16Safe for attempt notification text truncation .slice(0, 237) on notification text can split surrogate pairs from CJK characters or emoji in agent output, producing U+FFFD in Codex desktop notifications. Co-Authored-By: Claude <[email protected]> * test(codex): cover UTF-16-safe attempt previews * test(codex): assign notification coverage to a shard --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Peter Steinberger <[email protected]>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
…ation (openclaw#101534) * fix(codex): use truncateUtf16Safe for attempt notification text truncation .slice(0, 237) on notification text can split surrogate pairs from CJK characters or emoji in agent output, producing U+FFFD in Codex desktop notifications. Co-Authored-By: Claude <[email protected]> * test(codex): cover UTF-16-safe attempt previews * test(codex): assign notification coverage to a shard --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Peter Steinberger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Codex attempt notifications truncate agent output with
.slice(0, 237). When the slice boundary lands mid-surrogate-pair (common with CJK characters or emoji in agent output), the U+FFFD replacement character appears in desktop notification text.Why This Change Was Made
Replace
.slice(0, 237)withtruncateUtf16Safe().Evidence
Part of the UTF-16 safety sweep following Alix-007 (#101311), wangmiao (#101421), and ly85206559 (#101029).
Issue
N/A
🤖 Generated with Claude Code