Skip to content

refactor(android): remove obsolete global cache cleanup#101470

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-native-sweep-20260707-v33
Jul 7, 2026
Merged

refactor(android): remove obsolete global cache cleanup#101470
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-native-sweep-20260707-v33

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Jul 7, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Android still exposed global transcript-cache and command-outbox purge paths after authentication cleanup moved to gateway-scoped deletion. Those unused APIs, DAO queries, preference helpers, and tests described a second cleanup model that production no longer called.

Why This Change Was Made

Remove the obsolete global cleanup surface and retain the canonical per-gateway clearGatewayCache path used by reset and forget flows. This is a deletion-only cleanup with no runtime behavior change.

User Impact

No user-visible behavior changes. Android cache ownership now has one smaller, gateway-scoped cleanup path instead of retaining unused global purge machinery.

Evidence

  • :app:ktlintCheck passed on Blacksmith Testbox tbx_01kwxrqn7ztayqr7v8c0wedhkc.
  • Targeted :app:testThirdPartyDebugUnitTest passed for SecurePrefsTest, GatewayBootstrapAuthTest, both controller cache/outbox tests, and both Room cache/outbox tests.
  • :app:lintPlayDebug :app:lintThirdPartyDebug passed, 60 tasks.
  • pnpm check:changed passed on the Android-only branch; the final exact-head gate runs through the repository prepare-run Testbox flow.
  • Codebase Memory MCP full graph refreshed after the final rebase: 278,239 nodes / 1,115,187 edges. Removed symbols return zero graph results; gateway-scoped cleanup remains indexed.
  • Fresh Codex autoreview passed before commit and again on the committed branch with no accepted/actionable findings.
  • git diff --check passed.

AI-assisted: yes. The implementation was inspected and validated by the author.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head 51804ff3f3bba4188f1363875f342bc638fceadf, but the PR head is now 3a09b071f64b1a4deb3f4a42eb5516a999a7a8ce. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

@vincentkoc
vincentkoc force-pushed the refactor/deadcode-native-sweep-20260707-v33 branch from 51804ff to 3a09b07 Compare July 7, 2026 08:09
@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: S maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 3a09b071f64b1a4deb3f4a42eb5516a999a7a8ce:

  • Android :app:ktlintCheck passed.
  • Targeted third-party debug unit tests passed for SecurePrefs, gateway bootstrap auth, controller cache/outbox, and Room cache/outbox coverage.
  • Android :app:lintPlayDebug :app:lintThirdPartyDebug passed, 60 tasks.
  • iOS Periphery passed on the latest app-changing main SHA: https://github.com/openclaw/openclaw/actions/runs/28850588306
  • Codebase Memory MCP refreshed after the final rebase: 278,239 nodes / 1,115,187 edges; removed symbols return zero results and gateway-scoped cleanup remains indexed.
  • Fresh Codex autoreview passed before commit, after commit, and after the final rebase with no accepted/actionable findings.
  • git diff --check passed.
  • OPENCLAW_TESTBOX=1 scripts/pr prepare-run 101470 passed the hosted exact-head/recent-rebase gate and verified the remote PR head.

Current main changes after the PR base do not touch Android, iOS, or shared app code.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 08:18
@vincentkoc
vincentkoc merged commit 6799b5b into main Jul 7, 2026
105 of 110 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-native-sweep-20260707-v33 branch July 7, 2026 08:19
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant