refactor(android): remove obsolete global cache cleanup#101470
Merged
Conversation
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step |
vincentkoc
force-pushed
the
refactor/deadcode-native-sweep-20260707-v33
branch
from
July 7, 2026 08:09
51804ff to
3a09b07
Compare
Member
Author
|
Land-ready proof for
Current |
vincentkoc
marked this pull request as ready for review
July 7, 2026 08:18
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 8, 2026
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Android still exposed global transcript-cache and command-outbox purge paths after authentication cleanup moved to gateway-scoped deletion. Those unused APIs, DAO queries, preference helpers, and tests described a second cleanup model that production no longer called.
Why This Change Was Made
Remove the obsolete global cleanup surface and retain the canonical per-gateway
clearGatewayCachepath used by reset and forget flows. This is a deletion-only cleanup with no runtime behavior change.User Impact
No user-visible behavior changes. Android cache ownership now has one smaller, gateway-scoped cleanup path instead of retaining unused global purge machinery.
Evidence
:app:ktlintCheckpassed on Blacksmith Testboxtbx_01kwxrqn7ztayqr7v8c0wedhkc.:app:testThirdPartyDebugUnitTestpassed forSecurePrefsTest,GatewayBootstrapAuthTest, both controller cache/outbox tests, and both Room cache/outbox tests.:app:lintPlayDebug :app:lintThirdPartyDebugpassed, 60 tasks.pnpm check:changedpassed on the Android-only branch; the final exact-head gate runs through the repositoryprepare-runTestbox flow.git diff --checkpassed.AI-assisted: yes. The implementation was inspected and validated by the author.