fix(voice-call): handle tunnel child stream errors and stop-after-exit hang#101394
Merged
steipete merged 3 commits intoJul 7, 2026
Merged
Conversation
openclaw-barnacle
Bot
added
channel: voice-call
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step Review history (1 earlier review cycle)
|
clawsweeper
Bot
added
rating: 🦪 silver shellfish
clawsweeper
Bot
removed
rating: 🦪 silver shellfish
Contributor
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
…t hang (openclaw#101394) * fix(voice-call): handle tunnel child stream errors and stop-after-exit hang * fix(voice-call): stop children after stream failures * style(voice-call): satisfy timer lint --------- Co-authored-by: Peter Steinberger <[email protected]>
sheyanmin
pushed a commit
to sheyanmin/openclaw
that referenced
this pull request
Jul 8, 2026
…t hang (openclaw#101394) * fix(voice-call): handle tunnel child stream errors and stop-after-exit hang * fix(voice-call): stop children after stream failures * style(voice-call): satisfy timer lint --------- Co-authored-by: Peter Steinberger <[email protected]>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
…t hang (openclaw#101394) * fix(voice-call): handle tunnel child stream errors and stop-after-exit hang * fix(voice-call): stop children after stream failures * style(voice-call): satisfy timer lint --------- Co-authored-by: Peter Steinberger <[email protected]>
wheakerd
pushed a commit
to wheakerd/clawdbot
that referenced
this pull request
Jul 15, 2026
…t hang (openclaw#101394) * fix(voice-call): handle tunnel child stream errors and stop-after-exit hang * fix(voice-call): stop children after stream failures * style(voice-call): satisfy timer lint --------- Co-authored-by: Peter Steinberger <[email protected]> (cherry picked from commit 735b7b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
startNgrokTunnelandstartTailscaleTunnelattacheddatalisteners to their childstdout/stderrpipes but noerrorlisteners. A broken pipe (EPIPE) or I/O error (EIO) on either stream therefore became an unhandlederrorevent that could crash the gateway process.Additionally, the ngrok
stop()closure always waited up to 2 seconds for acloseevent even if the process had already exited, causing unnecessary shutdown latency.Why This Change Was Made
errorhandlers to ngrok and Tailscale startupstdout/stderrstreams that reject the startup promise while the tunnel is still unresolved.closedflag for ngrok and short-circuitstop()when the process is already gone, avoiding the 2 s fallback wait.User Impact
Transient stream errors during voice-call tunnel startup are now logged and rejected cleanly instead of crashing the gateway. Stopping an already-exited ngrok tunnel returns immediately.
Evidence
Local focused tests pass:
Added regression tests for:
stdoutandstderrerrors before the tunnel is ready.stdouterror before the tunnel is ready.stop()resolving immediately when the ngrok process already closed.