fix: Windows CLI backends fail through npm shims#101378
Merged
Merged
Conversation
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step Review history (1 earlier review cycle)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6e26b699d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+39
to
+42
| execPath: | ||
| process.platform === "win32" | ||
| ? resolveWindowsExecutablePath("node", params.env ?? process.env) | ||
| : undefined, |
Contributor
There was a problem hiding this comment.
When a Windows backend is configured as an absolute npm .cmd path (for example C:\Program Files\nodejs\gemini.cmd) and the service PATH does not include that directory, this resolves the unwrapped JS entrypoint with node searched only from params.env/process.env. npm cmd-shims first try %dp0%\node.exe, so the wrapper would still work with the adjacent Node installation, but the new direct path can fail with ENOENT or run a different Node. Preserve the shim's own adjacent-Node resolution before bypassing it.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
rating: 🦪 silver shellfish
clawsweeper
Bot
removed
rating: 🦪 silver shellfish
Contributor
Author
|
Land-ready at exact head
Known proof gaps: none. |
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 7, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
* fix(process): resolve Windows npm CLI shims directly Co-authored-by: wendy-chsy <[email protected]> * docs(changelog): note Windows CLI shim fix * docs(process): explain Windows shim boundary * chore: keep release changelog owner-only * test(process): isolate Windows shim resolution * fix(process): classify Windows forwarding shims safely --------- Co-authored-by: wendy-chsy <[email protected]>
This was referenced Jul 7, 2026
sheyanmin
pushed a commit
to sheyanmin/openclaw
that referenced
this pull request
Jul 8, 2026
* fix(process): resolve Windows npm CLI shims directly Co-authored-by: wendy-chsy <[email protected]> * docs(changelog): note Windows CLI shim fix * docs(process): explain Windows shim boundary * chore: keep release changelog owner-only * test(process): isolate Windows shim resolution * fix(process): classify Windows forwarding shims safely --------- Co-authored-by: wendy-chsy <[email protected]>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
* fix(process): resolve Windows npm CLI shims directly Co-authored-by: wendy-chsy <[email protected]> * docs(changelog): note Windows CLI shim fix * docs(process): explain Windows shim boundary * chore: keep release changelog owner-only * test(process): isolate Windows shim resolution * fix(process): classify Windows forwarding shims safely --------- Co-authored-by: wendy-chsy <[email protected]>
wheakerd
pushed a commit
to wheakerd/clawdbot
that referenced
this pull request
Jul 15, 2026
* fix(process): resolve Windows npm CLI shims directly Co-authored-by: wendy-chsy <[email protected]> * docs(changelog): note Windows CLI shim fix * docs(process): explain Windows shim boundary * chore: keep release changelog owner-only * test(process): isolate Windows shim resolution * fix(process): classify Windows forwarding shims safely --------- Co-authored-by: wendy-chsy <[email protected]> (cherry picked from commit 7b366e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98573
Closes #92054
Closes #91489
Supersedes #98952, with contributor credit to @wendy-chsy.
What Problem This Solves
Fixes an issue where Windows users running globally installed Gemini CLI or Claude Code backends could fail to start the CLI because Node does not execute npm
.cmdlaunchers directly.Why This Change Was Made
Resolve standard Windows npm launchers through the existing generic spawn-program resolver, then execute their Node entrypoint or native executable directly. This keeps provider policy out of the process supervisor and preserves structured arguments, including Gemini prompts containing shell metacharacters, without opting into
shell: trueorcmd.exeparsing.User Impact
Gemini CLI and Claude Code backends installed through npm now start on Windows while prompts and arguments remain intact. Existing package-manager shim handling remains unchanged when PATH probing cannot resolve a wrapper.
Evidence
tbx_01kwxdx905kdbyrwcjgr2nrmnm): 21/21 child-adapter tests, 6/6 Windows-spawn tests, and 3/3 Docker-invocation sibling tests.check:changedpassed on the same Testbox, including tsgo, all oxlint shards, import-cycle checks, package guards, and generated-surface checks.cmd-shimlauncher shape for Gemini's JavaScript entrypoint and Claude's native executable, including a prompt with&,|,>, and%.cbx_4f9050b097eb, runrun_4b48efb2298b, using Node 24.18.0: 4/4 targeted npm-shim and custom-wrapper tests passed.