Skip to content

refactor(ui): localize unused module exports#101339

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v25
Jul 7, 2026
Merged

refactor(ui): localize unused module exports#101339
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v25

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The Control UI exposes internal-only types, constants, and helpers from 37 modules. Those exports inflate the module API surface and make static dead-code analysis noisier even though no other repository module imports them.

Why This Change Was Made

Localize 62 symbols that are referenced only inside their declaration module. This preserves runtime behavior and local typing while narrowing the public module surface.

User Impact

No user-visible behavior change. The UI module boundaries are smaller and future unused-code reports have less false-positive noise.

Evidence

  • Whole-repository identifier search confirmed each localized symbol has no external importer.
  • git diff --check
  • Control UI suite: 141 files passed, 2,285 tests passed, including Chromium responsive/mobile coverage.
  • pnpm check:changed on the patched tree: passed.
  • Exact committed patch SHA-256: 992cac3b9d237adfba2f08d525f3d5897cfdadcfcc954bece1d53f8eac2f7f50.
  • Fresh autoreview: no accepted/actionable findings.

@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 7, 2026
@vincentkoc
vincentkoc force-pushed the refactor/deadcode-full-sweep-20260706-v25 branch from 019cba7 to 0d77740 Compare July 7, 2026 04:02
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof:

  • Localized 62 repository-unreferenced exports across 37 Control UI modules.
  • Control UI suite passed: 141/141 files, 2,285/2,285 tests, including Chromium responsive/mobile coverage.
  • Exact committed patch SHA-256 matched locally and remotely: 992cac3b9d237adfba2f08d525f3d5897cfdadcfcc954bece1d53f8eac2f7f50.
  • Exact-patch pnpm check:changed passed in Crabbox run run_f00e854899ce.
  • Fresh pre-commit and post-format autoreviews reported no accepted/actionable findings.
  • Review artifacts validated with recommendation READY FOR /prepare-pr.

Known proof gaps: none for this behavior-neutral module-surface refactor.

@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 04:10
@vincentkoc
vincentkoc merged commit 835e6a7 into main Jul 7, 2026
108 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-full-sweep-20260706-v25 branch July 7, 2026 04:20
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 7, 2026
sheyanmin pushed a commit to sheyanmin/openclaw that referenced this pull request Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant