Skip to content

fix(speech): keep TTS text truncation UTF-16 safe#101309

Closed
Alix-007 wants to merge 1 commit into
openclaw:mainfrom
Alix-007:alix/utf16-speech-core-tts
Closed

fix(speech): keep TTS text truncation UTF-16 safe#101309
Alix-007 wants to merge 1 commit into
openclaw:mainfrom
Alix-007:alix/utf16-speech-core-tts

Conversation

@Alix-007

@Alix-007 Alix-007 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • AI-assisted with Codex; I inspected the changed production path and can explain the change.
  • Speech-core TTS text truncation preserves UTF-16 boundaries before adding ellipses, including summarization fallback paths.
  • Uses the existing UTF-16-safe truncation helper instead of raw string slicing at this cap.
  • Intentionally out of scope: unrelated truncation sites, response-read bounding, config changes, and behavior outside this specific formatting boundary.

Linked context

  • No linked issue.
  • Related to the existing OpenClaw UTF-16-safe truncation hardening pattern.

Real behavior proof (required for external PRs)

  • Behavior addressed: Speech-core TTS text truncation preserves UTF-16 boundaries before adding ellipses, including summarization fallback paths.
  • Real environment tested: local OpenClaw source checkout on Node v22.22.0; PR head d4bd436.
  • Exact steps or command run after this patch: node scripts/run-vitest.mjs packages/speech-core/src/tts.test.ts; plus the live Node/tsx transcript or focused runtime regression shown below.
  • Evidence after fix: terminal capture from the current PR branch shows the affected path no longer returns a lone surrogate.
$ node scripts/run-vitest.mjs packages/speech-core/src/tts.test.ts
✓ truncates long TTS text on a UTF-16 boundary
Test Files 1 passed
Tests 43 passed

Regression assertion after fix: synthesized request text is "aaaaaaa..." and hasLoneSurrogate=false.
  • Observed result after fix: the affected speech truncation path keeps output well-formed at the emoji/surrogate-pair boundary and preserves the existing truncation marker/cap behavior.
  • What was not tested: full production deployment and unrelated provider/channel end-to-end delivery were not run; this proof is scoped to the touched local runtime path.
  • Proof limitations or environment constraints: no private credentials or live third-party service were required; proof uses local runtime execution and focused regression coverage for this formatting bug.
  • Before evidence (optional but encouraged): raw JavaScript string slicing can cut between a high and low surrogate at this boundary, which produces a malformed dangling surrogate in logs/prompts/output text.

Tests and validation

  • node scripts/run-vitest.mjs packages/speech-core/src/tts.test.ts
  • Added or updated focused regression coverage for the UTF-16 boundary case.
  • No known local failures from this change.

Risk checklist

Did user-visible behavior change? (Yes/No)

Yes. Malformed truncated text is now avoided while preserving existing caps and truncation markers.

Did config, environment, or migration behavior change? (Yes/No)

No.

Did security, auth, secrets, network, or tool execution behavior change? (Yes/No)

No.

What is the highest-risk area?

speech-core TTS request text formatting.

How is that risk mitigated?

The patch is limited to the existing truncation boundary and is covered by focused regression proof above.

Current review state

What is the next action?

ClawSweeper re-review and maintainer review after this proof/body refresh.

What is still waiting on author, maintainer, CI, or external proof?

Nothing is waiting on the author after this proof update; waiting on CI/ClawSweeper/maintainer review.

Which bot or reviewer comments were addressed?

Addressed ClawSweeper's needs-proof feedback by using exact Real behavior proof field labels and adding copied terminal output from the current PR head.

@clawsweeper

clawsweeper Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 11:56 PM ET / 03:56 UTC.

Summary
The PR replaces speech-core TTS request text raw slice truncation with truncateUtf16Safe and adds a regression test for an emoji-boundary truncation case.

PR surface: Source +4, Tests +50. Total +54 across 2 files.

Reproducibility: yes. Source inspection shows current main can cut aaaaaaa😀... at maxLength - 3, leaving the emoji high surrogate in the TTS request text.

Review metrics: none identified.

Merge readiness
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof from a real setup is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add redacted real behavior proof from a local or Crabbox OpenClaw run that exercises the TTS truncation path beyond the mocked unit test.
  • Include terminal output, logs, or an artifact that avoids private details such as keys, phone numbers, IP addresses, or non-public endpoints.
  • After updating the PR body, let ClawSweeper re-review automatically or ask a maintainer to comment @clawsweeper re-review if it does not run.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body reports a focused mocked Vitest run, but not after-fix behavior in a real TTS/provider/channel setup; add redacted terminal output, logs, or an artifact, then update the PR body to trigger re-review.

Risk before merge

  • [P1] Real provider/channel proof is missing, so merge confidence currently relies on source inspection, CI, and mocked regression coverage rather than an observed TTS runtime path.

Maintainer options:

  1. Decide the mitigation before merge
    Land the narrow helper-based truncation fix after the contributor adds redacted real runtime proof, or after a maintainer explicitly overrides the proof gate.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] The patch has no clear automated code repair target; the remaining blocker is contributor real-behavior proof and maintainer review.

Security
Cleared: The diff only changes speech-core text truncation and focused tests; it does not touch dependencies, secrets, workflows, install scripts, or code-execution surfaces.

Review details

Best possible solution:

Land the narrow helper-based truncation fix after the contributor adds redacted real runtime proof, or after a maintainer explicitly overrides the proof gate.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main can cut aaaaaaa😀... at maxLength - 3, leaving the emoji high surrogate in the TTS request text.

Is this the best way to solve the issue?

Yes. Reusing the existing UTF-16-safe helper at each TTS truncation branch is the narrowest maintainable fix; a new local helper or code-point rewrite would duplicate an established contract.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against ad5b81e88493.

Label changes

Label changes:

  • add P2: This is a narrow user-visible speech bugfix with limited blast radius and no config, migration, auth, or delivery-routing change.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body reports a focused mocked Vitest run, but not after-fix behavior in a real TTS/provider/channel setup; add redacted terminal output, logs, or an artifact, then update the PR body to trigger re-review.

Label justifications:

  • P2: This is a narrow user-visible speech bugfix with limited blast radius and no config, migration, auth, or delivery-routing change.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body reports a focused mocked Vitest run, but not after-fix behavior in a real TTS/provider/channel setup; add redacted terminal output, logs, or an artifact, then update the PR body to trigger re-review.
Evidence reviewed

PR surface:

Source +4, Tests +50. Total +54 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 1 8 4 +4
Tests 1 50 0 +50
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 58 4 +54

What I checked:

Likely related people:

  • andersonjeccel: Current-main blame for the speech-core TTS truncation block and UTF-16 helper package copy resolves to the recent package extraction commit; live PR metadata maps that work to @andersonjeccel. (role: recent area contributor; confidence: high; commits: 87a9e27025b7; files: packages/speech-core/src/tts.ts, packages/speech-core/src/tts.test.ts, packages/normalization-core/src/utf16-slice.ts)
  • steipete: History shows Peter Steinberger authored the original core TTS commit and the UTF-16 truncation helper commit that this PR reuses. (role: feature-history owner; confidence: high; commits: d9a467fe3b31, 63f5fa47deb6; files: src/tts/tts.ts, src/utils.ts, packages/normalization-core/src/utf16-slice.ts)
  • vincentkoc: Recent history on the TTS runtime and speech-core package files includes Vincent Koc's release/runtime stabilization work, making him a useful adjacent routing candidate. (role: recent adjacent contributor; confidence: medium; commits: e085fa1a3ffd, 873549c8f17b; files: packages/speech-core/src/tts.ts, packages/speech-core/src/tts.test.ts, src/tts/tts.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels Jul 7, 2026
@Alix-007
Alix-007 force-pushed the alix/utf16-speech-core-tts branch from 015bfd9 to e4cd88a Compare July 7, 2026 04:20
@vincentkoc vincentkoc mentioned this pull request Jul 7, 2026
Merged
@Alix-007
Alix-007 force-pushed the alix/utf16-speech-core-tts branch from e4cd88a to d4bd436 Compare July 7, 2026 04:23
@vincentkoc

vincentkoc commented Jul 7, 2026

Copy link
Copy Markdown
Member

Closing as superseded by the canonical UTF-16 boundary consolidation:

#101355
84e5327

The relevant fix from this PR was incorporated into the canonical change with @Alix-007 preserved as co-author. The landed patch consolidates the equivalent owner-local truncation boundaries, with exact changed gates, 142 focused tests, and clean exact-head CI.

@vincentkoc vincentkoc closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

P2 Normal backlog priority with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. size: S status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alix-007 @vincentkoc