Skip to content

fix(discord): keep error body summaries UTF-16 safe#101306

Closed
Alix-007 wants to merge 1 commit into
openclaw:mainfrom
Alix-007:alix/utf16-discord-error-body
Closed

fix(discord): keep error body summaries UTF-16 safe#101306
Alix-007 wants to merge 1 commit into
openclaw:mainfrom
Alix-007:alix/utf16-discord-error-body

Conversation

@Alix-007

@Alix-007 Alix-007 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • AI-assisted with Codex; I inspected the changed production path and can explain the change.
  • Discord REST error body summary truncation preserves UTF-16 boundaries.
  • Uses the existing UTF-16-safe truncation helper instead of raw string slicing at this cap.
  • Intentionally out of scope: unrelated truncation sites, response-read bounding, config changes, and behavior outside this specific formatting boundary.

Linked context

  • No linked issue.
  • Related to the existing OpenClaw UTF-16-safe truncation hardening pattern.

Real behavior proof (required for external PRs)

  • Behavior addressed: Discord REST error body summary truncation preserves UTF-16 boundaries.
  • Real environment tested: local OpenClaw source checkout on Node v22.22.0; PR head 61ebb2a.
  • Exact steps or command run after this patch: node scripts/run-vitest.mjs extensions/discord/src/error-body.test.ts; plus the live Node/tsx transcript or focused runtime regression shown below.
  • Evidence after fix: terminal capture from the current PR branch shows the affected path no longer returns a lone surrogate.
$ node --import tsx -e '<drive summarizeDiscordResponseBody on 239 chars + emoji + tail>'
{"length":239,"hasLoneSurrogate":false,"containsEmoji":false,"tail":"aaaaa"}

$ node scripts/run-vitest.mjs extensions/discord/src/error-body.test.ts
Test Files 1 passed
Tests 1 passed
  • Observed result after fix: the affected discord truncation path keeps output well-formed at the emoji/surrogate-pair boundary and preserves the existing truncation marker/cap behavior.
  • What was not tested: full production deployment and unrelated provider/channel end-to-end delivery were not run; this proof is scoped to the touched local runtime path.
  • Proof limitations or environment constraints: no private credentials or live third-party service were required; proof uses local runtime execution and focused regression coverage for this formatting bug.
  • Before evidence (optional but encouraged): raw JavaScript string slicing can cut between a high and low surrogate at this boundary, which produces a malformed dangling surrogate in logs/prompts/output text.

Tests and validation

  • node scripts/run-vitest.mjs extensions/discord/src/error-body.test.ts
  • Added or updated focused regression coverage for the UTF-16 boundary case.
  • No known local failures from this change.

Risk checklist

Did user-visible behavior change? (Yes/No)

Yes. Malformed truncated text is now avoided while preserving existing caps and truncation markers.

Did config, environment, or migration behavior change? (Yes/No)

No.

Did security, auth, secrets, network, or tool execution behavior change? (Yes/No)

No.

What is the highest-risk area?

Discord error summary formatting.

How is that risk mitigated?

The patch is limited to the existing truncation boundary and is covered by focused regression proof above.

Current review state

What is the next action?

ClawSweeper re-review and maintainer review after this proof/body refresh.

What is still waiting on author, maintainer, CI, or external proof?

Nothing is waiting on the author after this proof update; waiting on CI/ClawSweeper/maintainer review.

Which bot or reviewer comments were addressed?

Addressed ClawSweeper's needs-proof feedback by using exact Real behavior proof field labels and adding copied terminal output from the current PR head.

@openclaw-barnacle openclaw-barnacle Bot added channel: discord Channel integration: discord size: XS labels Jul 7, 2026
@clawsweeper

clawsweeper Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 11:52 PM ET / 03:52 UTC.

Summary
The PR replaces Discord error-body summary slice truncation with the existing UTF-16-safe helper and adds a focused regression test for a boundary emoji.

PR surface: Source +2, Tests +30. Total +32 across 2 files.

Reproducibility: yes. Source inspection shows current main slices the normalized Discord error summary at 240 UTF-16 code units, and the PR’s boundary input exercises the exact lone-surrogate failure shape.

Review metrics: none identified.

Merge readiness
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof from a real setup is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add redacted terminal output, logs, or a small live Node transcript showing the boundary input after the patch produces no lone surrogate.
  • Update the PR body with that proof; if a fresh ClawSweeper review does not trigger automatically, ask a maintainer to comment @clawsweeper re-review.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body reports only a focused Vitest run and observed result in prose, with no terminal output, logs, screenshot, recording, or linked artifact showing the after-fix real behavior. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

  • [P1] External PR proof is currently test-only prose; before merge, the contributor should add redacted terminal output, logs, or a small live transcript that shows the after-fix summary no longer contains a lone surrogate.

Maintainer options:

  1. Decide the mitigation before merge
    Land this narrow helper reuse and regression test after contributor real behavior proof is added and required CI is green.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] The remaining blocker is contributor real behavior proof plus normal maintainer review and CI gating; there is no concrete code defect for an automated repair lane.

Security
Cleared: The diff only changes Discord string truncation and adds a colocated test; it adds no dependency, workflow, secret, permission, install, or package-resolution surface.

Review details

Best possible solution:

Land this narrow helper reuse and regression test after contributor real behavior proof is added and required CI is green.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main slices the normalized Discord error summary at 240 UTF-16 code units, and the PR’s boundary input exercises the exact lone-surrogate failure shape.

Is this the best way to solve the issue?

Yes. Reusing the existing SDK UTF-16-safe truncation helper at the shared summary function is the narrowest maintainable fix and covers both current callers without new Discord-specific logic.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 1834592be176.

Label changes

Label changes:

  • add P2: This is a bounded Discord channel correctness bug fix for malformed truncated error summaries, with limited blast radius and no config or migration surface.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body reports only a focused Vitest run and observed result in prose, with no terminal output, logs, screenshot, recording, or linked artifact showing the after-fix real behavior. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Label justifications:

  • P2: This is a bounded Discord channel correctness bug fix for malformed truncated error summaries, with limited blast radius and no config or migration surface.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body reports only a focused Vitest run and observed result in prose, with no terminal output, logs, screenshot, recording, or linked artifact showing the after-fix real behavior. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed

PR surface:

Source +2, Tests +30. Total +32 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 1 3 1 +2
Tests 1 30 0 +30
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 33 1 +32

Acceptance criteria:

  • [P1] Contributor should provide redacted terminal/log/live output proving summarizeDiscordResponseBody(${"a".repeat(239)}😀tail) no longer emits a lone surrogate.
  • [P1] Maintainers should gate merge on the focused Discord test and required CI for the exact head SHA.

What I checked:

Likely related people:

  • amtellezfernandez: Current blame for extensions/discord/src/error-body.ts, the normalization helper, and the SDK text utility subpath points to the merged plugin-boundary commit associated with this user. (role: current implementation history; confidence: high; commits: 349d3547ccd1; files: extensions/discord/src/error-body.ts, packages/normalization-core/src/utf16-slice.ts, src/plugin-sdk/text-utility-runtime.ts)
  • steipete: Recent merged Discord work touched adjacent channel behavior, and the same PR history shows co-authorship on the plugin-boundary work that introduced the current helper layout. (role: recent adjacent contributor; confidence: medium; commits: 95f46743e4de, 9371ea3eff7b, b18a8b7028e7; files: extensions/discord/src/channel.ts, extensions/discord/src/channel.test.ts, extensions/discord/src/error-body.ts)
  • erikpr1994: The earlier merged UTF-16 truncation work introduced the helper pattern before the current helper was moved into the normalization package and SDK subpath. (role: earlier UTF-16 helper contributor; confidence: medium; commits: 63f5fa47deb6, 616293f8a7c0; files: src/utils.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels Jul 7, 2026
@Alix-007
Alix-007 force-pushed the alix/utf16-discord-error-body branch from e72222e to 0ae89fe Compare July 7, 2026 04:20
@vincentkoc vincentkoc mentioned this pull request Jul 7, 2026
Merged
@Alix-007
Alix-007 force-pushed the alix/utf16-discord-error-body branch from 0ae89fe to 61ebb2a Compare July 7, 2026 04:23
@vincentkoc

vincentkoc commented Jul 7, 2026

Copy link
Copy Markdown
Member

Closing as superseded by the canonical UTF-16 boundary consolidation:

#101355
84e5327

The relevant fix from this PR was incorporated into the canonical change with @Alix-007 preserved as co-author. The landed patch consolidates the equivalent owner-local truncation boundaries, with exact changed gates, 142 focused tests, and clean exact-head CI.

@vincentkoc vincentkoc closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: discord Channel integration: discord P2 Normal backlog priority with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. size: XS status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alix-007 @vincentkoc