refactor(ui): remove unused module exports#101262
Conversation
1622c2a to
003c0e0
Compare
|
Codex review: needs changes before merge. Reviewed July 6, 2026, 10:36 PM ET / 02:36 UTC. Summary PR surface: Source -9, Tests -13. Total -22 across 11 files. Reproducibility: not applicable. this is a cleanup PR, not a bug report with a failing user path. The merge blocker is reproducible from exact-head CI via the plugin SDK surface budget check. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the cleanup, reconcile the public-surface budget for the intended export reduction, refresh onto current main, and merge only after exact-head CI is green or explicitly maintainer-classified. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a cleanup PR, not a bug report with a failing user path. The merge blocker is reproducible from exact-head CI via the plugin SDK surface budget check. Is this the best way to solve the issue? Not yet: localizing implementation-only UI exports is the right cleanup shape, but the submitted branch is not merge-ready until the public-surface budget and current-main CI drift are reconciled. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6273e82ca55a. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -9, Tests -13. Total -22 across 11 files. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
003c0e0 to
7399c88
Compare
7399c88 to
ff6bf9d
Compare
|
Merged via squash.
|
What Problem This Solves
The Control UI still exported several helpers and types that have no consumers outside their defining modules. One pairing-hint wrapper also duplicated the canonical resolver without adding behavior.
Why This Change Was Made
Keep the UI module surface aligned with actual ownership:
shouldShowPairingHintwrapperresolvePairingHintdirectly in the existing testsThis removes 22 net lines without changing runtime behavior.
User Impact
No user-visible behavior change. The UI keeps the same pairing-hint decisions while exposing fewer internal symbols.
Evidence
mainatd86bb60fbadfb0ebe94d3e88c75c9de78e8e9307run_f4f6f907730con leasecbx_59dd2f65386c: all four typecheck lanes, core/extensions/scripts lint, app checks, import-cycle checks, and guard suites passedrun_6d2975fb12fa: 8 targeted UI test files / 198 tests passed, plus scopedcoreandcoreTestschanged gates