Skip to content

refactor(deadcode): localize internal type aliases#101243

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v20
Jul 7, 2026
Merged

refactor(deadcode): localize internal type aliases#101243
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v20

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Internal implementation types were still exported across core, Control UI, and bundled plugins even though no repository consumer imports them. Those exports enlarge module surfaces and keep appearing in dead-code reports.

Why This Change Was Made

The fresh codebase-memory graph and exact-head ts-unused-exports report agreed on 12 file-local type aliases. Repository-wide reference checks confirmed each symbol is used only by its defining module and is not re-exported through a public barrel or plugin API.

This localizes:

  • 4 core agent types
  • 4 Control UI types
  • 4 bundled plugin types

Runtime implementations and exported functions are unchanged.

User Impact

No user-visible behavior changes. The internal API surface is smaller and the dead-code signal is less noisy.

Evidence

  • Fresh full, non-shallow worktree from origin/main
  • codebase-memory MCP index: 20,910 files, 276,935 nodes, 1,111,784 edges
  • graph query: all 12 selected types had zero in-degree/out-degree and were not entry points
  • exact Testbox dead-code report: 3,685 lines before, 3,669 after; all 12 selected symbols absent
  • Testbox tbx_01kwwzqg6e2sz1qbbebcya65mt: 6 Vitest shards, 8 focused files, 142 tests passed
  • Testbox check:changed: core, core tests, extensions, and extension tests lanes passed
  • git diff --check
  • fresh Codex autoreview: clean, no accepted/actionable findings, 0.87 confidence

@openclaw-barnacle openclaw-barnacle Bot added channel: discord Channel integration: discord app: web-ui App: web-ui agents Agent runtime and tooling extensions: copilot labels Jul 7, 2026
@vincentkoc vincentkoc self-assigned this Jul 7, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review July 7, 2026 00:47
@openclaw-barnacle openclaw-barnacle Bot added the maintainer Maintainer-authored PR label Jul 7, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 96773afdff26b4e355f11a4a2df8f9c136c6ee5a:

  • fresh full, non-shallow worktree from current origin/main
  • codebase-memory MCP index: 20,910 files, 276,935 nodes, 1,111,784 edges
  • graph query: all 12 selected types had zero in-degree/out-degree and were not entry points
  • Testbox tbx_01kwwzqg6e2sz1qbbebcya65mt: 6 Vitest shards, 8 focused files, 142 tests passed
  • exact-head Testbox pnpm check:changed passed for core, core tests, extensions, and extension tests
  • exact-head ts-unused-exports: 3,685 report lines before, 3,669 after; all 12 selected symbols absent
  • git diff --check
  • fresh Codex autoreview: no accepted/actionable findings, 0.87 confidence
  • GitHub CI run 28833498207: all required jobs passed

No behavior, runtime value, config, protocol, docs, or changelog changes. No known proof gaps.

@vincentkoc
vincentkoc merged commit 775ef96 into main Jul 7, 2026
190 of 194 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-full-sweep-20260706-v20 branch July 7, 2026 00:57
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling app: web-ui App: web-ui channel: discord Channel integration: discord extensions: copilot maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant