fix(markdown-core): CJK-friendly emphasis flanking so **标签：**正文 renders bold (#101120) by nicknmorty · Pull Request #101230 · openclaw/openclaw

nicknmorty · 2026-07-06T23:47:52Z

What Problem This Solves

CJK Markdown such as **标题：**正文 can render literal emphasis markers. CommonMark's closing-delimiter rule rejects punctuation immediately inside ** when adjacent CJK text follows without whitespace. Because Telegram, Signal, and Slack consume the shared Markdown IR, the defect belongs in packages/markdown-core, not in one transport.

Why This Change Was Made

Enable the maintained MIT markdown-it-cjk-friendly 2.0.2 plugin at the shared MarkdownIt construction point.
Keep the dependency local to @openclaw/markdown-core; its only runtime dependency, get-east-asian-width, was already resolved in this workspace.
Replace the submitted 125-line local delimiter/Unicode implementation with the upstream amendment, which directly covers supplementary CJK, variation selectors, ambiguous punctuation, underscores, Unicode whitespace, and the CommonMark corpus.
Keep Telegram's reported-output regression while adding shared IR regressions for Chinese, Japanese, Korean, supplementary-plane CJK, variation selectors, Unicode whitespace, ordinary Latin, intraword underscores, code spans, and links.

User Impact

CJK emphasis now renders consistently through every channel using the shared Markdown IR. Ordinary CommonMark behavior remains unchanged outside the CJK-friendly amendment; invalid whitespace-delimited openers remain literal.

Evidence

Reviewed head: dbc66f154026d80e23b496d723e60762712cd0ca

Sanitized AWS Crabbox cbx_ed9e9a7749ff / coral-lobster, public network, no Tailscale, empty instance profile, no credential hydration.
Run run_837ab245e94c: pnpm test packages/markdown-core/src/ir.emphasis-cjk.test.ts extensions/telegram/src/format.test.ts — 77 passed; pnpm check:changed -- ... — passed; pnpm build — passed.
Run run_4947d71286b2: clean full build plus source-blind built-artifact validation — 11/11 behavior fixtures passed.
git diff --check and focused oxfmt --check — passed.
Two fresh autoreviews after the dependency rewrite and changelog — clean, no accepted/actionable findings (0.96 and 0.97 confidence).
Direct dependency inspection: markdown-it-cjk-friendly 2.0.2 source/tests/package metadata and markdown-it 14.3.0 delimiter scanner; package is ESM-only, MIT, Node 18+, actively maintained, and tests parity against the CommonMark 0.31.2 corpus.

Docs

No command, configuration, or operator workflow changed. The maintainer changelog entry thanks @nicknmorty and references this PR and #101120.

clawsweeper · 2026-07-06T23:56:32Z

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head 6e0e94f53990b3dff613f75d135025d99102c55b, but the PR head is now b09b0c8fc650e5e18fb654dafd5c4e665508c9dd. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

Review history (4 earlier review cycles)

reviewed 2026-07-07T00:01:07.220Z sha 80fa441 :: needs real behavior proof before merge. :: [P1] Use a real markdown-it StateInline type contract
reviewed 2026-07-07T01:12:03.976Z sha 92f28bf :: needs real behavior proof before merge. :: [P1] Preserve markdown-it whitespace flanking
reviewed 2026-07-07T01:52:28.190Z sha e070fcb :: needs maintainer review before merge. :: none
reviewed 2026-07-07T02:54:59.400Z sha 0041bc6 :: needs maintainer review before merge. :: none

…miter override Preserves markdown-it isWhiteSpace classification (U+3000, U+00A0, U+2000-200A, etc.) before forcing CJK-adjacent delimiter flags, and adds U+3000/U+2009 regressions. Addresses clawsweeper P1 finding on openclaw#101230.

nicknmorty · 2026-07-07T01:41:11Z

@clawsweeper re-review

clawsweeper · 2026-07-07T01:41:14Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

…miter override Preserves markdown-it isWhiteSpace classification (U+3000, U+00A0, U+2000-200A, etc.) before forcing CJK-adjacent delimiter flags, and adds U+3000/U+2009 regressions. Addresses clawsweeper P1 finding on openclaw#101230.

github-actions · 2026-07-07T03:39:16Z

Dependency Guard

This PR changes dependency-related files. Maintainers should confirm these changes are intentional.

Changed files:

packages/markdown-core/package.json
pnpm-lock.yaml

Maintainer follow-up:

Review whether the dependency changes are intentional.
Inspect resolved package deltas when lockfile, shrinkwrap, or workspace dependency policy changes are present.
Treat package-lock.json and npm-shrinkwrap.json diffs as security-review surfaces.
Run pnpm deps:changes:report -- --base-ref origin/main --markdown /tmp/dependency-changes.md --json /tmp/dependency-changes.json locally for detailed release-style evidence.

github-actions · 2026-07-07T03:39:35Z

Dependency graph change authorized

This PR includes dependency graph changes. A repository admin or member of @openclaw/openclaw-secops authorized this exact head SHA with /allow-dependencies-change.

Approved SHA: b09b0c8fc650e5e18fb654dafd5c4e665508c9dd
Approved by: @steipete
Reason: maintained MIT CJK delimiter plugin; exact package source, tests, metadata, lockfile, Node compatibility, and transitive graph reviewed

A later push changes the PR head SHA and requires a fresh security approval.

…miter override Preserves markdown-it isWhiteSpace classification (U+3000, U+00A0, U+2000-200A, etc.) before forcing CJK-adjacent delimiter flags, and adds U+3000/U+2009 regressions. Addresses clawsweeper P1 finding on openclaw#101230.

socket-security · 2026-07-07T04:33:14Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/markdown-it-cjk-friendly@2.0.2

View full report

socket-security · 2026-07-07T04:33:16Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Low adoption: npm `markdown-it-cjk-friendly` Location: Package overview From: packages/markdown-core/package.json → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What are unpopular packages? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Unpopular packages may have less maintenance and contain other problems. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

steipete · 2026-07-07T04:33:23Z

/allow-dependencies-change maintained MIT CJK delimiter plugin; exact package source, tests, metadata, lockfile, Node compatibility, and transitive graph reviewed

steipete · 2026-07-07T04:43:47Z

Merged via squash.

Prepared head SHA: b09b0c8fc650e5e18fb654dafd5c4e665508c9dd
Landed commit: 59097783e2d0273c07d7ecfbec3d982340f9fd57

…rs bold (openclaw#101120) (openclaw#101230) * test(telegram): reproduce CJK emphasis flanking bug * fix(markdown-core): support CJK emphasis flanking * fix(markdown-core): type CJK delimiter state (openclaw#101120) * fix(markdown-core): mirror markdown-it Unicode whitespace in CJK delimiter override Preserves markdown-it isWhiteSpace classification (U+3000, U+00A0, U+2000-200A, etc.) before forcing CJK-adjacent delimiter flags, and adds U+3000/U+2009 regressions. Addresses clawsweeper P1 finding on openclaw#101230. * refactor(markdown): use maintained CJK flanking plugin --------- Co-authored-by: Peter Steinberger <[email protected]>

openclaw-barnacle Bot added channel: telegram Channel integration: telegram size: S triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jul 6, 2026

clawsweeper Bot had a problem deploying to qa-live-shared July 7, 2026 00:04 Failure

clawsweeper Bot mentioned this pull request Jul 7, 2026

fix(markdown-core): add CJK-friendly emphasis parsing for bold/italic #101229

Closed

openclaw-barnacle Bot removed the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jul 7, 2026

nicknmorty force-pushed the fix/cjk-emphasis-flanking-101120 branch from e070fcb to 0041bc6 Compare July 7, 2026 02:34

steipete self-assigned this Jul 7, 2026

nicknmorty force-pushed the fix/cjk-emphasis-flanking-101120 branch from 0041bc6 to e471027 Compare July 7, 2026 03:17

steipete requested a review from a team as a code owner July 7, 2026 03:38

github-actions Bot added the dependencies-changed PR changes dependency-related files label Jul 7, 2026

openclaw-barnacle Bot added the docs Improvements or additions to documentation label Jul 7, 2026

nicknmorty and others added 3 commits July 7, 2026 05:30

fix(markdown-core): type CJK delimiter state (openclaw#101120)

e881249

refactor(markdown): use maintained CJK flanking plugin

b09b0c8

steipete force-pushed the fix/cjk-emphasis-flanking-101120 branch from 6e0e94f to b09b0c8 Compare July 7, 2026 04:32

steipete merged commit 5909778 into openclaw:main Jul 7, 2026
114 of 119 checks passed

vincentkoc mentioned this pull request Jul 7, 2026

fix(markdown): parse CJK label emphasis #101341

Closed

This was referenced Jul 9, 2026

WebChat Markdown rendering breaks for Japanese/CJK: (1) **bold** fails at punctuation boundaries, (2) <br> shown literally #102405

Open

fix: resolve lint and type checking errors #104279

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(markdown-core): CJK-friendly emphasis flanking so 标签：正文 renders bold (#101120)#101230

fix(markdown-core): CJK-friendly emphasis flanking so 标签：正文 renders bold (#101120)#101230
steipete merged 5 commits into
openclaw:mainfrom
nicknmorty:fix/cjk-emphasis-flanking-101120

nicknmorty commented Jul 6, 2026 •

edited by steipete

Loading

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

nicknmorty commented Jul 7, 2026

Uh oh!

clawsweeper Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented Jul 7, 2026

Uh oh!

socket-security Bot commented Jul 7, 2026

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

nicknmorty commented Jul 6, 2026 • edited by steipete Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Docs

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicknmorty commented Jul 7, 2026

Uh oh!

clawsweeper Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

Dependency Guard

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency graph change authorized

Uh oh!

socket-security Bot commented Jul 7, 2026

Uh oh!

socket-security Bot commented Jul 7, 2026

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Uh oh!

steipete commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nicknmorty commented Jul 6, 2026 •

edited by steipete

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading