fix(windows): repair legacy gateway fallback updates by steipete · Pull Request #101213 · openclaw/openclaw

steipete · 2026-07-06T22:58:21Z

What Problem This Solves

Windows gateways that fell back to a Startup-folder launcher can remain on that legacy path across openclaw update. When the configured gateway port or service command changes, the updater can leave the old process alive, rewrite the task around it, or remove the fallback before the replacement Scheduled Task is actually running.

Fixes #87156.
Supersedes #88311; this maintainer branch preserves and extends @vincentkoc's original work because that branch does not allow maintainer edits.

Why This Change Was Made

Capture the installed fallback command, environment, port, and runtime before rewriting the service.
Require exact process ownership before stopping or replacing a running fallback.
Preflight the replacement port before any mutation.
Preserve legacy gateway auth before reinstalling the service.
Bound the Scheduled Task evidence poll and roll back to the captured fallback if replacement startup cannot be proven.
Accept the exact persisted replacement process as running evidence while its listener is still starting; full argv matching prevents an unrelated same-port gateway from being attributed to the task.
Restart repaired gateways after git-driven updates and thread repair results through CLI, gateway, and doctor update paths.

User Impact

On Windows, doctor-driven updates migrate owned Startup-folder gateway fallbacks to Task Scheduler without losing auth or leaving the old gateway on a stale port. Fallback launchers are removed only after the replacement task has concrete running evidence; failed takeover restores the prior fallback.

Evidence

Current head: 8c685fdcd1fe69b3d8b7200edcd2d8e4f65d9f4f

Testbox: 584 relevant tests passed across update CLI, doctor, daemon, gateway, and update-runner surfaces.
pnpm check:changed: passed core production/test typechecks, full core lint, changelog checks, import-cycle and repository guards.
Blacksmith Testbox run: https://github.com/openclaw/openclaw/actions/runs/28828168676
Native Windows 11 Parallels proof built runtime head 01020960a7cdd3b4345f2c36afe7ca4c1647a12b and exercised a live legacy Startup fallback through doctor --fix. The current head differs only by removing a release-owned changelog line; runtime and tests are byte-identical:
- pre_doctor_fallback_running=ok
- native_windows_doctor_update_repair=ok
- token_preserved_without_disclosure=ok
- old_fallback_port_released=ok
- fallback_removed_after_scheduler_evidence=ok
- replacement gateway status: running; read probe: ok
Fresh structured autoreview: clean, no actionable findings (0.93 confidence).

Co-authored-by: Vincent Koc <[email protected]>

steipete · 2026-07-06T22:58:42Z

Land-ready proof for current head 8c685fdcd1fe69b3d8b7200edcd2d8e4f65d9f4f:

corepack pnpm test src/cli/update-cli.test.ts src/cli/update-cli/update-command.test.ts src/commands/doctor-gateway-services.test.ts src/commands/doctor-update.test.ts src/daemon/schtasks.startup-fallback.test.ts src/daemon/schtasks.stop.test.ts src/daemon/service-layout.test.ts src/flows/doctor-health-contributions.test.ts src/gateway/server-methods/update.test.ts src/infra/update-post-core-finalize.test.ts src/infra/update-runner.test.ts — 584 tests passed on Blacksmith Testbox.
corepack pnpm check:changed — passed core and core-test typechecks, full core lint, changelog validation, import-cycle check, and repository guards.
Testbox run: https://github.com/openclaw/openclaw/actions/runs/28828168676
Native Windows 11 Parallels: built runtime head 01020960a7cdd3b4345f2c36afe7ca4c1647a12b, started a real legacy Startup-folder gateway, changed the configured port, and ran doctor --fix. The current head differs only by removing a release-owned changelog line; runtime and tests are byte-identical. Proof markers: pre_doctor_fallback_running=ok, native_windows_doctor_update_repair=ok, token_preserved_without_disclosure=ok, old_fallback_port_released=ok, fallback_removed_after_scheduler_evidence=ok. The replacement Scheduled Task reported running and its live gateway read probe passed.
Fresh structured autoreview: clean; no accepted/actionable findings.

Known proof gaps: none for the changed Windows/update surfaces.

steipete · 2026-07-06T23:09:52Z

Merged via squash.

Prepared head SHA: 8c685fdcd1fe69b3d8b7200edcd2d8e4f65d9f4f
Landed commit: bb44c2311d7416922a9a8e1ed9f28b16df3ebc0e

* fix(windows): repair doctor update fallback migration * fix(windows): remove hidden startup fallback launchers * fix(windows): preserve recovered gateway tokens * fix(windows): harden update fallback migration Co-authored-by: Vincent Koc <[email protected]> * fix(windows): capture fallback runtime before task rewrite Co-authored-by: Vincent Koc <[email protected]> * fix(windows): complete legacy update restart handoff Co-authored-by: Vincent Koc <[email protected]> * fix(windows): verify fallback ownership during migration Co-authored-by: Vincent Koc <[email protected]> * fix(windows): honor update restart policy during repair * fix(windows): wait for task takeover evidence * fix(windows): preserve fallback after direct task launch * fix(windows): preserve repaired task identity * fix(windows): snapshot gateway before repair * fix: scope update service repair ownership * style: satisfy update lint checks * fix: restart gateways stopped during updates * fix(windows): enforce fallback process takeover * fix(windows): prove fallback ownership during takeover * fix(windows): verify process exit during takeover * fix(windows): wait through fallback reloads * fix(windows): harden fallback takeover ownership * fix(windows): type takeover preflight inputs * fix(windows): recognize booting replacement task Co-authored-by: Vincent Koc <[email protected]> * chore: leave changelog release-owned --------- Co-authored-by: Vincent Koc <[email protected]>

vincentkoc and others added 22 commits July 6, 2026 23:39

fix(windows): repair doctor update fallback migration

abd4a64

fix(windows): remove hidden startup fallback launchers

f5e6a4f

fix(windows): preserve recovered gateway tokens

46112a8

fix(windows): harden update fallback migration

745024f

Co-authored-by: Vincent Koc <[email protected]>

fix(windows): capture fallback runtime before task rewrite

29edbad

Co-authored-by: Vincent Koc <[email protected]>

fix(windows): complete legacy update restart handoff

bad0b61

Co-authored-by: Vincent Koc <[email protected]>

fix(windows): verify fallback ownership during migration

27f4556

Co-authored-by: Vincent Koc <[email protected]>

fix(windows): honor update restart policy during repair

d3ddb9f

fix(windows): wait for task takeover evidence

38b850e

fix(windows): preserve fallback after direct task launch

783040a

fix(windows): preserve repaired task identity

2b0ea7c

fix(windows): snapshot gateway before repair

d926639

fix: scope update service repair ownership

0c06bfb

style: satisfy update lint checks

e050be3

fix: restart gateways stopped during updates

d0d8d9c

fix(windows): enforce fallback process takeover

86bbd84

fix(windows): prove fallback ownership during takeover

0103066

fix(windows): verify process exit during takeover

61a19a1

fix(windows): wait through fallback reloads

31b4795

fix(windows): harden fallback takeover ownership

9980d62

fix(windows): type takeover preflight inputs

8004fc6

fix(windows): recognize booting replacement task

0102096

Co-authored-by: Vincent Koc <[email protected]>

openclaw-barnacle Bot added gateway Gateway runtime cli CLI command changes commands Command implementations size: XL maintainer Maintainer-authored PR labels Jul 6, 2026

chore: leave changelog release-owned

8c685fd

steipete merged commit bb44c23 into main Jul 6, 2026
104 checks passed

steipete deleted the codex/pr-88311-replay branch July 6, 2026 23:09

steipete mentioned this pull request Jul 6, 2026

fix(windows): repair doctor update fallback migration #88311

Closed

clawsweeper Bot mentioned this pull request Jul 6, 2026

fix: avoid gateway daemon repair on protocol mismatch #87205

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(windows): repair legacy gateway fallback updates#101213

fix(windows): repair legacy gateway fallback updates#101213
steipete merged 23 commits into
mainfrom
codex/pr-88311-replay

steipete commented Jul 6, 2026 •

edited

Loading

Uh oh!

steipete commented Jul 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

steipete commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

steipete commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

steipete commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

steipete commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

steipete commented Jul 6, 2026 •

edited

Loading

steipete commented Jul 6, 2026 •

edited

Loading