Skip to content

fix(qa): keep smoke profile on one channel#101173

Merged
vincentkoc merged 1 commit into
mainfrom
dallin/fix-qa-smoke-channel-selection
Jul 6, 2026
Merged

fix(qa): keep smoke profile on one channel#101173
vincentkoc merged 1 commit into
mainfrom
dallin/fix-qa-smoke-channel-selection

Conversation

@RomneyDa

@RomneyDa RomneyDa commented Jul 6, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Resolves a problem where the smoke-ci QA profile selected Telegram, Matrix, Slack, and WhatsApp scenarios together, causing CI to fail before scenario execution because one QA suite run supports only one channel driver instance.

Why This Change Was Made

Automatic Crabline profile selection now keeps channel-unpinned scenarios plus Crabline's default Telegram scenarios. Explicitly requested non-default scenarios still infer and use their declared channel, and the suite's mixed-channel rejection remains unchanged.

User Impact

QA Smoke CI can start its deterministic scenario run instead of failing during planning when the shared catalog contains scenarios for several channels. Explicit channel-focused QA commands retain their existing behavior.

Evidence

  • Original failure: CI run 28818865466, job 85465286235 selected Telegram, Matrix, Slack, and WhatsApp and exited before any scenario execution.
  • Current-main repro before the fix on Blacksmith Testbox tbx_01kwwgg5zsdwddrngk045s9dd7: the smoke profile selected 92 scenarios and failed with the same four-channel planning error.
  • Regression test before the fix: 90 passed / 1 failed with the same planning error; explicit Slack scenario selection passed.
  • After the fix on the same Testbox: extensions/qa-lab/src/cli.runtime.test.ts passed 91/91.
  • Targeted oxlint passed with 0 warnings and 0 errors.
  • Scoped changed checks passed repository guards, then extension typecheck was blocked by the known Testbox sparse-sync omission of tracked extensions/qa-lab/src/mantis/**; exact-head hosted CI is the typecheck authority.
  • Fresh structured Codex autoreview: .agents/skills/autoreview/scripts/autoreview --mode local --stream-engine-output --prompt '<scoped qa-smoke-selector review>' completed clean with no accepted/actionable findings (patch is correct, confidence 0.86).

AI-assisted change; implementation and evidence were reviewed and validated as described above.

@RomneyDa RomneyDa closed this Jul 6, 2026
@RomneyDa
RomneyDa deleted the dallin/fix-qa-smoke-channel-selection branch July 6, 2026 20:12
@RomneyDa
RomneyDa restored the dallin/fix-qa-smoke-channel-selection branch July 6, 2026 20:13
@RomneyDa RomneyDa reopened this Jul 6, 2026
@vincentkoc vincentkoc self-assigned this Jul 6, 2026
@RomneyDa

RomneyDa commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

@vincentkoc

Copy link
Copy Markdown
Member

Maintainer review complete and land-ready.

Evidence:

  • node scripts/run-vitest.mjs extensions/qa-lab/src/cli.runtime.test.ts - 91/91 passed.
  • Fresh exact-head autoreview - no accepted/actionable findings; patch correct, confidence 0.84.
  • Blacksmith Testbox tbx_01kwwgg5zsdwddrngk045s9dd7 - reproduced the current-main four-channel planning failure, then passed the focused suite after the fix.
  • Exact-head hosted CI run 28820232195 - passed, including QA Smoke CI.
  • Native scripts/pr prepare-run 101173 gate - passed.

The fix keeps automatic Crabline profiles on the default Telegram channel while preserving explicit non-default scenario selection and the suite's mixed-channel rejection.

@vincentkoc
vincentkoc merged commit b773f79 into main Jul 6, 2026
167 of 222 checks passed
@vincentkoc
vincentkoc deleted the dallin/fix-qa-smoke-channel-selection branch July 6, 2026 20:27
@vincentkoc

Copy link
Copy Markdown
Member

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants