Skip to content

refactor(ui): trim unused type surface#100952

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v11
Jul 6, 2026
Merged

refactor(ui): trim unused type surface#100952
vincentkoc merged 1 commit into
mainfrom
refactor/deadcode-full-sweep-20260706-v11

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

The Control UI exposed aliases that are only consumed inside their defining module and retained stale type declarations with no consumers. That made the UI TypeScript surface larger than the code actually supports.

Fixes #100951

Why This Change Was Made

  • remove eight declaration-only aliases and one unused normalization re-export
  • make 28 internal-only aliases and helpers module-private
  • keep runtime behavior and gateway protocol handling unchanged

User Impact

No user-visible behavior changes. This narrows internal TypeScript ownership and removes dead declarations.

Evidence

  • full codebase-memory graph: 273,851 nodes / 1,090,961 edges; zero cross-file ingress for localized symbols
  • node scripts/run-vitest.mjs ui/src/app/exec-approval.test.ts ui/src/lib/chat/commands.browser-import.test.ts ui/src/lib/chat/commands.test.ts ui/src/lib/config/index.test.ts ui/src/lib/cron/index.test.ts ui/src/pages/tasks/data.test.ts (130 tests passed)
  • node_modules/.bin/oxfmt --check on all 13 changed files
  • Blacksmith Testbox tbx_01kwvxqcrzhphfm321q4s1ww7e: pnpm check:changed passed
  • Actions run: https://github.com/openclaw/openclaw/actions/runs/28799590806
  • fresh autoreview: no actionable findings

@vincentkoc vincentkoc self-assigned this Jul 6, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 6, 2026
@vincentkoc

Copy link
Copy Markdown
Member Author

Land-ready proof for 1bda48b68aa7ab12d25643a04cdb40daa8a7736b:

Known local proof gap: ui/src/pages/chat/chat-send.test.ts cannot resolve @openclaw/uirouter from this linked Codex worktree. The Testbox changed gate typechecked and linted the full UI surface successfully.

@vincentkoc
vincentkoc marked this pull request as ready for review July 6, 2026 14:49
@vincentkoc
vincentkoc merged commit 0ecfc52 into main Jul 6, 2026
122 of 126 checks passed
@vincentkoc
vincentkoc deleted the refactor/deadcode-full-sweep-20260706-v11 branch July 6, 2026 15:04
@vincentkoc

Copy link
Copy Markdown
Member Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(ui): remove stale internal type exports

1 participant