Skip to content

test: align shifted main assertions#100897

Merged
vincentkoc merged 1 commit into
mainfrom
qa-sre-main-gwt-20260706a
Jul 6, 2026
Merged

test: align shifted main assertions#100897
vincentkoc merged 1 commit into
mainfrom
qa-sre-main-gwt-20260706a

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

  • Align Codex Skill Workshop prompt assertions with the current compact routing contract.
  • Stabilize the channel startup handoff test so stop wins without waiting for the stop-timeout path.
  • Update the chat tool-card assertion to check the stable expanded body contract.

Verification

  • Testbox: focused server-channels, chat-tool-cards, and Codex thread-lifecycle tests passed.
  • Testbox: gateway suite passed after the handoff test returned to ~111ms.
  • Testbox: UI unit + UI E2E passed.
  • Testbox: Codex/ACP broad serial lane passed.
  • Testbox: pnpm check:changed passed on main c421143 and again after rebasing onto 5cd71db.
  • Autoreview: commit-mode autoreview on the rebased commit reported no accepted/actionable findings.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui gateway Gateway runtime extensions: codex size: S maintainer Maintainer-authored PR labels Jul 6, 2026
@vincentkoc
vincentkoc force-pushed the qa-sre-main-gwt-20260706a branch from a1b56c2 to fa44268 Compare July 6, 2026 13:15
@clawsweeper

clawsweeper Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 6, 2026, 10:07 AM ET / 14:07 UTC.

Summary
The PR updates three tests to assert the compact Skill Workshop prompt, deferred channel startup handoff behavior, and expanded chat tool-card body content.

PR surface: Tests +2. Total +2 across 3 files.

Reproducibility: not applicable. this is a test-alignment PR, not a bug report with a current-main failure path. Source inspection shows the assertions target existing contracts rather than a new runtime behavior.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P2] No repair lane is needed because review found no narrow defect for automation to fix, and the remaining handling is normal maintainer draft/merge workflow.

Security
Cleared: The diff is limited to test assertions and a test helper option, with no dependency, workflow, script, credential, package, or runtime security surface changes.

Review details

Best possible solution:

Keep the narrow test-alignment PR open for normal maintainer readiness and merge handling once it is no longer draft and required checks are acceptable.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a test-alignment PR, not a bug report with a current-main failure path. Source inspection shows the assertions target existing contracts rather than a new runtime behavior.

Is this the best way to solve the issue?

Yes: updating the narrow tests is the best fix shape because the production prompt, gateway handoff, and tool-card rendering contracts already exist on current main. No broader refactor or compatibility path is needed for this diff.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against cd25de98b1b9.

Label changes

Label changes:

  • add P3: This is a low-risk maintainer test-alignment PR with no runtime, config, migration, or user-facing behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external contributor proof gate is not applicable to this maintainer-labeled MEMBER draft; the PR body still lists focused Testbox, gateway, UI, Codex/ACP, and check:changed validation.

Label justifications:

  • P3: This is a low-risk maintainer test-alignment PR with no runtime, config, migration, or user-facing behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external contributor proof gate is not applicable to this maintainer-labeled MEMBER draft; the PR body still lists focused Testbox, gateway, UI, Codex/ACP, and check:changed validation.
Evidence reviewed

PR surface:

Tests +2. Total +2 across 3 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 3 28 26 +2
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 3 28 26 +2

What I checked:

Likely related people:

  • vincentkoc: Current-main blame and git log tie the central prompt, gateway handoff, and tool-card renderer lines to 17777b3 and nearby refactor work authored by this contributor. (role: recent area contributor; confidence: high; commits: 17777b3a9ff1, 6418e196b123; files: src/agents/skill-workshop-prompt.ts, src/gateway/server-channels.ts, ui/src/pages/chat/components/chat-tool-cards.ts)
  • steipete: Merged PR perf(agents): slim Skill Workshop prompt section to its routing contract #100481 intentionally slimmed the Skill Workshop prompt section to the routing contract that this PR now asserts. (role: feature owner for compact prompt contract; confidence: medium; commits: 47ce4522b6ed; files: src/agents/skill-workshop-prompt.ts, src/agents/tools/skill-workshop-tool.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@vincentkoc
vincentkoc force-pushed the qa-sre-main-gwt-20260706a branch 3 times, most recently from 7dd6242 to 117ecde Compare July 6, 2026 13:58
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 6, 2026
@vincentkoc
vincentkoc force-pushed the qa-sre-main-gwt-20260706a branch from 117ecde to abcec6e Compare July 6, 2026 14:10
@vincentkoc
vincentkoc marked this pull request as ready for review July 6, 2026 14:23
@vincentkoc

Copy link
Copy Markdown
Member Author

Verification before landing:

  • Rebased repeatedly as origin/main moved; final pushed head: abcec6e5f22, based on 3442a8e6f5d.
  • check:changed: Testbox tbx_01kwvw9q7tmx1kvvmfp4w3q0y3, Actions run 28797914051, exit 0. Selected lanes: coreTests, extensionTests.
  • Focused tests after the large gateway/UI/session base shift: Testbox tbx_01kwvtven120rzq4mt93qmcwjw, Actions run 28796260180, exit 0. Passed src/gateway/server-channels.test.ts (90 tests), ui/src/pages/chat/components/chat-tool-cards.test.ts (27 tests), and extensions/codex/src/app-server/thread-lifecycle.test.ts (77 tests).
  • Autoreview on final head: clean, no accepted/actionable findings.
  • PR checks: green at latest pushed head before merge attempt.

@vincentkoc
vincentkoc merged commit 94a0d2e into main Jul 6, 2026
141 of 142 checks passed
@vincentkoc
vincentkoc deleted the qa-sre-main-gwt-20260706a branch July 6, 2026 14:24
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 7, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui extensions: codex gateway Gateway runtime maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant