Skip to content

fix(android): add missing new_chat_in_worktree locale strings#100805

Merged
amknight merged 1 commit into
mainfrom
fix/android-i18n-locale-alignment
Jul 6, 2026
Merged

fix(android): add missing new_chat_in_worktree locale strings#100805
amknight merged 1 commit into
mainfrom
fix/android-i18n-locale-alignment

Conversation

@amknight

@amknight amknight commented Jul 6, 2026

Copy link
Copy Markdown
Member

What Problem This Solves

Unbreaks main CI: test/scripts/android-app-i18n.test.ts ("keeps every native
locale resource key aligned with English") fails on main because #100788 added
the new_chat_in_worktree string to the English Android resources only. Every
whole-suite test shard (checks-node-compact-*-whole-*) on every open PR is
currently red because of it.

Why This Change Was Made

The native i18n pipeline already produced the translations: the locale-refresh
workflow committed them to the translation-memory artifacts
(apps/.i18n/native/*.json) in 24bca38. But those artifacts are a handoff —
the Android resource files are owned by the app slice and still lacked the key.
This PR materializes the artifact translations into all 21
values-*/strings.xml files, inserted at the same position as the English
entry.

All values come verbatim from the translation-memory artifacts (matched on the
android surface + exact source text "New chat in worktree"), with Android
resource escaping applied (e.g. Turkish Worktree\'de yeni sohbet).

User Impact

Android users get a localized "New chat in worktree" label in all supported
locales instead of a build/test break. Repo-wide: whole-suite CI shards go
green again.

Evidence

  • node scripts/run-vitest.mjs run test/scripts/android-app-i18n.test.ts
    2/2 pass (was failing with missing=new_chat_in_worktree for all 21
    locales).
  • The checker also validates placeholder parity and Android apostrophe
    escaping; both pass (the string has no format placeholders; the one
    apostrophe, in Turkish, is escaped).
  • Complements fix(ci): repair managed worktree follow-up gates #100793, which fixes the remaining main breakages from the same
    merge window (gateway-protocol unused type exports + stale docs map). This
    PR's own docs/lint/prod-types checks will stay red until that lands; the two
    PRs touch disjoint files.

@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: XS maintainer Maintainer-authored PR labels Jul 6, 2026
@amknight
amknight merged commit 7f29380 into main Jul 6, 2026
62 of 67 checks passed
@amknight
amknight deleted the fix/android-i18n-locale-alignment branch July 6, 2026 10:03
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 7, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant