fix(android): add missing new_chat_in_worktree locale strings#100805
Merged
Conversation
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
…aw#100805) Co-authored-by: Alex Knight <[email protected]>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
…aw#100805) Co-authored-by: Alex Knight <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Unbreaks main CI:
test/scripts/android-app-i18n.test.ts("keeps every nativelocale resource key aligned with English") fails on main because #100788 added
the
new_chat_in_worktreestring to the English Android resources only. Everywhole-suite test shard (
checks-node-compact-*-whole-*) on every open PR iscurrently red because of it.
Why This Change Was Made
The native i18n pipeline already produced the translations: the locale-refresh
workflow committed them to the translation-memory artifacts
(
apps/.i18n/native/*.json) in 24bca38. But those artifacts are a handoff —the Android resource files are owned by the app slice and still lacked the key.
This PR materializes the artifact translations into all 21
values-*/strings.xmlfiles, inserted at the same position as the Englishentry.
All values come verbatim from the translation-memory artifacts (matched on the
android surface + exact source text "New chat in worktree"), with Android
resource escaping applied (e.g. Turkish
Worktree\'de yeni sohbet).User Impact
Android users get a localized "New chat in worktree" label in all supported
locales instead of a build/test break. Repo-wide: whole-suite CI shards go
green again.
Evidence
node scripts/run-vitest.mjs run test/scripts/android-app-i18n.test.ts→2/2 pass (was failing with
missing=new_chat_in_worktreefor all 21locales).
escaping; both pass (the string has no format placeholders; the one
apostrophe, in Turkish, is escaped).
merge window (gateway-protocol unused type exports + stale docs map). This
PR's own docs/lint/prod-types checks will stay red until that lands; the two
PRs touch disjoint files.