fix(update): guard Windows task autostart during package updates#100757
Merged
Conversation
openclaw-barnacle
Bot
added
gateway
openclaw-barnacle
Bot
added
docs
github-actions
Bot
added
the
dependencies-changed
Contributor
Dependency graph guard clearedThis PR no longer has blocked dependency graph changes. A future dependency graph change requires a fresh
|
Co-authored-by: Vincent Koc <[email protected]>
steipete
force-pushed
the
codex/pr-88292-replay
branch
from
July 6, 2026 09:20
73c88f5 to
e685938
Compare
openclaw-barnacle
Bot
removed
docs
openclaw-barnacle
Bot
removed
app: android
github-actions
Bot
removed
the
dependencies-changed
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(update): guard Windows task autostart during package updates This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Land-ready maintainer replay of #88292. What changed:
Proof on prepared head
Known gap: the live Windows proof exercised task-state suspension/restoration and locale-independent existence probing, not a destructive real global package replacement. Exact-head CI and hosted build cover the package-update integration paths. |
Contributor
Author
|
Merged via squash.
|
This was referenced Jul 6, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 7, 2026
…nclaw#100757) * fix(update): guard Windows task autostart Co-authored-by: Vincent Koc <[email protected]> * fix(update): preserve recovery error causes * fix(update): retain restore failure causes * fix(update): recover task on Ctrl+Break * chore(update): document aggregate lint intent * fix(update): tolerate deleted Windows tasks * fix(update): preserve combined recovery failures * fix(update): preserve aggregate error causes * fix(update): construct aggregate causes consistently --------- Co-authored-by: Vincent Koc <[email protected]>
giodl73-repo
pushed a commit
to giodl73-repo/openclaw
that referenced
this pull request
Jul 8, 2026
…nclaw#100757) * fix(update): guard Windows task autostart Co-authored-by: Vincent Koc <[email protected]> * fix(update): preserve recovery error causes * fix(update): retain restore failure causes * fix(update): recover task on Ctrl+Break * chore(update): document aggregate lint intent * fix(update): tolerate deleted Windows tasks * fix(update): preserve combined recovery failures * fix(update): preserve aggregate error causes * fix(update): construct aggregate causes consistently --------- Co-authored-by: Vincent Koc <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Legacy Windows Gateway Scheduled Tasks can contain a
PT3Mrepetition trigger. During a package update, stopping the running Gateway does not prevent that trigger from relaunching it while npm is replacing the package tree.Fixes #87993. Replays and supersedes #88292 while preserving @vincentkoc's authorship.
Why This Change Was Made
Package updates now suspend only an enabled managed Scheduled Task before service or package mutation, retain that state through post-core work, and restore the original enabled state before restart, recovery, error return, or signal exit. Already-disabled tasks stay disabled; deleted tasks are treated as absent through a locale-independent Task Scheduler COM result; ambiguous query or mutation failures fail closed.
The replay also coordinates task restoration with the CLI's existing signal cleanup so Ctrl+C, Ctrl+Break, and proxy shutdown cannot race package mutation or lose the original failure. Git update behavior and non-Windows platforms remain unchanged.
User Impact
Windows package updates no longer risk a repeated Scheduled Task relaunching the Gateway against a partially replaced installation. Existing operator-disabled tasks are preserved, and stale gateway scripts without a Scheduled Task no longer block updates.
Evidence
CHANGELOG.md; the seven code commits range-diff identically, followed by a second green focused suite and changed-gate run.