fix: silence heartbeat notify=false fallback replies by Hackerismydream · Pull Request #100735 · openclaw/openclaw

Hackerismydream · 2026-07-06T08:03:44Z

What Problem This Solves

Fixes an issue where Telegram heartbeat fallback replies could expose a trailing standalone notify=false control marker as user-visible message text and still deliver the message as a normal notification.

Why This Change Was Made

This keeps the fix at the heartbeat fallback boundary instead of parsing Telegram transport text. Plain fallback replies now consume only a final standalone notify=false line, forward the existing durable-send silent metadata, suppress marker-only replies, and preserve inline notify=false text.

User Impact

Users no longer see notify=false appended to Telegram heartbeat fallback replies. When a fallback reply includes that final control marker, OpenClaw sends the remaining message silently through the existing Telegram disable_notification path.

Evidence

Mantis native Telegram Desktop proof passed for head 496436a93b18cfa540e38adbcb53e1445306dc4e: https://github.com/openclaw/openclaw/actions/runs/28779391086
- Artifact: https://github.com/openclaw/openclaw/actions/runs/28779391086/artifacts/8105380192
- Published before/after screenshots, GIFs, MP4 clips, and raw QA manifest: https://artifacts.openclaw.ai/mantis/telegram-desktop/pr-100735/run-28779391086-1/index.json
node scripts/run-vitest.mjs src/infra/heartbeat-runner.tool-response.test.ts src/infra/heartbeat-runner.ghost-reminder.test.ts src/infra/heartbeat-events-filter.test.ts extensions/telegram/src/outbound-adapter.test.ts src/channels/message/send.test.ts
Passed: 4 Vitest shards, 130 tests.
node scripts/run-vitest.mjs src/infra/outbound/payloads.test.ts extensions/telegram/src/bot/delivery.test.ts
Passed: 2 Vitest shards, 102 tests.
node scripts/run-vitest.mjs src/infra/heartbeat-runner.tool-response.test.ts
Passed after formatting: 1 Vitest shard, 21 tests.
node_modules/.bin/oxfmt --check --threads=1 src/infra/heartbeat-runner.ts src/infra/heartbeat-runner.tool-response.test.ts test/helpers/infra/heartbeat-runner-channel-plugins.ts passed.
git diff --check passed.
.agents/skills/autoreview/scripts/autoreview --mode local passed clean: no accepted/actionable findings.

Earlier remote/Testbox local-launch gap is now covered by the Mantis native Telegram Desktop proof above. The local Crabbox wrapper in this checkout still fails basic version/help sanity checks before project code, but the required Telegram-visible behavior proof exists in the hosted Mantis run.

Hackerismydream · 2026-07-06T08:22:59Z

Verification update for head 496436a93b18cfa540e38adbcb53e1445306dc4e:

GitHub PR checks completed with no failing checks reported by gh pr checks 100735: 66 success, 35 skipped, 1 neutral.
Local fallback validation passed because the configured Crabbox/Testbox binary failed its own --version/--help sanity check before project code ran:
- node scripts/run-vitest.mjs src/infra/heartbeat-runner.tool-response.test.ts src/infra/heartbeat-runner.ghost-reminder.test.ts src/infra/heartbeat-events-filter.test.ts extensions/telegram/src/outbound-adapter.test.ts src/channels/message/send.test.ts
- node scripts/run-vitest.mjs src/infra/outbound/payloads.test.ts extensions/telegram/src/bot/delivery.test.ts
- node scripts/run-vitest.mjs src/infra/heartbeat-runner.tool-response.test.ts
- node_modules/.bin/oxfmt --check --threads=1 src/infra/heartbeat-runner.ts src/infra/heartbeat-runner.tool-response.test.ts test/helpers/infra/heartbeat-runner-channel-plugins.ts
- git diff --check
- .agents/skills/autoreview/scripts/autoreview --mode local

Known proof gap remains only the live Crabbox/native Telegram scenario, blocked by the local Crabbox binary sanity failure before it could launch a remote run.

clawsweeper · 2026-07-06T08:41:25Z

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head bbfd1c75ba7be592eb47ffc94052403c543de428, but the PR head is now f9da0508b94800dc018b08df0027d11b2a84aa5a. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

Review history (1 earlier review cycle)

reviewed 2026-07-06T08:46:40.769Z sha 496436a :: needs real behavior proof before merge. :: none

Hackerismydream · 2026-07-06T09:18:04Z

Thanks, the remaining blocker is understood: this needs real Telegram-visible proof rather than more unit coverage.

I don’t have access to the Mantis/native Telegram proof environment from this contributor branch. Could a maintainer please run:

@openclaw-mantis telegram desktop proof: verify that a heartbeat fallback ending in notify=false sends no visible marker and capture evidence of the silent delivery path.

The PR head is 496436a. Existing CI and focused tests are green; the missing proof is specifically the Telegram-visible marker/silent-delivery path.

openclaw-mantis · 2026-07-06T09:47:41Z

Mantis Telegram Desktop Proof

Summary: Mantis captured native Telegram Desktop before/after GIF evidence for heartbeat fallback replies.

Scenario: telegram-desktop-proof
Trigger: pull_request_target
Run: https://github.com/openclaw/openclaw/actions/runs/28779391086
Artifact: https://github.com/openclaw/openclaw/actions/runs/28779391086/artifacts/8105380192
Baseline: pass at 535ab05dcd885908a062819f7140f8584614e0ed, expected baseline visual proof captured
Candidate: pass at 496436a93b18cfa540e38adbcb53e1445306dc4e, expected candidate visual proof captured
Overall: true

Main screenshot	This PR screenshot

Main	This PR

Motion-trimmed clips:

Raw QA files: https://artifacts.openclaw.ai/mantis/telegram-desktop/pr-100735/run-28779391086-1/index.json

Hackerismydream · 2026-07-06T09:50:32Z

Mantis native Telegram Desktop proof is now included in the PR body.

@clawsweeper re-review

clawsweeper · 2026-07-06T09:50:34Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Hackerismydream · 2026-07-06T09:57:12Z

Head moved to ba16b82 with Vincent's follow-up commit, and the new head checks are green. Mantis proof remains linked in the PR body for the previous candidate; please re-review the current head and call out if fresh Mantis proof is required for the follow-up change.

@clawsweeper re-review

clawsweeper · 2026-07-06T09:57:15Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

vincentkoc · 2026-07-06T10:50:30Z

Maintainer validation is complete for head f9da0508b94800dc018b08df0027d11b2a84aa5a.

Blacksmith Testbox tbx_01kwvckk5633zxs88mhjeqd3z8: pnpm test:serial src/infra/heartbeat-runner.tool-response.test.ts passed 21/21.
The same Testbox passed the scoped changed gate, including production/test types, lint, import cycles, and repository guards.
Native Telegram Mantis run 28779391086 passed baseline and candidate with screenshot, GIF, MP4, and manifest evidence: https://github.com/openclaw/openclaw/actions/runs/28779391086
Published proof artifacts: fix: silence heartbeat notify=false fallback replies #100735 (comment)
Fresh final-head autoreview: clean, no accepted/actionable findings, confidence 0.86.
Final exact-head CI run 28785517777: green, including QA Smoke CI: https://github.com/openclaw/openclaw/actions/runs/28785517777

The maintainer fix also covers the marker-only showOk=true edge case, so notify=false cannot turn into a visible HEARTBEAT_OK reply.

* fix(heartbeat): consume trailing notify=false fallback marker * fix(heartbeat): keep notify=false marker fully silent --------- Co-authored-by: martin <[email protected]> Co-authored-by: Vincent Koc <[email protected]>

openclaw-barnacle Bot added the size: S label Jul 6, 2026

clawsweeper Bot temporarily deployed to qa-live-shared July 6, 2026 09:01 Inactive

vincentkoc mentioned this pull request Jul 6, 2026

fix(heartbeat): strip trailing notify=false marker on text-fallback path #100777

Closed

6 tasks

vincentkoc self-assigned this Jul 6, 2026

vincentkoc force-pushed the codex/fix-heartbeat-notify-false-marker branch 2 times, most recently from 78a37a5 to ba16b82 Compare July 6, 2026 09:53

vincentkoc force-pushed the codex/fix-heartbeat-notify-false-marker branch from ba16b82 to bbfd1c7 Compare July 6, 2026 10:23

martin and others added 2 commits July 6, 2026 03:37

fix(heartbeat): consume trailing notify=false fallback marker

8f427b1

fix(heartbeat): keep notify=false marker fully silent

f9da050

vincentkoc force-pushed the codex/fix-heartbeat-notify-false-marker branch from bbfd1c7 to f9da050 Compare July 6, 2026 10:37

vincentkoc merged commit 8f29862 into openclaw:main Jul 6, 2026
103 of 107 checks passed

clawsweeper Bot mentioned this pull request Jul 6, 2026

fix(heartbeat): catch delivery errors in maybeSendHeartbeatOk to prevent side-effect replays #100834

Merged

github-actions Bot mentioned this pull request Jul 6, 2026

📡 Upstream Digest — 2026-07-06 13:38 UTC curtismercier/openclaw-mods#1222

Open

clawsweeper Bot mentioned this pull request Jul 6, 2026

fix(docs): expose top-level docs hubs on mobile #100908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: silence heartbeat notify=false fallback replies#100735

fix: silence heartbeat notify=false fallback replies#100735
vincentkoc merged 2 commits into
openclaw:mainfrom
Hackerismydream:codex/fix-heartbeat-notify-false-marker

Hackerismydream commented Jul 6, 2026 •

edited

Loading

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

openclaw-mantis Bot commented Jul 6, 2026

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

vincentkoc commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Hackerismydream commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

openclaw-mantis Bot commented Jul 6, 2026

Mantis Telegram Desktop Proof

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hackerismydream commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hackerismydream commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading