Skip to content

test(release): match pinned Claude CLI setup#100723

Merged
steipete merged 1 commit into
mainfrom
verify/pr100650-main-baseline
Jul 6, 2026
Merged

test(release): match pinned Claude CLI setup#100723
steipete merged 1 commit into
mainfrom
verify/pr100650-main-baseline

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Current main pins the Docker ACP bind Claude CLI to the version declared by the installed Claude Agent SDK, but the package-acceptance test still expects the retired unversioned install command. This breaks the compact tooling CI shard.

Why This Change Was Made

Update the assertion to match the existing version-pinned command. Production behavior is unchanged.

User Impact

None. This repairs current-main test coverage and unblocks unrelated pull requests from the baseline CI failure.

Evidence

  • node scripts/run-vitest.mjs test/scripts/package-acceptance-workflow.test.ts
  • ./node_modules/.bin/oxfmt --check test/scripts/package-acceptance-workflow.test.ts
  • git diff --check
  • Codex autoreview: clean, zero findings

@vincentkoc
vincentkoc marked this pull request as ready for review July 6, 2026 07:33
@vincentkoc vincentkoc self-assigned this Jul 6, 2026
@openclaw-barnacle openclaw-barnacle Bot added agents Agent runtime and tooling size: L and removed size: M labels Jul 6, 2026
@steipete
steipete force-pushed the verify/pr100650-main-baseline branch from d257eac to 56d72d4 Compare July 6, 2026 07:39
@openclaw-barnacle openclaw-barnacle Bot added size: XS and removed gateway Gateway runtime agents Agent runtime and tooling extensions: openai size: L labels Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Land-ready maintainer proof for exact head 56d72d4add03ba629ff76d033702c1c3603df8a7:

  • Rewritten from nine mixed files to the single stale package-acceptance assertion; contributor credit is preserved.
  • Current main pins the Claude CLI to the SDK-declared version, and the test now asserts that exact command.
  • Before: exact-head CI runs 28775036594 and 28775035258 both failed checks-node-compact-small-whole-2 on the retired unversioned string.
  • After: exact-head CI run 28775679166 is green, including checks-node-compact-small-whole-2.
  • oxfmt --check and git diff --check: pass. Review artifacts validate with no findings.

Production behavior is unchanged; this restores current-main CI truth and unblocks unrelated reviewed PRs.

@steipete
steipete merged commit bfdd60b into main Jul 6, 2026
82 of 86 checks passed
@steipete
steipete deleted the verify/pr100650-main-baseline branch July 6, 2026 07:53
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Merged via squash.

@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Land-ready after maintainer rewrite.

  • Rebased onto current main and removed the contaminated second commit; final diff is one expectation line in test/scripts/package-acceptance-workflow.test.ts.
  • Before proof on main: node scripts/run-vitest.mjs test/scripts/package-acceptance-workflow.test.ts — 40 passed, 1 failed on the stale unpinned Claude Code command.
  • After proof on PR head: same command — 41 passed.
  • Exact-head hosted CI: 44 jobs passed, including both broad compact shards and QA smoke: https://github.com/openclaw/openclaw/actions/runs/28775679166
  • Wrapper review artifacts validate with zero findings; prepare-run completed for 56d72d4add03ba629ff76d033702c1c3603df8a7.

No known proof gaps for this test-only correction. Thanks @vincentkoc.

@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Merged via squash.

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 6, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants