test(plugins): register workboard typed hook contract#100614
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b0cc55d39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Fixes | ||
|
|
||
| - **Control UI managed worktrees:** keep the existing customizable pinned sidebar intact while exposing the new Worktrees route through its canonical navigation inventory. |
There was a problem hiding this comment.
Remove the direct-fix changelog entry
This is a one-off UI fix commit, but the root AGENTS.md says CHANGELOG.md is release-only and normal/direct fixes should carry release-note context in the PR or commit instead. Leaving this Unreleased row makes release generation prone to double-counting or conflicting with the generated changelog, so please drop the entry and let the release tooling derive it.
Useful? React with 👍 / 👎.
4b0cc55 to
a38744f
Compare
|
Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 1:11 AM ET / 05:11 UTC. Summary PR surface: Tests +2. Total +2 across 1 file. Reproducibility: yes. Source inspection gives a high-confidence reproduction: current main scans all bundled production plugin files for Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Merge the narrow inventory update after exact-head required checks finish, then let the linked issue close through this PR or an equivalent landed fix. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection gives a high-confidence reproduction: current main scans all bundled production plugin files for Is this the best way to solve the issue? Yes. The narrow inventory update is the best fix because the hook is valid and already intentional; removing the hook or weakening the invariant would either change Workboard cleanup behavior or reduce the contract test's value. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d5371395218c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +2. Total +2 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by #100611, which landed the same two-line Workboard typed-hook inventory fix as Closing this duplicate; no unique code remains here. |
|
Superseded by #100611, merged as That commit applies the same two-line Workboard typed-hook contract registration in |
Closes #100613
What Problem This Solves
Fixes the remaining managed-worktrees merge regression where the Workboard plugin's new
subagent_endedhook is rejected by the explicit typed-hook contract inventory, keeping current-main CI and rebased pull requests red.Why This Change Was Made
Adds the existing Workboard registration file and its exact hook name to the canonical inventory. The Control UI navigation half of #100613 was independently fixed by
55a0012c44b52af2f22982cc85568e6e5d0df5c7, so this branch deliberately drops its superseded UI rewrite.User Impact
No runtime behavior changes. Repository contract checks now recognize the managed-worktree cleanup hook that already runs in Workboard.
Evidence
d5371395218c0f88318656502a2c471aab21b596.tbx_01kwtwyv7y2f25b1b8hkynew9g(jade-crab), run https://github.com/openclaw/openclaw/actions/runs/28769016840:pnpm test src/plugins/contracts/boundary-invariants.test.tspassed all 14 tests.git diff --checkand targetedoxfmt --check: passed.