Skip to content

test(plugins): register workboard typed hook contract#100614

Closed
steipete wants to merge 1 commit into
mainfrom
codex/fix-managed-worktree-merge-gates
Closed

test(plugins): register workboard typed hook contract#100614
steipete wants to merge 1 commit into
mainfrom
codex/fix-managed-worktree-merge-gates

Conversation

@steipete

@steipete steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Closes #100613

What Problem This Solves

Fixes the remaining managed-worktrees merge regression where the Workboard plugin's new subagent_ended hook is rejected by the explicit typed-hook contract inventory, keeping current-main CI and rebased pull requests red.

Why This Change Was Made

Adds the existing Workboard registration file and its exact hook name to the canonical inventory. The Control UI navigation half of #100613 was independently fixed by 55a0012c44b52af2f22982cc85568e6e5d0df5c7, so this branch deliberately drops its superseded UI rewrite.

User Impact

No runtime behavior changes. Repository contract checks now recognize the managed-worktree cleanup hook that already runs in Workboard.

Evidence

@steipete steipete self-assigned this Jul 6, 2026
@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b0cc55d39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated

### Fixes

- **Control UI managed worktrees:** keep the existing customizable pinned sidebar intact while exposing the new Worktrees route through its canonical navigation inventory.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the direct-fix changelog entry

This is a one-off UI fix commit, but the root AGENTS.md says CHANGELOG.md is release-only and normal/direct fixes should carry release-note context in the PR or commit instead. Leaving this Unreleased row makes release generation prone to double-counting or conflicting with the generated changelog, so please drop the entry and let the release tooling derive it.

Useful? React with 👍 / 👎.

@steipete
steipete force-pushed the codex/fix-managed-worktree-merge-gates branch from 4b0cc55 to a38744f Compare July 6, 2026 05:04
@openclaw-barnacle openclaw-barnacle Bot added size: XS and removed app: web-ui App: web-ui size: S labels Jul 6, 2026
@steipete steipete changed the title fix(ui): restore managed worktree sidebar contract test(plugins): register workboard typed hook contract Jul 6, 2026
@clawsweeper

clawsweeper Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 1:11 AM ET / 05:11 UTC.

Summary
The PR adds Workboard's existing hook registration file and subagent_ended hook to the plugin boundary invariant test inventory.

PR surface: Tests +2. Total +2 across 1 file.

Reproducibility: yes. Source inspection gives a high-confidence reproduction: current main scans all bundled production plugin files for api.on(...) and compares them to an explicit list that omits Workboard, while Workboard registers api.on("subagent_ended"); I did not run tests in this read-only review.

Review metrics: none identified.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #100613
Summary: This PR is the current candidate fix for the Workboard typed-hook inventory half of the linked regression; the earlier broader UI-plus-Workboard PR is closed unmerged and not a safe canonical replacement.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P1] No repair lane is needed: no actionable patch defect was found, and this maintainer-labeled PR should proceed through normal maintainer merge and exact-head CI handling.

Security
Cleared: The diff only updates a test allowlist and does not alter workflows, dependencies, lockfiles, secrets, runtime execution, or package metadata.

Review details

Best possible solution:

Merge the narrow inventory update after exact-head required checks finish, then let the linked issue close through this PR or an equivalent landed fix.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection gives a high-confidence reproduction: current main scans all bundled production plugin files for api.on(...) and compares them to an explicit list that omits Workboard, while Workboard registers api.on("subagent_ended"); I did not run tests in this read-only review.

Is this the best way to solve the issue?

Yes. The narrow inventory update is the best fix because the hook is valid and already intentional; removing the hook or weakening the invariant would either change Workboard cleanup behavior or reduce the contract test's value.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against d5371395218c.

Label changes

Label changes:

  • add P2: The PR fixes a deterministic current-main plugin contract regression for contributor validation, but the diff is narrow and has no runtime behavior, data, auth, or message-delivery blast radius.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a maintainer-labeled test-only PR, so the contributor real-behavior proof gate does not apply; the PR body still cites Testbox contract-test output for the changed check.

Label justifications:

  • P2: The PR fixes a deterministic current-main plugin contract regression for contributor validation, but the diff is narrow and has no runtime behavior, data, auth, or message-delivery blast radius.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a maintainer-labeled test-only PR, so the contributor real-behavior proof gate does not apply; the PR body still cites Testbox contract-test output for the changed check.
Evidence reviewed

PR surface:

Tests +2. Total +2 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 2 0 +2
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 1 2 0 +2

What I checked:

Likely related people:

  • steipete: Git blame ties both the Workboard subagent_ended registration and the current typed-hook inventory constants to Peter Steinberger, and the PR is also assigned to steipete. (role: introduced behavior and recent area contributor; confidence: high; commits: 0acd851a3b3d, d2d5911c3296; files: extensions/workboard/index.ts, src/plugins/contracts/boundary-invariants.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #100611, which landed the same two-line Workboard typed-hook inventory fix as 06fbd84d2b1 and restored the failing contributor checks on main.

Closing this duplicate; no unique code remains here.

@steipete steipete closed this Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #100611, merged as 06fbd84d2b1a61c665f39f7da633df0157d03ed8.

That commit applies the same two-line Workboard typed-hook contract registration in src/plugins/contracts/boundary-invariants.test.ts. I verified the canonical commit is identical to this PR's prepared diff, so there is no remaining change to land here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control UI sidebar contract breaks after managed-worktrees merge

1 participant