Skip to content

refactor(ui): consolidate sidebar navigation contract#100612

Merged
steipete merged 2 commits into
mainfrom
codex/fix-sidebar-navigation-exports
Jul 6, 2026
Merged

refactor(ui): consolidate sidebar navigation contract#100612
steipete merged 2 commits into
mainfrom
codex/fix-sidebar-navigation-exports

Conversation

@steipete

@steipete steipete commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Problem This Solves

Current main builds again after the emergency export restoration in 55a0012c44b, but it now carries two sidebar navigation models: the section API introduced by #100535 and the customizable route contract consumed by the sidebar and settings flows. The section API has no production consumer and duplicates route policy.

Why This Change Was Made

Keep one canonical customizable-sidebar contract instead of retaining aliases around an unused model. The route list, persisted pin normalization, default pins, and derived More menu share one owner. Worktrees remains a normal pinnable route and is exercised through the existing browser persistence flow.

User Impact

No new product contract beyond the already-landed sidebar and Worktrees features. Users can pin Worktrees from Customize sidebar and retain that choice across reloads; maintainers have one typed route policy instead of two competing models.

Evidence

  • Provenance: feat: automatic managed git worktrees for agent tasks (create, snapshot, restore, GC) #100535 overwrote feat(ui): make the sidebar session-first and minimal #100386’s customizable exports; 55a0012c44b restored the missing exports and build, leaving the unused section API alongside them.
  • Blacksmith Testbox tbx_01kwtv7wj41ka3fybn46qhbrv7: 57/57 navigation and settings tests passed.
  • Same Testbox: production UI build passed; 998 modules transformed and the Worktrees chunk emitted.
  • Same Testbox: 3/3 Chromium E2Es passed, including real Worktrees pin/reload persistence, update coalescing, and stale-module mount recovery.
  • Same Testbox: 18/18 PTY scenarios and exact changed-gate passed.
  • Fresh branch AutoReview: no accepted/actionable findings.
  • Final rebased head 9c8c48868bc40e63c8712d8262a14e3e5b72fcc1: Blacksmith Testbox tbx_01kwtxvd6n9vkdjxa2has3g3h8 passed 57/57 navigation/settings tests and the production UI build (998 modules, Worktrees chunk emitted); run 28769594466.
  • Final branch AutoReview: clean, confidence 0.83; focused duplicate-removal AutoReview: clean, confidence 0.89.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: S maintainer Maintainer-authored PR labels Jul 6, 2026
@steipete steipete changed the title fix(ui): restore sidebar navigation contract refactor(ui): consolidate sidebar navigation contract Jul 6, 2026
@clawsweeper

clawsweeper Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 1:10 AM ET / 05:10 UTC.

Summary
The branch removes the unused sidebar section model, makes the customizable sidebar route list the canonical contract, updates navigation tests, and extends the sidebar E2E to prove Worktrees pin persistence across reloads.

PR surface: Source +19, Tests +17. Total +36 across 4 files.

Reproducibility: not applicable. as a refactor; there is no user-facing bug path to reproduce in this PR. Source inspection does confirm current main carries both the section model and the pinned-route model.

Review metrics: none identified.

Root-cause cluster
Relationship: partial_overlap
Canonical: #100613
Summary: This PR addresses the UI navigation-contract portion of the post-worktrees regression, while the canonical issue also includes the remaining Workboard typed-hook allowlist failure.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Resolve or base on the Workboard typed-hook allowlist fix so the exact-head checks-fast-contracts-plugins-a gate passes before merge.

Risk before merge

Maintainer options:

  1. Decide the mitigation before merge
    Keep one canonical customizable-sidebar route contract, and resolve the separate Workboard typed-hook allowlist failure in the same landing batch or a narrow prerequisite before merge.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] Maintainer should decide merge sequencing because the UI cleanup is sound but the related Workboard typed-hook contract failure remains outside this branch.

Maintainer decision needed

  • Question: Should this PR stay scoped to the UI navigation-contract consolidation, or should it absorb the Workboard typed-hook allowlist fix needed for the related CI regression?
  • Rationale: The UI diff is coherent, but the exact head still fails a non-UI contract gate that belongs to the broader regression tracked in Control UI sidebar contract breaks after managed-worktrees merge #100613.
  • Likely owner: steipete — They authored the current PR and the related sidebar/worktrees changes that define the desired landing shape.
  • Options:
    • Keep UI Scope And Land After Allowlist Fix (recommended): Keep this PR focused on the sidebar contract and merge it only after current main or the branch has the Workboard typed-hook allowlist repair.
    • Fold The Allowlist Fix Into This PR: Add the narrow extensions/workboard/index.ts typed-hook allowlist update here so this PR can close the broader regression in one merge.
    • Close In Favor Of A Broader Fix: Use a separate viable PR as the canonical repair if maintainers prefer one branch to fix both the UI exports and plugin contract inventory.

Security
Cleared: The patch only changes UI navigation code and tests, with no workflow, dependency, lockfile, script, credential, or security-boundary changes.

Review details

Best possible solution:

Keep one canonical customizable-sidebar route contract, and resolve the separate Workboard typed-hook allowlist failure in the same landing batch or a narrow prerequisite before merge.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a refactor; there is no user-facing bug path to reproduce in this PR. Source inspection does confirm current main carries both the section model and the pinned-route model.

Is this the best way to solve the issue?

Yes for the sidebar contract: removing the test-only section API is the narrow maintainable cleanup for the UI surface. It is not the complete solution for the broader regression tracked in #100613 because the Workboard hook allowlist still needs a separate fix.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against d5371395218c.

Label changes

Label changes:

  • add P2: This is a normal-priority maintainer cleanup tied to a current main validation regression, with limited UI/sidebar blast radius and no emergency user-facing failure shown.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The PR is maintainer-labeled, so the external contributor proof gate is not applied; the PR body still reports Testbox browser E2E and build evidence.

Label justifications:

  • P2: This is a normal-priority maintainer cleanup tied to a current main validation regression, with limited UI/sidebar blast radius and no emergency user-facing failure shown.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The PR is maintainer-labeled, so the external contributor proof gate is not applied; the PR body still reports Testbox browser E2E and build evidence.
Evidence reviewed

PR surface:

Source +19, Tests +17. Total +36 across 4 files.

View PR surface stats
Area Files Added Removed Net
Source 1 52 33 +19
Tests 3 48 31 +17
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 4 100 64 +36

What I checked:

Likely related people:

  • steipete: Authored the merged session-first sidebar work and the managed-worktrees merge that added the Worktrees route and changed the navigation surface. (role: feature owner and recent area contributor; confidence: high; commits: 60cf7eaa005b, 0acd851a3b3d; files: ui/src/app-navigation.ts, ui/src/components/app-sidebar.ts, ui/src/e2e/sidebar-customization.e2e.test.ts)
  • vincentkoc: Restored the missing sidebar navigation exports on current main after the managed-worktrees merge, creating the immediate duplicate contract this PR consolidates. (role: recent repair author; confidence: high; commits: 55a0012c44b5; files: ui/src/app-navigation.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 6, 2026
@steipete
steipete force-pushed the codex/fix-sidebar-navigation-exports branch from 76aa830 to 97a90a4 Compare July 6, 2026 05:15
@steipete
steipete merged commit 89f911f into main Jul 6, 2026
77 checks passed
@steipete
steipete deleted the codex/fix-sidebar-navigation-exports branch July 6, 2026 05:30
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 6, 2026
@steipete
refactor(ui): consolidate sidebar navigation contract (openclaw#100612)
999b0a3 
* fix(ui): restore sidebar navigation contract

* refactor(ui): remove duplicate sidebar navigation model
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
@steipete @giodl73-repo
refactor(ui): consolidate sidebar navigation contract (openclaw#100612)
da1cac1 
* fix(ui): restore sidebar navigation contract

* refactor(ui): remove duplicate sidebar navigation model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@steipete