test(plugins): register Workboard typed hook contract#100611
Conversation
a88742f to
e9f6bcf
Compare
|
Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 1:08 AM ET / 05:08 UTC. Summary PR surface: Tests +2. Total +2 across 1 file. Reproducibility: yes. Source inspection shows current main registers Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land one narrow allowlist update for the existing Workboard Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main registers Is this the best way to solve the issue? Yes for the code change itself. Updating both explicit allowlists is the narrowest maintainable fix because the runtime hook already exists and the contract intentionally fails closed on new bundled hook registrations. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d5371395218c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +2. Total +2 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
What Problem This Solves
Resolves a problem where current
mainfails the bundled-plugin contract suite after Workboard added its subagent cleanup hook.Why This Change Was Made
Registers Workboard’s existing typed
subagent_endedhook in both explicit boundary allowlists. This preserves the contract test’s fail-closed inventory without changing plugin runtime behavior.User Impact
No product behavior change. Plugin contract CI correctly recognizes the Workboard cleanup hook while continuing to reject unreviewed hook registrations or hook names.
Evidence
main:boundary-invariants.test.tsreportsextensions/workboard/index.tsas an unexpected typed-hook registration.api.on("subagent_ended", ...)inextensions/workboard/index.ts.git diff --checkpasses.