Skip to content

fix(ui): remove redundant file-preview Escape hint#100528

Merged
steipete merged 1 commit into
mainfrom
codex/pr-99029-file-preview-clean
Jul 6, 2026
Merged

fix(ui): remove redundant file-preview Escape hint#100528
steipete merged 1 commit into
mainfrom
codex/pr-99029-file-preview-clean

Conversation

@steipete

@steipete steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

The Control UI file preview modal displayed the Escape shortcut twice: once beside the file-count header and again on the Close button.

Fixes #99027. Supersedes #99029 after its contributor fork could not retain clean rebased ancestry; contributor credit is preserved through co-authorship and the maintainer release-note batch.

Why This Change Was Made

The header-only badge and its orphaned style are removed. The Close button remains the single visible shortcut hint beside the action it documents, and the existing document-level Escape handler remains unchanged. A focused regression test asserts that only the Close button contains the hint.

User Impact

File previews show one clear Escape shortcut hint without changing keyboard behavior.

Evidence

  • Blacksmith Testbox tbx_01kwtdcpm4pefrxn940m0gy2mf: 5 focused file-preview component tests passed.
  • Same Testbox: pnpm check:changed passed.
  • In-app browser against the reviewed component: dialog role present, ready state true, zero header esc badges, Close button text Close esc, and Escape close behavior retained.
  • git diff --check passed.
  • Fresh autoreview found no accepted/actionable findings.

One focused maintainer commit; original contributor preserved with Co-authored-by: 咸士山 0668001391 <[email protected]>.

AI-assisted: Yes (Codex).

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui size: XS maintainer Maintainer-authored PR labels Jul 6, 2026
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Land-ready maintainer pass complete on 42629cf0e9c08b12e993e2b88873336f5c080651.

Verification:

No known proof gaps for the touched file-preview surface.

@steipete
steipete merged commit 797bca2 into main Jul 6, 2026
94 of 96 checks passed
@steipete
steipete deleted the codex/pr-99029-file-preview-clean branch July 6, 2026 01:25
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: web-ui App: web-ui maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant "esc" label in file preview modal header

1 participant