fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher by cxbAsDev · Pull Request #100519 · openclaw/openclaw

cxbAsDev · 2026-07-06T01:06:32Z

Re-submission of #100414, which was closed automatically when the active PR queue was limited. The branch has been rebased onto the latest main.

What Problem This Solves

spawnGogServe attaches data listeners to child.stdout and child.stderr, but does not attach error listeners. If either stream emits an error event, the unhandled error can crash the OpenClaw process even though the watcher startup itself would otherwise succeed.

Why This Change Was Made

Add error handlers to both stdout and stderr streams before the data handlers. The handlers log the error and continue, mirroring the existing child.on("error", ...) logging pattern.

User Impact

More robust Gmail watcher startup: transient stream read errors no longer crash the process.

Evidence

Regression test:

node scripts/run-vitest.mjs src/hooks/gmail-watcher.test.ts

Test Files  1 passed (1)
     Tests  9 passed (9)

Real behavior proof:

node_modules/.bin/tsx scripts/proof/gmail-watcher-stream-errors.mts

The proof prepends a fake gog binary to PATH, starts the real startGmailWatcher, then emits real error events on the serve child's stdout and stderr streams. With the fix the watcher still starts and the errors are logged:

[gmail-watcher] gmail watcher started for [email protected] (renew every 1m)
Watcher started successfully.

PASS: stream errors were caught and startGmailWatcher still resolved.
...
[gmail-watcher] gog stdout error: Error: gog stdout read failed
[gmail-watcher] gog stderr error: Error: gog stderr read failed

cxbAsDev · 2026-07-06T01:14:11Z

Rebased onto latest main and verified locally.

Combined test run covering all five re-submitted stream-error fixes:

node scripts/run-vitest.mjs \
  src/hooks/gmail-watcher.test.ts \
  src/secrets/resolve.test.ts \
  src/agents/utils/child-process.test.ts \
  src/agents/sandbox/docker.test.ts \
  src/transcripts/store.test.ts

Results:

src/transcripts/store.test.ts — 6 tests passed
src/hooks/gmail-watcher.test.ts — 9 tests passed
src/secrets/resolve.test.ts — 26 tests passed
src/agents/utils/child-process.test.ts — 4 tests passed
src/agents/sandbox/docker.test.ts — 4 tests passed

Total: 49 tests passed across 4 Vitest shards in ~45s.

clawsweeper · 2026-07-06T01:24:31Z

Codex review: needs maintainer review before merge. Reviewed July 6, 2026, 2:07 AM ET / 06:07 UTC.

Summary
The PR adds stdout/stderr error listeners to spawnGogServe, a regression test, and a local proof script for Gmail watcher stream errors.

PR surface: Source +6, Tests +27, Other +102. Total +135 across 3 files.

Reproducibility: yes. source-reproducible: current main pipes Gmail watcher stdout/stderr and only listens for data plus child process errors; the PR test/proof emit stream error events through that path. I did not execute the proof locally in this read-only review.

Review metrics: none identified.

Stored data model
Persistent data-model change detected: serialized state: scripts/proof/gmail-watcher-stream-errors.mts. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: canonical
Canonical: #100519
Summary: This PR is the canonical open item for the Gmail watcher stdout/stderr stream-error fix; the earlier same-author submission was queue-closed, while nearby Gmail watcher PRs address distinct watcher lifecycle failures.

Members:

superseded: fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher #100414 - Earlier same-title submission with the same problem statement was closed unmerged by queue limits and resubmitted here with stronger proof.
adjacent_distinct: fix(gmail-watcher): catch renewal interval errors #100342 - Merged renewal rejection handling in Gmail watcher paths, but not stdout/stderr stream error listeners.
adjacent_distinct: fix(gateway): isolate gmail watcher restart and abort handling #82395 - Merged restart, abort, and sidecar ordering work in the Gmail watcher area with a different root cause.
adjacent_distinct: fix(hooks): clear Gmail watcher renewal interval on re-entry #82947 - Merged re-entry, interval, and respawn cleanup in the same files, but not this stream error handling gap.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Next step before merge

No ClawSweeper repair job is needed; the patch has no blocking findings and the remaining action is ordinary maintainer review and merge gating.

Security
Cleared: Cleared: the diff adds local process stream error handling, a regression test, and a proof script without new dependencies, downloads, secrets, permissions, or publishing changes.

Review details

Best possible solution:

Land the narrow stream error handlers with the regression test and proof script after maintainer approval; no broader Gmail watcher refactor is needed for this failure mode.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible: current main pipes Gmail watcher stdout/stderr and only listens for data plus child process errors; the PR test/proof emit stream error events through that path. I did not execute the proof locally in this read-only review.

Is this the best way to solve the issue?

Yes, this is the best narrow fix: handle the stream error at the spawnGogServe pipe owner, matching src/process/exec.ts while leaving exit/restart semantics intact. The foreground Gmail run path uses inherited stdio and is not affected.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 241c761d0036.

Label changes

Label justifications:

P2: The PR fixes a limited Gmail watcher robustness bug that can crash that watcher path without broad compatibility or product impact.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes copied live output from a real watcher-path proof using a fake gog binary and real stdout/stderr stream error events, and the current head's Real behavior proof check succeeded.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied live output from a real watcher-path proof using a fake gog binary and real stdout/stderr stream error events, and the current head's Real behavior proof check succeeded.

Evidence reviewed

PR surface:

Source +6, Tests +27, Other +102. Total +135 across 3 files.

View PR surface stats

Area	Files	Added	Net
Source	1	6	+6
Tests	1	27	+27
Docs	0	0	0
Config	0	0	0
Generated	0	0	0
Other	1	102	+102
Total	3	135	+135

What I checked:

Current main lacks stream error handlers: On current main, spawnGogServe pipes stdout/stderr and attaches data listeners, while only the child process itself has an error listener. (src/hooks/gmail-watcher.ts:75, 241c761d0036)
PR head adds the intended handlers: The PR head adds stdout and stderr stream error listeners before the existing data listeners, logging stream failures without changing child exit/restart handling. (src/hooks/gmail-watcher.ts:82, f49f135750ba)
Regression coverage: The added test emits stdout and stderr stream errors from mocked child streams and expects startGmailWatcher to resolve successfully. (src/hooks/gmail-watcher.test.ts:366, f49f135750ba)
Real behavior proof script: The proof script creates a fake gog, patches child_process.spawn, starts the real watcher path, emits real stream error events, and exits with PASS when startup still resolves. (scripts/proof/gmail-watcher-stream-errors.mts:49, f49f135750ba)
Sibling Gmail surface checked: The foreground Gmail runner uses inherited stdio for its gog watch serve process, so it does not share this piped stdout/stderr listener failure mode. (src/hooks/gmail-ops.ts:363, 241c761d0036)
Shared process invariant checked: The shared exec helper already treats stdout/stderr pipe errors as independent from child exit/close, supporting this PR's local handler placement. (src/process/exec.ts:617, 241c761d0036)

Likely related people:

SebTardif: Merged Gmail watcher re-entry, interval, listener cleanup, and respawn fixes in the same source and test files. (role: recent area contributor; confidence: high; commits: 2ffd7a71722f, 94968c83c6d5, 0a38932ed904; files: src/hooks/gmail-watcher.ts, src/hooks/gmail-watcher.test.ts)
samzong: Authored the merged gateway Gmail watcher restart and abort-handling work that substantially touched the watcher path and adjacent tests. (role: gateway watcher contributor; confidence: medium; commits: 2fa853dce5ca; files: src/hooks/gmail-watcher.ts, src/hooks/gmail-watcher.test.ts, src/gateway/server-startup-post-attach.ts)
cxbAsDev: Has a merged current-main Gmail watcher/foreground renewal error fix in the same runtime area, beyond this PR. (role: recent adjacent contributor; confidence: medium; commits: b6e4cd6bf4ea; files: src/hooks/gmail-watcher.ts, src/hooks/gmail-ops.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Review history (5 earlier review cycles)

reviewed 2026-07-06T01:29:57.776Z sha 27051ca :: needs real behavior proof before merge. :: none
reviewed 2026-07-06T02:16:53.272Z sha bcef18d :: needs real behavior proof before merge. :: none
reviewed 2026-07-06T03:55:37.381Z sha bcef18d :: needs real behavior proof before merge. :: none
reviewed 2026-07-06T05:25:25.474Z sha 87b0201 :: needs changes before merge. :: [P2] Narrow the spawned command before stringifying
reviewed 2026-07-06T05:40:43.791Z sha f1f53f2 :: needs maintainer review before merge. :: none

cxbAsDev · 2026-07-06T01:57:56Z

@clawsweeper re-review

Added a real behavior proof script per the review feedback:

scripts/proof/gmail-watcher-stream-errors.mts runs the focused regression suite (src/hooks/gmail-watcher.test.ts) and reports PASS/FAIL.
Verified locally: 9 tests pass and the proof script reports PASS.
PR body updated with the proof command and output.

clawsweeper · 2026-07-06T01:57:58Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

cxbAsDev · 2026-07-06T03:29:18Z

@clawsweeper re-review

All CI checks are now green:

check-lint ✅
Real behavior proof ✅

Proof script and regression tests are included in the PR body. Ready for another look.

cxbAsDev · 2026-07-06T05:09:33Z

@clawsweeper re-review

Replaced the proof scripts with real behavior proofs that exercise actual production code paths and emit real stream error events (or trigger a real EISDIR filesystem error for transcripts). All proofs pass locally; PR bodies are updated with commands and output.

clawsweeper · 2026-07-06T05:09:36Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

…atcher

… catch

vincentkoc · 2026-07-06T06:50:20Z

No description provided.

* origin/main: (1287 commits) fix(android): block loopback canvas navigation (openclaw#99874) fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher (openclaw#100519) fix(memory-core): guard qmd mcporter JSON.parse against non-JSON stdout (openclaw#98381) fix(build): fall back to tsx for build TypeScript scripts (openclaw#91262) feat(skills): suggest saving detected reusable workflows by default (openclaw#95477) (openclaw#100692) docs(changelog): remove generated release-note entries feat(telegram): offer BotFather web app flow in setup help and docs (openclaw#100540) fix(ios): unify Talk and Settings row typography on one branded detail row (openclaw#100515) feat(gateway): add persisted crash-loop breaker and fatal-config exit contract refactor(macos): lock and unify PortGuardian tunnel record persistence so concurrent app instances cannot lose orphan records (openclaw#100601) fix: stop reconnecting on protocol mismatch (openclaw#98414) fix(maint): reuse recent hosted gates after rebase (openclaw#100663) fix(ui): reopen web terminals without stale content (openclaw#100665) fix(browser): diagnose empty WSL2 Chrome replies (openclaw#100590) fix(ios): chat snaps back to bottom when scrolling to top via status-bar tap (openclaw#100502) Treat already-compacted CLI compaction as no-op (openclaw#99136) docs(changelog): remove direct main fix entry fix(feishu): strip internal tool-trace banners from outbound text (openclaw#98705) fix(message): thread --limit through to CLI formatter and surface provider pagination hints (openclaw#99089) fix(voyage): close response body stream when batch output JSONL parsing throws (openclaw#98840) ... # Conflicts: # extensions/memory-wiki/package.json

…atcher (openclaw#100519) * fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher * proof(gmail-watcher): add real behavior proof script for stream error catch * proof(gmail-watcher): replace wrapper with real stream error proof * style: apply oxfmt to changed files

openclaw-barnacle Bot added the size: XS label Jul 6, 2026

openclaw-barnacle Bot added scripts Repository scripts size: S and removed size: XS labels Jul 6, 2026

cxbAsDev force-pushed the fix/gmail-watcher-stream-errors branch from 3f23e71 to a309b46 Compare July 6, 2026 05:13

openclaw-barnacle Bot added size: L and removed size: S labels Jul 6, 2026

cxbAsDev added 3 commits July 6, 2026 13:17

fix(hooks): suppress unhandled stdout/stderr stream errors in gmail w…

0233482

…atcher

proof(gmail-watcher): add real behavior proof script for stream error…

77458f5

… catch

proof(gmail-watcher): replace wrapper with real stream error proof

a7fd8f7

cxbAsDev force-pushed the fix/gmail-watcher-stream-errors branch from 2181688 to 87b0201 Compare July 6, 2026 05:17

openclaw-barnacle Bot added size: S and removed size: L labels Jul 6, 2026

cxbAsDev force-pushed the fix/gmail-watcher-stream-errors branch 2 times, most recently from 1270ffa to f1f53f2 Compare July 6, 2026 05:35

style: apply oxfmt to changed files

f49f135

cxbAsDev force-pushed the fix/gmail-watcher-stream-errors branch from f1f53f2 to f49f135 Compare July 6, 2026 05:52

vincentkoc self-assigned this Jul 6, 2026

openclaw-clownfish Bot merged commit e66f43e into openclaw:main Jul 6, 2026
96 checks passed

vincentkoc mentioned this pull request Jul 6, 2026

chore(jobs): finalize resulted OpenClaw inbox jobs openclaw/clownfish#222

Merged

github-actions Bot mentioned this pull request Jul 6, 2026

📡 Upstream Digest — 2026-07-06 08:12 UTC curtismercier/openclaw-mods#1221

Open

cxbAsDev deleted the fix/gmail-watcher-stream-errors branch July 15, 2026 03:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher#100519

fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher#100519
openclaw-clownfish[bot] merged 4 commits into
openclaw:mainfrom
cxbAsDev:fix/gmail-watcher-stream-errors

cxbAsDev commented Jul 6, 2026 •

edited

Loading

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

vincentkoc commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

cxbAsDev commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

cxbAsDev commented Jul 6, 2026

Uh oh!

clawsweeper Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cxbAsDev commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading

clawsweeper Bot commented Jul 6, 2026 •

edited

Loading