Skip to content

fix(build): make tsdown configs self-contained#100499

Merged
steipete merged 1 commit into
mainfrom
fix/tsdown-config-self-contained
Jul 6, 2026
Merged

fix(build): make tsdown configs self-contained#100499
steipete merged 1 commit into
mainfrom
fix/tsdown-config-self-contained

Conversation

@steipete

@steipete steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the unnecessary runtime defineConfig import from both tsdown configs
  • preserve type checking with satisfies UserConfig
  • add a regression test preventing runtime imports from tsdown

Why

scripts/tsdown-build.mjs deliberately uses the unrun config loader. unrun evaluates a generated module from a temporary directory, where a bare runtime import of tsdown can fail package resolution. defineConfig is an identity helper, so exporting typed config values directly preserves behavior and makes the configs self-contained.

Proof

  • pnpm exec vitest run test/scripts/tsdown-config.test.ts (4 passed)
  • ALLOW_ADHOC_SIGNING=1 pnpm mac:package
  • autoreview: implementation accepted; changelog-removal suggestion rejected because repository instructions require changelog entries for user-facing fixes

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jul 6, 2026
@steipete
steipete merged commit c9349d1 into main Jul 6, 2026
35 of 37 checks passed
@steipete
steipete deleted the fix/tsdown-config-self-contained branch July 6, 2026 00:06
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 6, 2026
giodl73-repo pushed a commit to giodl73-repo/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants