Skip to content

fix(release): package legacy candidates without AI workspace#100469

Merged
vincentkoc merged 1 commit into
mainfrom
fix/release-package-legacy-candidate
Jul 5, 2026
Merged

fix(release): package legacy candidates without AI workspace#100469
vincentkoc merged 1 commit into
mainfrom
fix/release-package-legacy-candidate

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

No description provided.

@vincentkoc vincentkoc self-assigned this Jul 5, 2026
@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts docker Docker and sandbox tooling size: S maintainer Maintainer-authored PR labels Jul 5, 2026
@clawsweeper

clawsweeper Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 5:58 PM ET / 21:58 UTC.

Summary
The PR makes the Docker release package helper skip @openclaw/ai workspace staging for source trees that predate the AI workspace and adds e2e coverage for legacy and incomplete AI-workspace cases.

PR surface: Tests +62, Other +18. Total +80 across 2 files.

Reproducibility: yes. from source inspection: current main unconditionally rejects package sources without dependencies.@openclaw/ai before npm pack, so a pre-AI-workspace source ref without that dependency hits the failure path. I did not run a historical ref because this review was read-only.

Review metrics: 1 noteworthy metric.

  • Release package compatibility path: 1 added legacy no-op branch. Maintainers should notice that this changes release candidate packaging behavior for older source refs while leaving incomplete current AI-workspace sources fail-closed.

Stored data model
Persistent data-model change detected: serialized state: test/e2e/qa-lab/runtime/package-openclaw-for-docker.e2e.test.ts. Confirm migration or upgrade compatibility proof before merge.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P2] No repair lane is needed because the maintainer-owned PR has no concrete review finding; it should proceed through normal exact-head CI and maintainer merge handling.

Security
Cleared: The diff touches release packaging but adds no dependencies, downloads, permissions, or secret handling, and it keeps malformed AI-workspace sources fail-closed.

Review details

Best possible solution:

Land the narrow release-packager compatibility fix once exact-head CI is acceptable, while preserving hard failures for malformed AI-workspace package sources.

Do we have a high-confidence way to reproduce the issue?

Yes from source inspection: current main unconditionally rejects package sources without dependencies.@openclaw/ai before npm pack, so a pre-AI-workspace source ref without that dependency hits the failure path. I did not run a historical ref because this review was read-only.

Is this the best way to solve the issue?

Yes, this is the narrowest maintainable fix I found: keep the compatibility decision inside the package helper and preserve strict errors for inconsistent AI-workspace sources. Moving the workaround into release-candidate resolution would duplicate packaging policy across callers.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 1a37cafd63b6.

Label changes

Label changes:

  • add P2: This is a narrow release-packaging regression fix with limited blast radius and no evidence of an active user-facing outage.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a maintainer-authored PR with the maintainer label, so the external-contributor real-behavior-proof gate does not apply.

Label justifications:

  • P2: This is a narrow release-packaging regression fix with limited blast radius and no evidence of an active user-facing outage.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a maintainer-authored PR with the maintainer label, so the external-contributor real-behavior-proof gate does not apply.
Evidence reviewed

PR surface:

Tests +62, Other +18. Total +80 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 62 0 +62
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 1 19 1 +18
Total 2 81 1 +80

What I checked:

Likely related people:

  • vincentkoc: Recent current-main history touches the same release package and cross-OS candidate packaging surface, including package tarball runtime checks and pnpm candidate packing. (role: recent area contributor; confidence: high; commits: 63257a2b0eec, 0cd2bc474fa8, a1aaa1c6debb; files: scripts/package-openclaw-for-docker.mjs, scripts/check-openclaw-package-tarball.mjs, scripts/openclaw-cross-os-release-checks.ts)
  • steipete: The @openclaw/ai workspace split in refactor: extract reusable AI runtime package #99059 created the packaging invariant this PR now makes backward-compatible for older refs. (role: adjacent feature owner; confidence: medium; commits: 42aa617a9f86, 43625f733916, 1833c0d77180; files: packages/ai/package.json, scripts/package-openclaw-for-docker.mjs, test/e2e/qa-lab/runtime/package-openclaw-for-docker.e2e.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 5, 2026
@vincentkoc
vincentkoc merged commit c4a862a into main Jul 5, 2026
131 of 137 checks passed
@vincentkoc
vincentkoc deleted the fix/release-package-legacy-candidate branch July 5, 2026 22:19
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Docker and sandbox tooling maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. scripts Repository scripts size: S status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant