fix(release): package legacy candidates without AI workspace#100469
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 5:58 PM ET / 21:58 UTC. Summary PR surface: Tests +62, Other +18. Total +80 across 2 files. Reproducibility: yes. from source inspection: current main unconditionally rejects package sources without dependencies.@openclaw/ai before npm pack, so a pre-AI-workspace source ref without that dependency hits the failure path. I did not run a historical ref because this review was read-only. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the narrow release-packager compatibility fix once exact-head CI is acceptable, while preserving hard failures for malformed AI-workspace package sources. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main unconditionally rejects package sources without dependencies.@openclaw/ai before npm pack, so a pre-AI-workspace source ref without that dependency hits the failure path. I did not run a historical ref because this review was read-only. Is this the best way to solve the issue? Yes, this is the narrowest maintainable fix I found: keep the compatibility decision inside the package helper and preserve strict errors for inconsistent AI-workspace sources. Moving the workaround into release-candidate resolution would duplicate packaging policy across callers. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1a37cafd63b6. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +62, Other +18. Total +80 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
No description provided.